From patchwork Thu Jun 12 11:53:20 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sricharan R X-Patchwork-Id: 31825 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-ie0-f200.google.com (mail-ie0-f200.google.com [209.85.223.200]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id C67F120AE6 for ; Thu, 12 Jun 2014 11:59:06 +0000 (UTC) Received: by mail-ie0-f200.google.com with SMTP id tr6sf5641081ieb.11 for ; Thu, 12 Jun 2014 04:59:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:sender:precedence:list-id :x-original-sender:x-original-authentication-results:mailing-list :list-post:list-help:list-archive:list-unsubscribe:content-type; bh=8uUMx9g6gC0kCmuijLIZsxaD2O7FALT4r2IWjL3Zxmw=; b=V7OUeOYwueGQGEvYqeplT+ItIEv8N73nRz7ZoCSD8xGznf5TVPY74BryKz5+aPe2vd vkJk95wLtZTbYBLbt5jpWkJ91oTXeEy9hg0FF3TOELTjXZBNLUnFVQOs1c5chiUud2qo fpMpflQiVm9Aovxgf4dBXTBLUwYLGhOxWGLf8xQjwUTDcGM2P9Cti2Sn62ZuzdxdOkhy z/bywIBTTrqOop/oxgyTEpG/XxBlAJW2snqwRVYsuucMv9nT8987HyzK+nR2BG9a4Yz9 fWt4PCMl97wmB9AQCfJpCfbea7Xln87XIFd7mAut4xHDjBLubvnnYsLuzmXzSDfqNrib /SlQ== X-Gm-Message-State: ALoCoQnbFOgzSpBdQn30IR/qGD28AxPs0WktY3jQdVFYQyW2mbUK+NJM1ON6PLPbht0MZOOPW5lO X-Received: by 10.43.92.195 with SMTP id br3mr19643947icc.1.1402574346240; Thu, 12 Jun 2014 04:59:06 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.97.7 with SMTP id l7ls256936qge.63.gmail; Thu, 12 Jun 2014 04:59:06 -0700 (PDT) X-Received: by 10.52.185.39 with SMTP id ez7mr7848746vdc.7.1402574346107; Thu, 12 Jun 2014 04:59:06 -0700 (PDT) Received: from mail-vc0-f178.google.com (mail-vc0-f178.google.com [209.85.220.178]) by mx.google.com with ESMTPS id ez8si237266vdc.81.2014.06.12.04.59.06 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 12 Jun 2014 04:59:06 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.220.178 as permitted sender) client-ip=209.85.220.178; Received: by mail-vc0-f178.google.com with SMTP id ij19so676649vcb.9 for ; Thu, 12 Jun 2014 04:59:06 -0700 (PDT) X-Received: by 10.52.29.236 with SMTP id n12mr972761vdh.38.1402574345971; Thu, 12 Jun 2014 04:59:05 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.221.54.6 with SMTP id vs6csp397269vcb; Thu, 12 Jun 2014 04:59:05 -0700 (PDT) X-Received: by 10.68.106.130 with SMTP id gu2mr11832944pbb.59.1402574345177; Thu, 12 Jun 2014 04:59:05 -0700 (PDT) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id gz4si886662pac.61.2014.06.12.04.59.04; Thu, 12 Jun 2014 04:59:04 -0700 (PDT) Received-SPF: none (google.com: linux-kernel-owner@vger.kernel.org does not designate permitted sender hosts) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933796AbaFLL5A (ORCPT + 27 others); Thu, 12 Jun 2014 07:57:00 -0400 Received: from devils.ext.ti.com ([198.47.26.153]:58249 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933586AbaFLL4v (ORCPT ); Thu, 12 Jun 2014 07:56:51 -0400 Received: from dflxv15.itg.ti.com ([128.247.5.124]) by devils.ext.ti.com (8.13.7/8.13.7) with ESMTP id s5CBuIwp009428; Thu, 12 Jun 2014 06:56:18 -0500 Received: from DLEE71.ent.ti.com (dlee71.ent.ti.com [157.170.170.114]) by dflxv15.itg.ti.com (8.14.3/8.13.8) with ESMTP id s5CBuIhw023616; Thu, 12 Jun 2014 06:56:18 -0500 Received: from dflp32.itg.ti.com (10.64.6.15) by DLEE71.ent.ti.com (157.170.170.114) with Microsoft SMTP Server id 14.3.174.1; Thu, 12 Jun 2014 06:56:18 -0500 Received: from uda0393807.india.ti.com. (ileax41-snat.itg.ti.com [10.172.224.153]) by dflp32.itg.ti.com (8.14.3/8.13.8) with ESMTP id s5CBtEc1008910; Thu, 12 Jun 2014 06:56:14 -0500 From: Sricharan R To: , , , CC: , , , , , , , Subject: [PATCH V2 12/19] irqchip: crossbar: return proper error value Date: Thu, 12 Jun 2014 17:23:20 +0530 Message-ID: <1402574007-13987-13-git-send-email-r.sricharan@ti.com> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1402574007-13987-1-git-send-email-r.sricharan@ti.com> References: <1402574007-13987-1-git-send-email-r.sricharan@ti.com> MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: r.sricharan@ti.com X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.220.178 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , From: Nishanth Menon crossbar_of_init always returns -ENOMEM in case of errors, return proper error results in case of failures. Signed-off-by: Nishanth Menon --- drivers/irqchip/irq-crossbar.c | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/drivers/irqchip/irq-crossbar.c b/drivers/irqchip/irq-crossbar.c index fea3e5d..524e6e9 100644 --- a/drivers/irqchip/irq-crossbar.c +++ b/drivers/irqchip/irq-crossbar.c @@ -140,20 +140,26 @@ static const struct irq_domain_ops routable_irq_domain_ops = { static int __init crossbar_of_init(struct device_node *node, const struct crossbar_data *data) { - int i, size, max, reserved = 0, entry, safe_map; + int i, size, max = 0, reserved = 0, entry, safe_map; const __be32 *irqsr; const int *irqsk = NULL; + int ret = -ENOMEM; cb = kzalloc(sizeof(*cb), GFP_KERNEL); if (!cb) - return -ENOMEM; + return ret; cb->crossbar_base = of_iomap(node, 0); if (!cb->crossbar_base) goto err1; of_property_read_u32(node, "ti,max-irqs", &max); + if (!max) { + pr_err("missing 'ti,max-irqs' property\n"); + ret = -EINVAL; + goto err2; + } cb->irq_map = kcalloc(max, sizeof(int), GFP_KERNEL); if (!cb->irq_map) goto err2; @@ -174,6 +180,7 @@ static int __init crossbar_of_init(struct device_node *node, i, &entry); if (entry > max) { pr_err("Invalid reserved entry\n"); + ret = -EINVAL; goto err3; } cb->irq_map[entry] = IRQ_RESERVED; @@ -198,6 +205,7 @@ static int __init crossbar_of_init(struct device_node *node, break; default: pr_err("Invalid reg-size property\n"); + ret = -EINVAL; goto err4; break; } @@ -225,6 +233,7 @@ static int __init crossbar_of_init(struct device_node *node, if (entry > max) { pr_err("Invalid skip entry\n"); + ret = -EINVAL; goto err4; } cb->irq_map[entry] = IRQ_SKIP; @@ -250,7 +259,7 @@ err2: iounmap(cb->crossbar_base); err1: kfree(cb); - return -ENOMEM; + return ret; } /* irq number 10,133,139 and 140 cannot be used because of hw bug */