mbox series

[00/10] clk: ti: Adjustments for eight function implementations

Message ID 20849a8e-e0f5-46df-ad8a-9eae6cbe337b@web.de
Headers show
Series clk: ti: Adjustments for eight function implementations | expand

Message

Markus Elfring Dec. 24, 2023, 4:33 p.m. UTC
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sun, 24 Dec 2023 17:03:21 +0100

Several update suggestions were taken into account
from static source code analysis.

Markus Elfring (10):
  Less function calls in of_omap2_apll_setup() after error detection
  Less function calls in of_dra7_apll_setup() after error detection
  Use common code in omap_clk_register_apll()
  Less function calls in ti_fapll_setup() after error detection
  One function call less in ti_fapll_synth_setup() after error detection
  Return directly after a failed kzalloc() in of_mux_clk_setup()
  Less function calls in _ti_omap4_clkctrl_setup() after error detection
  Use common error handling code in _ti_omap4_clkctrl_setup()
  Less function calls in _ti_clkctrl_clk_register() after error detection
  Delete an unnecessary initialisation in _ti_clkctrl_clk_register()

 drivers/clk/ti/apll.c    | 58 ++++++++++++++++++++++++----------------
 drivers/clk/ti/clkctrl.c | 44 ++++++++++++++++--------------
 drivers/clk/ti/fapll.c   | 29 +++++++++++---------
 drivers/clk/ti/mux.c     |  2 +-
 4 files changed, 76 insertions(+), 57 deletions(-)

--
2.43.0

Comments

Andy Shevchenko Dec. 27, 2023, 4:39 p.m. UTC | #1
On Sun, Dec 24, 2023 at 05:33:53PM +0100, Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Sun, 24 Dec 2023 17:03:21 +0100
> 
> Several update suggestions were taken into account
> from static source code analysis.

Unneeded churn, if you want to make it better, switch the code to use
cleanup.h.
Tony Lindgren Feb. 20, 2024, 9:27 a.m. UTC | #2
* Andy Shevchenko <andriy.shevchenko@linux.intel.com> [231227 16:39]:
> On Sun, Dec 24, 2023 at 05:33:53PM +0100, Markus Elfring wrote:
> > From: Markus Elfring <elfring@users.sourceforge.net>
> > Date: Sun, 24 Dec 2023 17:03:21 +0100
> > 
> > Several update suggestions were taken into account
> > from static source code analysis.
> 
> Unneeded churn, if you want to make it better, switch the code to use
> cleanup.h.

Yes cleanup.h sounds good to me too.

Regards,

Tony