mbox series

[V2,0/2] dt-bindings: opp/cpufreq: Convert ti-cpufreq to json schema

Message ID 20230801233341.1416552-1-nm@ti.com
Headers show
Series dt-bindings: opp/cpufreq: Convert ti-cpufreq to json schema | expand

Message

Nishanth Menon Aug. 1, 2023, 11:33 p.m. UTC 
Hi,

Convert the long pending free-form text bindings of ti-cpufreq and
omap5-opp-supply bindings to json-schema.

Changes from V1:
* Tony has picked up 1-3 of v1 dt cleanups[1]
* Fixup the bindings for the various review comments received.

V1: https://lore.kernel.org/all/20230724153911.1376830-1-nm@ti.com/

Nishanth Menon (2):
  dt-bindings: opp: Convert ti-omap5-opp-supply to json schema
  dt-bindings: cpufreq: Convert ti-cpufreq to json schema

 .../bindings/cpufreq/ti-cpufreq.txt           | 132 ------------------
 .../opp/operating-points-v2-ti-cpu.yaml       |  88 ++++++++++++
 .../bindings/opp/ti,omap-opp-supply.yaml      | 103 ++++++++++++++
 .../bindings/opp/ti-omap5-opp-supply.txt      |  63 ---------
 4 files changed, 191 insertions(+), 195 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/cpufreq/ti-cpufreq.txt
 create mode 100644 Documentation/devicetree/bindings/opp/operating-points-v2-ti-cpu.yaml
 create mode 100644 Documentation/devicetree/bindings/opp/ti,omap-opp-supply.yaml
 delete mode 100644 Documentation/devicetree/bindings/opp/ti-omap5-opp-supply.txt

[1] https://lore.kernel.org/all/20230731062551.GH5194@atomide.com/

Comments

Dhruva Gole Aug. 3, 2023, 6:01 a.m. UTC | #1 
On Aug 01, 2023 at 18:33:41 -0500, Nishanth Menon wrote:
> Move the ti-cpufreq binding over to opp and convert convert the free

Minor nitpik, maybe can be fixed while applying the patch. Checkpatch caught this,
Possible repeated word: 'convert'

> text binding to json-schema.
> 
> Signed-off-by: Nishanth Menon <nm@ti.com>
> ---

Otherwise, LGTM

Reviewed-by: Dhruva Gole <d-gole@ti.com>

> Changes since V1:
> - Fixup $subject of the patch to indicate json schema rather than yaml.
> - Change filename to matchup with binding compatible
> - Dropped un-used labels
> - Dropped "|" in "description"
> 
> V1: https://lore.kernel.org/all/20230724153911.1376830-6-nm@ti.com/
> 
> Side note: cleanups in dt is picked up on Tony's tree:
> https://lore.kernel.org/all/20230731062551.GH5194@atomide.com/
> 
>  .../bindings/cpufreq/ti-cpufreq.txt           | 132 ------------------
>  .../opp/operating-points-v2-ti-cpu.yaml       |  88 ++++++++++++
>  2 files changed, 88 insertions(+), 132 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/cpufreq/ti-cpufreq.txt
>  create mode 100644 Documentation/devicetree/bindings/opp/operating-points-v2-ti-cpu.yaml
> 
> diff --git a/Documentation/devicetree/bindings/cpufreq/ti-cpufreq.txt b/Documentation/devicetree/bindings/cpufreq/ti-cpufreq.txt
> deleted file mode 100644
[..snip..]