mbox series

[v2,0/2] add support for Phytec PCM-049 and PCM-959

Message ID 20221123233209.1854806-1-colin.foster@in-advantage.com
Headers show
Series add support for Phytec PCM-049 and PCM-959 | expand

Message

Colin Foster Nov. 23, 2022, 11:32 p.m. UTC 
As should be clear for the title and patch title, this is adding initial
support for the OMAP 4460 SOM and dev kit for Phytec's PCM959 evaluation
kit.

The PCM049 is a legacy SOM offered by Phytec:
https://www.phytec.com/legacy-soms/
There was a vendor BSP offered by Phytec, but that never entered the
Device Tree era. This patch is meant to change that.

My development bootloader has moved to U-Boot, but I have verified
Barebox works in the past. When booting from SD card, either bootloader
should work. When booting from Barebox, the NAND OOB layout is
incompatible between the bootloader and the kernel.

I haven't had any OOB / ECC errors in the NAND at all, which was my
main concern. Due to that, I'm submitting this as a patch instead of
an RFC. Hardware ECC correction seems to be fully functional.



v1->v2
    * Almost everything moved into the SOM (PCM-049) .dtsi. Only the
      LED chip is dev-board specific.
    * Fix pinmux associations (*pmx_core was applying *pmx_wkup
      entries... I'm surprised that didn't cause more issues)
    * Documentation added

    * Updates from review:
    *   Board compatible strings added
    *   Hyphen / underscore changes
    *   Remove unnecessary status="okay" entries
    *   Generic names used (regulator, led-1, etc.)


Colin Foster (2):
  dt-bindings: arm: omap: add phytec pcm-049 som and pcm-959 dev board
  arm: dts: omap4: pcm959: add initial support for phytec pcm959

 .../devicetree/bindings/arm/omap/omap.txt     |   3 +
 arch/arm/boot/dts/Makefile                    |   1 +
 arch/arm/boot/dts/omap4-phytec-pcm-049.dtsi   | 412 ++++++++++++++++++
 arch/arm/boot/dts/omap4-phytec-pcm-959.dts    |  48 ++
 4 files changed, 464 insertions(+)
 create mode 100644 arch/arm/boot/dts/omap4-phytec-pcm-049.dtsi
 create mode 100644 arch/arm/boot/dts/omap4-phytec-pcm-959.dts

Comments

Krzysztof Kozlowski Nov. 24, 2022, 11:53 a.m. UTC | #1 
On 24/11/2022 00:32, Colin Foster wrote:
> Add documentation for additional OMAP SOMs and development platforms,
> provided by Phytec as the PCM-049 SOM and the PCM-959 development kit.
> 
> Signed-off-by: Colin Foster <colin.foster@in-advantage.com>
> ---
> 
> v1->v2


Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Would be nice to convert the file to DT Schema.

Best regards,
Krzysztof
Colin Foster Nov. 27, 2022, 11:13 p.m. UTC | #2 
On Thu, Nov 24, 2022 at 12:53:32PM +0100, Krzysztof Kozlowski wrote:
> On 24/11/2022 00:32, Colin Foster wrote:
> > Add documentation for additional OMAP SOMs and development platforms,
> > provided by Phytec as the PCM-049 SOM and the PCM-959 development kit.
> > 
> > Signed-off-by: Colin Foster <colin.foster@in-advantage.com>
> > ---
> > 
> > v1->v2
> 
> 
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> 
> Would be nice to convert the file to DT Schema.

Agreed. Thanks for the Ack despite this.

> 
> Best regards,
> Krzysztof
>