From patchwork Fri Nov 6 21:36:54 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 320839 Delivered-To: patch@linaro.org Received: by 2002:a92:7b12:0:0:0:0:0 with SMTP id w18csp1652298ilc; Fri, 6 Nov 2020 13:41:19 -0800 (PST) X-Google-Smtp-Source: ABdhPJw/yEqJ8O2uqWIX4FKTzDO2eMEw0MuJwf/VJ5zPPgZUfyTLPOLSkOrcdr7wLM0fRz33bRJ+ X-Received: by 2002:a1c:3142:: with SMTP id x63mr1583121wmx.168.1604698879614; Fri, 06 Nov 2020 13:41:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604698879; cv=none; d=google.com; s=arc-20160816; b=xGIpQDZtaldUcp7GJvlmEt50U0nXuQ34BvnzFvKM0xINS4VtL6zUY9Xo9lfr1B1CEV QmNo/9UTnDeOrJzFOPJb+XnguQJMk3+BCbuhRv7sX/pzr6DnvbwBT5LRJjV0EhU/myzQ LF235wjvSkrI/j4tHkxvjq7EkjcguB6Pe6JLdYgO80hQ1fiUvTXTQkDMlFHAYS4wslq5 pbPh3Cth+SrNBoSmfk4UsHeX+vprb/TvdRZnBlxxT2KYwJ4rlXeZd7JbpusVMyU33QQw QmjQEZAtmpyalS78wj89NzXqlurQYZSfYB+nL1nfrAZemaf9+IYDjfrMxaW3tZwIzfyx YASA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:sender:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:dkim-signature; bh=m0U7AHkcmqgMB9xyxvG+4Lp065Be46xfb7GFTvPis/s=; b=EF8R1/S6n8/z601LynA3b0w+1KvwjrWWGaVLxnRzvuVQi7gwMM4dKGaktr91T5RLsy Mk+Aj3H1CIjUh8lzQT0l4jc8HG9hfSG/d//eme/mFyBRcRQEcWq4Rz7Pvy5zgpF8L3+4 bjRoYMeMFBn+dnnlipSEabc9IrXOH1jCpUFhSUIuBFBJWEhtYNi4YEG/hPs3HGViB6IK E2XVy+X3r+K271yj4ZuQMkhTODqy5rsfr3A9zUzJlbAFpnjRFwipH1Rh48qT0D2DpazW T9z8+f03Iw8JcFOwOH0x058nLL/4wWlwrg1+Vi5eaWcDkTQFWO0rzP6Bjw9w41gKlspq Khfw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.infradead.org header.s=merlin.20170209 header.b=3ZSCt0Qm; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=poQNLklB; spf=pass (google.com: best guess record for domain of linux-mtd-bounces+patch=linaro.org@lists.infradead.org designates 2001:8b0:10b:1231::1 as permitted sender) smtp.mailfrom="linux-mtd-bounces+patch=linaro.org@lists.infradead.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from merlin.infradead.org (merlin.infradead.org. [2001:8b0:10b:1231::1]) by mx.google.com with ESMTPS id b197si2322109wmd.37.2020.11.06.13.41.19 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Nov 2020 13:41:19 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-mtd-bounces+patch=linaro.org@lists.infradead.org designates 2001:8b0:10b:1231::1 as permitted sender) client-ip=2001:8b0:10b:1231::1; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.infradead.org header.s=merlin.20170209 header.b=3ZSCt0Qm; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=poQNLklB; spf=pass (google.com: best guess record for domain of linux-mtd-bounces+patch=linaro.org@lists.infradead.org designates 2001:8b0:10b:1231::1 as permitted sender) smtp.mailfrom="linux-mtd-bounces+patch=linaro.org@lists.infradead.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=m0U7AHkcmqgMB9xyxvG+4Lp065Be46xfb7GFTvPis/s=; b=3ZSCt0QmRVvTA7tfzs1MPjPP0 QqcW4auZFtiWizp7sUBeTMTpjx2Nfy5T7Aobs2BJlAgSx/+ihcEkdTrSlMOOuQ4Ko/S1yGNGTqW3d fS9KrjD/5Sr7OiptPqnqQ/eoxHPjLcIxh0vMfzhOcz0sOCoDXXBUBmklJHOHL1mNNl5liSqGoTGbP f5OvpKxF4bkV+FxfqeAAPpBzIK3XwjI3yHM/4J+IgJIDFvNtMCx9IiBOUUaRusJx4ft0aBPr3tNrm d8p8ReAmcPKQTJwFrEKBIsT4X+8XQrqmYDUN39oR7cAXCotjsizra8UBMp8+/pYvxTcMUXB6AU0ug 7G8kIcqWw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kb9T4-0004FS-Bt; Fri, 06 Nov 2020 21:40:22 +0000 Received: from mail-wm1-x341.google.com ([2a00:1450:4864:20::341]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kb9QH-0002i8-7g for linux-mtd@lists.infradead.org; Fri, 06 Nov 2020 21:37:31 +0000 Received: by mail-wm1-x341.google.com with SMTP id s13so2634359wmh.4 for ; Fri, 06 Nov 2020 13:37:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=q+vNLwe5F16Z2TBJiX30i47rVXn5mHmSvb3WUTRtIMc=; b=poQNLklBG9VD9bSVaMR0DgY21arQJh/uXxtA5ESu290rHjoLjWQvik3zagjsugIcia y+rQ7NiGLycGR6M9urqKqqjrOUXi1ZcdAqjZmZtXLKE9AhkCEGuKpBQKeFleKfLIZWZh v4sQcGgigqePRkissvsYtfZSTo8gnZWKR0wS8lNW6fskFNY7LKqqHb8WneUfDiaRagAs nIUUzgiAv3o/kUSs0CZTqszcp6FA636Jc+EHaVaYJ1+6kp/8oUKWsXjluFTJ8dDesyMS okp6PYaJL6x2kntDZ/DKITbXf/euKZFSkRxHUzOy20MgxIAPFY4rbfBzNlVQB70zfLO+ 2JtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=q+vNLwe5F16Z2TBJiX30i47rVXn5mHmSvb3WUTRtIMc=; b=nNxwGBeA9v3VZrYXqeoVzNrTrw6EGHuwNLwe3g96nCXGxXr4beiYw4J1duBKH7AKi2 6gR9brVCHim3PFON8AnK6thzBvq60QA1pU0x0Dl1zsvYQEWeIsS9Lo2K3iZqzlUTI3xJ oZYqkSEdSy224UhgjU4rBmsWz5xjPNJknLjaAVOhNbO+Hgr0DT6re/6OfAQOsHdoDzRi n9SgPvJ7W/ACMWyZAYmr6fiGlXasHblcf2ElEz9soaFFjdeHXF+S/YTRDpa0FOxWbhdY XKDb56YFut6tcPLgYwCjzDZGMTYjWa+Xfk+ld/Y+C2sE3mZxqUr0oYgO7b9V9ZRoLFvq 8rsw== X-Gm-Message-State: AOAM530eQ8HMwbq7TJq7IypmarF2tNkD0tkjtEUtNFdtEZxefq8sS/Q9 abm3OrJQKDzVnHyzqJDWqwad7w== X-Received: by 2002:a1c:9d94:: with SMTP id g142mr1667080wme.66.1604698648278; Fri, 06 Nov 2020 13:37:28 -0800 (PST) Received: from dell.default ([91.110.221.236]) by smtp.gmail.com with ESMTPSA id d16sm3984942wrw.17.2020.11.06.13.37.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Nov 2020 13:37:27 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH v2 22/23] mtd: nand: onenand: onenand_base: Fix some kernel-doc misdemeanours Date: Fri, 6 Nov 2020 21:36:54 +0000 Message-Id: <20201106213655.1838861-23-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201106213655.1838861-1-lee.jones@linaro.org> References: <20201106213655.1838861-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201106_163729_392757_5F13E757 X-CRM114-Status: GOOD ( 18.94 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:341 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Vignesh Raghavendra , Richard Weinberger , linux-kernel@vger.kernel.org, Kyungmin Park , linux-mtd@lists.infradead.org, Miquel Raynal Sender: "linux-mtd" Errors-To: linux-mtd-bounces+patch=linaro.org@lists.infradead.org Fixes the following W=1 kernel build warning(s): drivers/mtd/nand/onenand/onenand_base.c:140: warning: Function parameter or member 'mtd' not described in 'onenand_ooblayout_32_64_ecc' drivers/mtd/nand/onenand/onenand_base.c:140: warning: Function parameter or member 'section' not described in 'onenand_ooblayout_32_64_ecc' drivers/mtd/nand/onenand/onenand_base.c:140: warning: Function parameter or member 'oobregion' not described in 'onenand_ooblayout_32_64_ecc' drivers/mtd/nand/onenand/onenand_base.c:1436: warning: bad line: drivers/mtd/nand/onenand/onenand_base.c:1971: warning: Function parameter or member 'ops' not described in 'onenand_write_oob_nolock' drivers/mtd/nand/onenand/onenand_base.c:1971: warning: Excess function parameter 'len' description in 'onenand_write_oob_nolock' drivers/mtd/nand/onenand/onenand_base.c:1971: warning: Excess function parameter 'retlen' description in 'onenand_write_oob_nolock' drivers/mtd/nand/onenand/onenand_base.c:1971: warning: Excess function parameter 'buf' description in 'onenand_write_oob_nolock' drivers/mtd/nand/onenand/onenand_base.c:1971: warning: Excess function parameter 'mode' description in 'onenand_write_oob_nolock' drivers/mtd/nand/onenand/onenand_base.c:2156: warning: Function parameter or member 'block_size' not described in 'onenand_multiblock_erase' drivers/mtd/nand/onenand/onenand_base.c:2156: warning: Excess function parameter 'region' description in 'onenand_multiblock_erase' drivers/mtd/nand/onenand/onenand_base.c:2771: warning: Function parameter or member 'ops' not described in 'onenand_otp_write_oob_nolock' drivers/mtd/nand/onenand/onenand_base.c:2771: warning: Excess function parameter 'len' description in 'onenand_otp_write_oob_nolock' drivers/mtd/nand/onenand/onenand_base.c:2771: warning: Excess function parameter 'retlen' description in 'onenand_otp_write_oob_nolock' drivers/mtd/nand/onenand/onenand_base.c:2771: warning: Excess function parameter 'buf' description in 'onenand_otp_write_oob_nolock' drivers/mtd/nand/onenand/onenand_base.c:3387: warning: Function parameter or member 'mtd' not described in 'flexonenand_get_boundary' drivers/mtd/nand/onenand/onenand_base.c:3387: warning: Excess function parameter 'onenand_info' description in 'flexonenand_get_boundary' drivers/mtd/nand/onenand/onenand_base.c:3509: warning: Function parameter or member 'mtd' not described in 'flexonenand_check_blocks_erased' drivers/mtd/nand/onenand/onenand_base.c:3509: warning: Excess function parameter 'mtd_info' description in 'flexonenand_check_blocks_erased' drivers/mtd/nand/onenand/onenand_base.c:3557: warning: Function parameter or member 'die' not described in 'flexonenand_set_boundary' drivers/mtd/nand/onenand/onenand_base.c:3557: warning: Function parameter or member 'boundary' not described in 'flexonenand_set_boundary' drivers/mtd/nand/onenand/onenand_base.c:3557: warning: Function parameter or member 'lock' not described in 'flexonenand_set_boundary' Cc: Kyungmin Park Cc: Miquel Raynal Cc: Richard Weinberger Cc: Vignesh Raghavendra Cc: linux-mtd@lists.infradead.org Signed-off-by: Lee Jones --- drivers/mtd/nand/onenand/onenand_base.c | 36 +++++++++++-------------- 1 file changed, 15 insertions(+), 21 deletions(-) -- 2.25.1 ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/ diff --git a/drivers/mtd/nand/onenand/onenand_base.c b/drivers/mtd/nand/onenand/onenand_base.c index 9fca3988ee236..a9fdea26ea464 100644 --- a/drivers/mtd/nand/onenand/onenand_base.c +++ b/drivers/mtd/nand/onenand/onenand_base.c @@ -132,7 +132,7 @@ static const struct mtd_ooblayout_ops onenand_oob_128_ooblayout_ops = { .free = onenand_ooblayout_128_free, }; -/** +/* * onenand_oob_32_64 - oob info for large (2KB) page */ static int onenand_ooblayout_32_64_ecc(struct mtd_info *mtd, int section, @@ -271,7 +271,7 @@ static int onenand_page_address(int page, int sector) * @dataram1: DataRAM index * @sectors: the sector address * @count: the number of sectors - * @return the start buffer value + * Return: the start buffer value * * Setup Start Buffer Register (F200h) */ @@ -1433,7 +1433,7 @@ static int onenand_read_oob_nolock(struct mtd_info *mtd, loff_t from, * @mtd: MTD device structure * @from: offset to read from * @ops: oob operation description structure - + * * Read main and/or out-of-band */ static int onenand_read_oob(struct mtd_info *mtd, loff_t from, @@ -1958,11 +1958,8 @@ static int onenand_write_ops_nolock(struct mtd_info *mtd, loff_t to, /** * onenand_write_oob_nolock - [INTERN] OneNAND write out-of-band * @mtd: MTD device structure - * @to: offset to write to - * @len: number of bytes to write - * @retlen: pointer to variable to store the number of written bytes - * @buf: the data to write - * @mode: operation mode + * @to: offset to write to + * @ops: oob operation description structure * * OneNAND write out-of-band */ @@ -2146,7 +2143,7 @@ static int onenand_multiblock_erase_verify(struct mtd_info *mtd, * onenand_multiblock_erase - [INTERN] erase block(s) using multiblock erase * @mtd: MTD device structure * @instr: erase instruction - * @region: erase region + * @block_size: block size * * Erase one or more blocks up to 64 block at a time */ @@ -2759,10 +2756,8 @@ static int onenand_otp_command(struct mtd_info *mtd, int cmd, loff_t addr, /** * onenand_otp_write_oob_nolock - [INTERN] OneNAND write out-of-band, specific to OTP * @mtd: MTD device structure - * @to: offset to write to - * @len: number of bytes to write - * @retlen: pointer to variable to store the number of written bytes - * @buf: the data to write + * @to: offset to write to + * @ops: oob operation description structure * * OneNAND write out-of-band only for OTP */ @@ -3380,9 +3375,9 @@ static int onenand_check_maf(int manuf) } /** -* flexonenand_get_boundary - Reads the SLC boundary -* @onenand_info: - onenand info structure -**/ + * flexonenand_get_boundary - Reads the SLC boundary + * @mtd: MTD data structure + */ static int flexonenand_get_boundary(struct mtd_info *mtd) { struct onenand_chip *this = mtd->priv; @@ -3493,9 +3488,9 @@ static void flexonenand_get_size(struct mtd_info *mtd) /** * flexonenand_check_blocks_erased - Check if blocks are erased - * @mtd_info: - mtd info structure - * @start: - first erase block to check - * @end: - last erase block to check + * @mtd: mtd info structure + * @start: first erase block to check + * @end: last erase block to check * * Converting an unerased block from MLC to SLC * causes byte values to change. Since both data and its ECC @@ -3548,9 +3543,8 @@ static int flexonenand_check_blocks_erased(struct mtd_info *mtd, int start, int return 0; } -/** +/* * flexonenand_set_boundary - Writes the SLC boundary - * @mtd: - mtd info structure */ static int flexonenand_set_boundary(struct mtd_info *mtd, int die, int boundary, int lock)