From patchwork Mon Nov 2 11:54:01 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 320287 Delivered-To: patch@linaro.org Received: by 2002:a92:7b12:0:0:0:0:0 with SMTP id w18csp3664971ilc; Mon, 2 Nov 2020 04:00:27 -0800 (PST) X-Google-Smtp-Source: ABdhPJzV6eWMuJmn1WdrRV0mP5iNeJo7TjaHjmGhwP7GoszX6dmiEgvmJUP+eYWJRW6Cy6toHJOc X-Received: by 2002:a05:6000:10e:: with SMTP id o14mr20202348wrx.225.1604318427162; Mon, 02 Nov 2020 04:00:27 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604318427; cv=none; d=google.com; s=arc-20160816; b=IQMz1JWezEyEfsr9zbnkTTzZQePKvBobDBGu8Uz/iUOKl6tAzG7SgYerUtgJEiYpsc c9/CUmZdsIxCEPpfUrEkIZ+fSWhFURhlF6NJb5Db9wUAywStmUEiJ70ZRcW4GENMv1+M RryFQ4Bnqw/PM3JFGK8Vd9ocAkmyaVF8+Tw+bbLsv6jOR0da4HPNxfAMYKb11lmr/MWG ZAyQzu7O4u2NojSzgOncYnQUgIIL8gGvVvz298fT6P2flbUzxSxzUJIqZbFKuhEIvyWo ZHDvl9dXZySzcoFf4Hs+K+H2rTCtPHUQvrgkoOp0sRdJMTzL5sT541AUUOHEasd+MsiO V77Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:sender:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:dkim-signature; bh=/yoUgR3Mj1LU7MFNvezDlP9oaQHyS8yiRUPU5faGu54=; b=cjoY5pSdk2PmKxho8dG0IgoF8yOUQMSEyFXAMm7nsMcXVRjuqpagUD54ZHRReKArPm Dme65ZJnX2P3WRhtKSOjR0Fxss74wgAgw5NNWbqs6S9iRZXKbVYly0tAsvCj+sJ3FJfz 11VsudywkNWT5nUYdzUUGioOOw0YGzTQnUZQrVebeQS2i8u+Xzl8mxuZMiZLIghzKLdl dR9+VvGjncwByOsh+gD7OEfquPjaGQR2P237pQqrXtbFn9+f7Pe9H6teTVHoFtY2lYb5 eEl8P5xAexF6VNK624briBr7RjVn231VEYGKPDLiQ0CwX2qC+VzWlOsQKiVZElzxzYx+ /YeA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.infradead.org header.s=merlin.20170209 header.b=Igba6BUj; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=bxEoYhno; spf=pass (google.com: best guess record for domain of linux-mtd-bounces+patch=linaro.org@lists.infradead.org designates 2001:8b0:10b:1231::1 as permitted sender) smtp.mailfrom="linux-mtd-bounces+patch=linaro.org@lists.infradead.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from merlin.infradead.org (merlin.infradead.org. [2001:8b0:10b:1231::1]) by mx.google.com with ESMTPS id v16si17589992wrc.32.2020.11.02.04.00.27 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Nov 2020 04:00:27 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-mtd-bounces+patch=linaro.org@lists.infradead.org designates 2001:8b0:10b:1231::1 as permitted sender) client-ip=2001:8b0:10b:1231::1; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.infradead.org header.s=merlin.20170209 header.b=Igba6BUj; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=bxEoYhno; spf=pass (google.com: best guess record for domain of linux-mtd-bounces+patch=linaro.org@lists.infradead.org designates 2001:8b0:10b:1231::1 as permitted sender) smtp.mailfrom="linux-mtd-bounces+patch=linaro.org@lists.infradead.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=/yoUgR3Mj1LU7MFNvezDlP9oaQHyS8yiRUPU5faGu54=; b=Igba6BUj8wYOjP7x0RfcVYWRK 1FOe9FQuo1v4zNJykgxOmiZ1n0DKDin2haUBigqmQqmW7w4LirnRufXPtathQsaFOP7I6/rSeiKVc q+d3LRz00+AwYl9Y5Uw25dpXKy8uxBCIqEfAxlAeXqEuvet0Aw8gpHk6XgxxTDxjx6XwzTpFvNX69 iaqmWA+DdarAojV/P7WZfxrxhNeuUh49mPYKh7afqzZooRabsFmuyCxv2ANu+CqYnztMMqoaMVcB2 I4cUIcGWPwa5CBpREyqFsbzHnEKEnGEHvEHFMhKhfqbmdAq8P9qpQnYamU6arJggvLqha4x6ycoZ9 JYryAwSZw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kZYUO-0000JR-Hx; Mon, 02 Nov 2020 11:59:08 +0000 Received: from mail-wm1-x341.google.com ([2a00:1450:4864:20::341]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kZYQ1-000219-3j for linux-mtd@lists.infradead.org; Mon, 02 Nov 2020 11:54:48 +0000 Received: by mail-wm1-x341.google.com with SMTP id p19so1098547wmg.0 for ; Mon, 02 Nov 2020 03:54:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=jc+oP6vugsB/NFox5ee2E+FED0ZhjBIzS6GFVD2ExkM=; b=bxEoYhnoXdbhVx3LfdVJMLEWx3cLOp3NjMInQHLPIjLoF47lqXOvfj+QiE6wvRY5G+ asWwji1UeXYUvhs0Pgir9GeNfo+oV/PsOAjY0NHhgJ7KOIAuMGVBmOtIHLKWpfHXlW8c fNWs054/fbJxwFxwI7hTsMD5m3Rbv4tYbcVk2BFe7iOWJM0GWO4YFteB3SOfPU8yP4jX PKLpMA+hShVRMY6kK2MyKcxOLUp1k0cHvCZzCvY9A0LcH4bgJkXqNmHa8T3lMdhZv1R0 qDrdKumdDE5NsPYxl5OrRj+wuqJCL+lIk9csVfX3TlMnMDh4t5B4qP+Qa4ZSM2Q5qW8W 1W+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=jc+oP6vugsB/NFox5ee2E+FED0ZhjBIzS6GFVD2ExkM=; b=TtrB+sNHo5Xld2zlzMzopXko2pwJARmvOXYzgx1+cEnJKRqSmiBVpOD/Glw6FO5D9I HYEBSNpGzpMD19SuopzK6j31yqZEUv8Xc69erP4ZTMDIIsTMt3nOeV7nJURfH23enCnd bDu9fCahiCF0MiZdoQa7RmK/MndyrsW0MJbwOey9iiMMydK1ASFAXqqCkXsqj7ELzzzn 9n8ntk1Ktv1KtD/TT5VIukBq1kK2IdWBGYgJfqkONnMOIO5n+iXa6rS5cqqfw1Lfo1hn 54jmaBjsADFm+AcjaLLWCV/KP1+4JsumE2jvTnoXTO1NpSHvCtDSo3NWYNF/7SizSnU2 Z8GA== X-Gm-Message-State: AOAM530SWLIu2cOLnE7y/1IjfXGivXwPuusnPBfRSNy2vj6FgGnzyzPc ojImt6Zp+CqsA/oniPyV50t8OA== X-Received: by 2002:a1c:205:: with SMTP id 5mr11364455wmc.7.1604318076024; Mon, 02 Nov 2020 03:54:36 -0800 (PST) Received: from dell.default ([91.110.221.242]) by smtp.gmail.com with ESMTPSA id t23sm14284010wmn.13.2020.11.02.03.54.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Nov 2020 03:54:35 -0800 (PST) From: Lee Jones To: vigneshr@ti.com Subject: [PATCH 18/23] mtd: nand: raw: omap_elm: Finish half populated function header, demote empty ones Date: Mon, 2 Nov 2020 11:54:01 +0000 Message-Id: <20201102115406.1074327-19-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201102115406.1074327-1-lee.jones@linaro.org> References: <20201102115406.1074327-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201102_065437_979427_D18BC5F7 X-CRM114-Status: GOOD ( 15.06 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:341 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Richard Weinberger , Lee Jones , linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org, Miquel Raynal Sender: "linux-mtd" Errors-To: linux-mtd-bounces+patch=linaro.org@lists.infradead.org Fixes the following W=1 kernel build warning(s): drivers/mtd/nand/raw/omap_elm.c:102: warning: Function parameter or member 'ecc_steps' not described in 'elm_config' drivers/mtd/nand/raw/omap_elm.c:102: warning: Function parameter or member 'ecc_step_size' not described in 'elm_config' drivers/mtd/nand/raw/omap_elm.c:102: warning: Function parameter or member 'ecc_syndrome_size' not described in 'elm_config' drivers/mtd/nand/raw/omap_elm.c:440: warning: Function parameter or member 'info' not described in 'elm_context_save' drivers/mtd/nand/raw/omap_elm.c:488: warning: Function parameter or member 'info' not described in 'elm_context_restore' Cc: Miquel Raynal Cc: Richard Weinberger Cc: Vignesh Raghavendra Cc: linux-mtd@lists.infradead.org Signed-off-by: Lee Jones --- drivers/mtd/nand/raw/omap_elm.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) -- 2.25.1 ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/ diff --git a/drivers/mtd/nand/raw/omap_elm.c b/drivers/mtd/nand/raw/omap_elm.c index 4b799521a427a..550695a4c1ab0 100644 --- a/drivers/mtd/nand/raw/omap_elm.c +++ b/drivers/mtd/nand/raw/omap_elm.c @@ -96,6 +96,9 @@ static u32 elm_read_reg(struct elm_info *info, int offset) * elm_config - Configure ELM module * @dev: ELM device * @bch_type: Type of BCH ecc + * @ecc_steps: ECC steps to assign to config + * @ecc_step_size: ECC step size to assign to config + * @ecc_syndrome_size: ECC syndrome size to assign to config */ int elm_config(struct device *dev, enum bch_ecc bch_type, int ecc_steps, int ecc_step_size, int ecc_syndrome_size) @@ -432,7 +435,7 @@ static int elm_remove(struct platform_device *pdev) } #ifdef CONFIG_PM_SLEEP -/** +/* * elm_context_save * saves ELM configurations to preserve them across Hardware powered-down */ @@ -480,7 +483,7 @@ static int elm_context_save(struct elm_info *info) return 0; } -/** +/* * elm_context_restore * writes configurations saved duing power-down back into ELM registers */