From patchwork Wed Nov 2 17:21:04 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 80519 Delivered-To: patch@linaro.org Received: by 10.80.170.210 with SMTP id r18csp222669edc; Wed, 2 Nov 2016 10:22:49 -0700 (PDT) X-Received: by 10.98.166.70 with SMTP id t67mr8807054pfe.132.1478107369592; Wed, 02 Nov 2016 10:22:49 -0700 (PDT) Return-Path: Received: from bombadil.infradead.org (bombadil.infradead.org. [2001:1868:205::9]) by mx.google.com with ESMTPS id w13si3502110pag.24.2016.11.02.10.22.49 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 02 Nov 2016 10:22:49 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-mtd-bounces+patch=linaro.org@lists.infradead.org designates 2001:1868:205::9 as permitted sender) client-ip=2001:1868:205::9; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@nifty.com; spf=pass (google.com: best guess record for domain of linux-mtd-bounces+patch=linaro.org@lists.infradead.org designates 2001:1868:205::9 as permitted sender) smtp.mailfrom=linux-mtd-bounces+patch=linaro.org@lists.infradead.org Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.85_2 #1 (Red Hat Linux)) id 1c1zFF-0004PN-2H; Wed, 02 Nov 2016 17:22:37 +0000 Received: from conuserg-10.nifty.com ([210.131.2.77]) by bombadil.infradead.org with esmtps (Exim 4.85_2 #1 (Red Hat Linux)) id 1c1zFC-0004K7-6G for linux-mtd@lists.infradead.org; Wed, 02 Nov 2016 17:22:35 +0000 Received: from grover.sesame (FL1-111-169-71-157.osk.mesh.ad.jp [111.169.71.157]) (authenticated) by conuserg-10.nifty.com with ESMTP id uA2HLFuq012320; Thu, 3 Nov 2016 02:21:20 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conuserg-10.nifty.com uA2HLFuq012320 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1478107281; bh=TPEslDoRA4zFwuko+13j2DcqMYClgfj5aSwsy0qMqZU=; h=From:To:Cc:Subject:Date:From; b=GwjtvmbYGakNrYnwmR5Tt87Wz/vH9nbFPp7xWL9xgOM45umOqX4mIojJJzcNR5cUQ +2mqzp8b1cVISq56+5orhJ9bbNpqWQLhZW140WsDoUPX38hW/9YOyIaO1+Rl2qAsHq zPin4PnVAFTfbvG7GIamrf89h4YIE5Az6d5Yv++pJqD4HD/dLKavNIQgZGeo92RyEy ghJPVeMwDml2TcUwlHR0fF+N8l5wQaIHeMm7xs4xHx58ucjSKmmYTyu14o3iB2NINd NwFh3bErOPxvWXzNP2uDrZ4TsLK4hJaodXmQsyZDgJOgyLrS+Iq5YJf1mCodQdP4Uq Zza+Ds3M0OzOw== X-Nifty-SrcIP: [111.169.71.157] From: Masahiro Yamada To: linux-mtd@lists.infradead.org Subject: [PATCH] mtd: nand: denali_dt: replace clk_disable() with clk_disable_unprepare() Date: Thu, 3 Nov 2016 02:21:04 +0900 Message-Id: <1478107264-21139-1-git-send-email-yamada.masahiro@socionext.com> X-Mailer: git-send-email 1.9.1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20161102_102234_463485_B6679A16 X-CRM114-Status: UNSURE ( 7.90 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -1.2 (-) X-Spam-Report: SpamAssassin version 3.4.0 on bombadil.infradead.org summary: Content analysis details: (-1.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- 0.7 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Boris Brezillon , Stephen Boyd , Brian Norris , Sachin Kamat , Richard Weinberger , Jingoo Han , linux-kernel@vger.kernel.org, Masahiro Yamada , Andy Shevchenko , Enrico Jorns , David Woodhouse , Dinh Nguyen , Graham Moore MIME-Version: 1.0 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+patch=linaro.org@lists.infradead.org The denali_dt_probe() calls clk_disable_unprepare() in the bailout path, whereas denali_dt_remove calls clk_disable(), inconsistently. Replace the latter with clk_disable_unprepare() to make sure to unprepare the clock. Signed-off-by: Masahiro Yamada --- drivers/mtd/nand/denali_dt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 1.9.1 ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/ Reviewed-by: Marek Vasut diff --git a/drivers/mtd/nand/denali_dt.c b/drivers/mtd/nand/denali_dt.c index 0cb1e8d..f821dc1 100644 --- a/drivers/mtd/nand/denali_dt.c +++ b/drivers/mtd/nand/denali_dt.c @@ -110,7 +110,7 @@ static int denali_dt_remove(struct platform_device *ofdev) struct denali_dt *dt = platform_get_drvdata(ofdev); denali_remove(&dt->denali); - clk_disable(dt->clk); + clk_disable_unprepare(dt->clk); return 0; }