From patchwork Wed Sep 2 13:07:35 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vaibhav Hiremath X-Patchwork-Id: 52969 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-wi0-f199.google.com (mail-wi0-f199.google.com [209.85.212.199]) by patches.linaro.org (Postfix) with ESMTPS id 25F0F22E23 for ; Wed, 2 Sep 2015 13:07:50 +0000 (UTC) Received: by wicmn1 with SMTP id mn1sf6187310wic.1 for ; Wed, 02 Sep 2015 06:07:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:subject:to:references:cc:from :message-id:date:user-agent:mime-version:in-reply-to:content-type :content-transfer-encoding:sender:precedence:list-id :x-original-sender:x-original-authentication-results:mailing-list :list-post:list-help:list-archive:list-unsubscribe; bh=z+cmbD9gpAMJT2RnpxJ7tOV3Pbcvk0UjeCYWoRsm96w=; b=JUNkFOq9tTv4zVP6fH8jgiouHnpVR7lppDIJ9nQbJ6rD2WxgK/370XpLoA7usfF8Xq WnCvAUP/1qyKj29k1ZLuuPptjX1ItjpAq1RdQRjbm5v9702D9ss5CivRuJTydrXvXUtU k6DexXvMUFuSKGGAZPGLmWJkooNTR26NENSdtLuKX4QOHjIBxJZ+ta3JDcrbTOwqjCGw Looc6e8XdEfvFfdqC8A2XzLUPMP6dpSHy0035iZRbYYcJU02dMpOjP4pwqypSCip1z0l kzn+wvNs8j4TDgaUcH+sriaf+K3T28q80cBclf4l40Q06LFbBh1ChCnj+3Pd/6LfcmK1 VpLQ== X-Gm-Message-State: ALoCoQmMVpbLZ/FFvKjZ9RLVv8q3idcFw77U3y3iG485p8JIEjIDFyQFtVRI2l2R8OeYq4aW6sH9 X-Received: by 10.180.100.71 with SMTP id ew7mr1019079wib.0.1441199269490; Wed, 02 Sep 2015 06:07:49 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.153.4.163 with SMTP id cf3ls281lad.89.gmail; Wed, 02 Sep 2015 06:07:49 -0700 (PDT) X-Received: by 10.152.44.196 with SMTP id g4mr15879255lam.56.1441199269033; Wed, 02 Sep 2015 06:07:49 -0700 (PDT) Received: from mail-lb0-f177.google.com (mail-lb0-f177.google.com. [209.85.217.177]) by mx.google.com with ESMTPS id p4si12957338laf.80.2015.09.02.06.07.49 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 02 Sep 2015 06:07:49 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.217.177 as permitted sender) client-ip=209.85.217.177; Received: by lbbmp1 with SMTP id mp1so5671264lbb.1 for ; Wed, 02 Sep 2015 06:07:48 -0700 (PDT) X-Received: by 10.152.5.228 with SMTP id v4mr16028269lav.36.1441199268893; Wed, 02 Sep 2015 06:07:48 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.164.42 with SMTP id yn10csp561995lbb; Wed, 2 Sep 2015 06:07:47 -0700 (PDT) X-Received: by 10.68.68.240 with SMTP id z16mr19648283pbt.143.1441199267556; Wed, 02 Sep 2015 06:07:47 -0700 (PDT) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id ra6si35342091pab.209.2015.09.02.06.07.46; Wed, 02 Sep 2015 06:07:47 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754749AbbIBNHn (ORCPT + 28 others); Wed, 2 Sep 2015 09:07:43 -0400 Received: from mail-pa0-f48.google.com ([209.85.220.48]:34147 "EHLO mail-pa0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754717AbbIBNHm (ORCPT ); Wed, 2 Sep 2015 09:07:42 -0400 Received: by padhy1 with SMTP id hy1so11447936pad.1 for ; Wed, 02 Sep 2015 06:07:41 -0700 (PDT) X-Received: by 10.69.2.227 with SMTP id br3mr55903578pbd.9.1441199260964; Wed, 02 Sep 2015 06:07:40 -0700 (PDT) Received: from [192.168.0.101] ([202.62.93.138]) by smtp.googlemail.com with ESMTPSA id vv2sm21797927pab.21.2015.09.02.06.07.38 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 02 Sep 2015 06:07:40 -0700 (PDT) Subject: Re: [PATCH 2/2] mmc: sdhci-pxav3: Print ret value on error from sdhci_add_host() fn To: Joe Perches References: <1441135454-6902-1-git-send-email-vaibhav.hiremath@linaro.org> <1441135454-6902-3-git-send-email-vaibhav.hiremath@linaro.org> <1441139838.12163.5.camel@perches.com> Cc: linux-mmc@vger.kernel.org, ulf.hansson@linaro.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org From: Vaibhav Hiremath Message-ID: <55E6F497.8080300@linaro.org> Date: Wed, 2 Sep 2015 18:37:35 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <1441139838.12163.5.camel@perches.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: vaibhav.hiremath@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.217.177 as permitted sender) smtp.mailfrom=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , On Wednesday 02 September 2015 02:07 AM, Joe Perches wrote: > On Wed, 2015-09-02 at 00:54 +0530, Vaibhav Hiremath wrote: >> Return value would give clear information about the actual root-cause >> of the failure. >> diff --git a/drivers/mmc/host/sdhci-pxav3.c b/drivers/mmc/host/sdhci-pxav3.c >> @@ -455,7 +455,7 @@ static int sdhci_pxav3_probe(struct platform_device *pdev) >> >> ret = sdhci_add_host(host); >> if (ret) { >> - dev_err(&pdev->dev, "failed to add host\n"); >> + dev_err(&pdev->dev, "failed to add host ret - %d\n", ret); >> goto err_add_host; >> } >> > > If this is really desirable, there are many other callers of > sdhci_add_host with error messages just like this one. > How about this? If you are ok, I can change it and submit the patch again. UHS */ if (!IS_ERR(mmc->supply.vqmmc)) { Thanks, Vaibhav --- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c index d2caa60..3a4902c 100644 --- a/drivers/mmc/host/sdhci.c +++ b/drivers/mmc/host/sdhci.c @@ -3176,8 +3176,11 @@ int sdhci_add_host(struct sdhci_host *host) mmc->caps |= MMC_CAP_NEEDS_POLL; /* If there are external regulators, get them */ - if (mmc_regulator_get_supply(mmc) == -EPROBE_DEFER) + if (mmc_regulator_get_supply(mmc) == -EPROBE_DEFER) { + pr_err("%s: regulator supply unavailable, deferring probe. \n", + mmc_hostname(mmc)); return -EPROBE_DEFER; + } /* If vqmmc regulator and no 1.8V signalling, then there's no