From patchwork Fri May 16 07:46:23 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Haibo Chen X-Patchwork-Id: 890788 Received: from AS8PR04CU009.outbound.protection.outlook.com (mail-westeuropeazon11011062.outbound.protection.outlook.com [52.101.70.62]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AB98019CC3D; Fri, 16 May 2025 07:44:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.70.62 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747381494; cv=fail; b=mlo55h4J832fVcXIP1XmLGgKKAkp7Rr86GYtMTT3pnqj12iwCv3MeEHUgmjuDFdTwBKL2+ZZd0d+KPwWgTadMXLrB0jh5MTsF7W/Rr/e0fEtrs2/p1XPp0PS1RlHGdrACmFZXlqkS7io8ggdtRSg5N3Vh82Qo3Bow+MVIOj8rKo= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747381494; c=relaxed/simple; bh=v27mu0U1KAtRdeAvDpk19coqbixHNPe4PnwdHmBV4OA=; h=From:Date:Subject:Content-Type:Message-Id:To:Cc:MIME-Version; b=n+a1MWmpkmGsF8tmFR74Nl8/FAPdt+M2d7uGnAcx9hItdruxajhCpyvl+fhlWJiEAn65udaxCSJyC47UkIZcr8XeVNvkcc1WtcBK2SpXqVyz0YWS034hiybs45FgTcUME9MF1iPA3qjf3+jWc6xXAbPFoeHL6CYzt8mNvt84dO8= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=eHtLhpK6; arc=fail smtp.client-ip=52.101.70.62 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="eHtLhpK6" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=qGNguVgNJhTgTHT64H6UwZlcjcgnEWAyT3BJnXTm6omdY9vfLahd8G9WDmSwxxqQMYA3daINN8A0oMzXzj0W+nMSB9i9Ml5XOpSnYAj8QJirDH3wMCIkaYcrPv6cvs37TATNOfbXyKrzHDFTjx80bXdLhPBL6IeRmf5L9eNeyYaLzrXnDrF+mC8c2BOJ6SJECnKviOIEWusEgw50A6yM/b+imdr16kSAriCYBbtUnk0G3eQfEV+Gjfm0HFf/0zzX4acnhF33CF5TZhgTHODGNO0umF0tFsB7EcqAmIxf6bBv3WbHvfSHa0gzpmw7r8qBfUGZeIVyFA25x8lu/GHOvA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4EaNJWrw3YGrDjds+qg2Zx7IO8Mj3V66Yzc6hRnUgDM=; b=cUqfhsA9879S4YuCyyA3I7ChezBNmVnf5q81cTHhmCQCqTRYwZx3x2t/bEbwk6brE21bNGelNpMQGVvCty/KRxDIXd2ZafoJ6MosoBW0X28vg2/vNBD3rISUOK/9Ufv0tBePW81SvlD1sLugU2ne0v9nNCsC63R/B+rbCYGDQnUv/IZfcalz8obNovse6GJWLNLfeK0QpiM0Msz56/RdbEZpxLWxwg/xEKj8VePpQSalPnYjliTs2ca6XARXG+xtQz5yhd11gN29WblAl90AbVTILTFTbew4X/2GUhFWCS2JpYIXdzdC/i1im6EFjczirz9goLnM+CdecpLV/76s/g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4EaNJWrw3YGrDjds+qg2Zx7IO8Mj3V66Yzc6hRnUgDM=; b=eHtLhpK6Bk2eDYDO1PR/8Lmcq5PgCi7ivLVVfORJWJcvCmJb2yyqdFflEXQDJezNuQ/PS7DNceW7aaPPFCAZkYnwl2QwobRgzRGBnj+yh6KWw/+qwglqemoi7mVRv6eZqM3OxD/ni+EKaUMm40e4WnD5VHMJkLWKRCGGJ3HJkCYX/YkuKhqlOYrffgFoIa4hyW/VCaS6FOaAwKJXRRj72lhW4yf2uHOAFpwRzGCoCYUiiXKiwkeIIfaB2S3HdCkU8qGU9jX5aawBn2KToSO3ZDiPJ9+aI0B/TWsjbxhAcDoueqecjNpl3eRD7GVnB818YhU3srUEgQED3YL1Fv9YFQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from DU0PR04MB9496.eurprd04.prod.outlook.com (2603:10a6:10:32d::19) by PR3PR04MB7401.eurprd04.prod.outlook.com (2603:10a6:102:8d::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8722.33; Fri, 16 May 2025 07:44:49 +0000 Received: from DU0PR04MB9496.eurprd04.prod.outlook.com ([fe80::4fa3:7420:14ed:5334]) by DU0PR04MB9496.eurprd04.prod.outlook.com ([fe80::4fa3:7420:14ed:5334%4]) with mapi id 15.20.8722.031; Fri, 16 May 2025 07:44:49 +0000 From: Haibo Chen Date: Fri, 16 May 2025 15:46:23 +0800 Subject: [PATCH v2] mmc: sdhci-esdhc-imx: fix few build warnings Message-Id: <20250516-b4-usdhc-v2-1-3fccd02f5602@nxp.com> X-B4-Tracking: v=1; b=H4sIAE7tJmgC/6tWKk4tykwtVrJSqFYqSi3LLM7MzwNyjHQUlJIzE vPSU3UzU4B8JSMDI1MDU0Mz3SQT3dLilIxk3aTkFIvk1EQDi9QUMyWg8oKi1LTMCrBR0bG1tQD 0fbqTWgAAAA== X-Change-ID: 20250516-b4-usdhc-bcd8cea08ed6 To: Adrian Hunter , Ulf Hansson , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Luke Wang Cc: imx@lists.linux.dev, linux-mmc@vger.kernel.org, s32@nxp.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel test robot , Haibo Chen X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1747381625; l=2291; i=haibo.chen@nxp.com; s=20250421; h=from:subject:message-id; bh=v27mu0U1KAtRdeAvDpk19coqbixHNPe4PnwdHmBV4OA=; b=k/14jaSRFOGA+TSAY9ynl+acSFTkJeXCliQidM9mCR0D9COqMfFzCb5wtaHE9kiB1jj3nyRe5 CF90YI6p35pClJsPavv0+ziIU+oXwZBf5UAU3TdDa6596Vu/6ftylX5 X-Developer-Key: i=haibo.chen@nxp.com; a=ed25519; pk=HR9LLTuVOg3BUNeAf4/FNOIkMaZvuwVJdNrGpvKDKaI= X-ClientProxiedBy: SI2PR02CA0036.apcprd02.prod.outlook.com (2603:1096:4:195::15) To DU0PR04MB9496.eurprd04.prod.outlook.com (2603:10a6:10:32d::19) Precedence: bulk X-Mailing-List: linux-mmc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU0PR04MB9496:EE_|PR3PR04MB7401:EE_ X-MS-Office365-Filtering-Correlation-Id: 4631c8a8-3fca-4788-4472-08dd944d8900 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|376014|52116014|7416014|1800799024|366016|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?q?6S/XKwNMX+hX75k4rQCG3fJaDp9CMZC?= =?utf-8?q?VHTIH0HERnRPmtydxkjnQDjKMV9Wb8UvGBBmAoB5XyrQVFMQ/fogQJbe6qG4jPEAG?= =?utf-8?q?DJ6rv/lpFQgbYUoSmCZHnMTdONrEM7jbnUfaIEWrg+9M0MCStoNfvx6ytVwAXu1mX?= =?utf-8?q?rLcSzme78I3sRHN6M5c1bdkUkhTXc6zJaG5W03Wj1CqR4VaxV2TE0FE17zncofu/w?= =?utf-8?q?rVDoIDDPLQ3ANBeYais2QdFpvKulxzWfpDzluwK0IzGQDxlaaalwvS4I2VuYnaLsi?= =?utf-8?q?Y6AOlI8S4TOYTvnJYyb1VlleLGduYR525CmPqb5XVtE8DMmFqFyFZLtZJ0WZEJKLW?= =?utf-8?q?2SHd09tPJoaTTN/sJMCXLhZrz7X0WwElOhYY7aDicFGyB+fK5236yqd8PpEc77k94?= =?utf-8?q?7dGOS+VYNhA5YdTGF7GY17yA98Gpj+wc5fCYb529rp8PUza0w9Ki6LG5rRd2Kx8d3?= =?utf-8?q?KMdnG3E8EPbm9iP7G+S/b9rSWIdumsNcUS4/zm7L7Ius0TGklBDGXzJmZeB+BD/Xq?= =?utf-8?q?p/bYe2MMvyWhUcEX47NiHoPKQdSYO9eSQtYPw4mXV0LIZqmrjY94JF52bwIv/LjZZ?= =?utf-8?q?0KNUJewbHAKX8Qoom7VMhEkyhQ9lGGqo6YBRi6UuNUTGxbR0W/QJjoz10xL6IyofF?= =?utf-8?q?iwpKPpNbOobOB3yyx0c+pN34dI7fnqWG060KwkERv9I4Hn1r0lsWqcIeD1ex6B8im?= =?utf-8?q?BeR26JqICcN8eGIuZUMPCrLpU+g8WOUwTSdZCQOlBq+xKz+cUqUgzs7Hw1Z2frQu1?= =?utf-8?q?tz02YSiOIIE0yxjLiipp1/MQDv5JrAIsert73pnihDtXxeNLycPhPxaRCYJ3w/SxM?= =?utf-8?q?Fe7cL853874m03rzLpFnwpK5eplMySMpLlluuhN3DuNVQvPYr/Agvdd3HzGxx78M1?= =?utf-8?q?Vfd3DYiW0fmt3gbqyGQNP3U5olucTsVSChKQekzxDtn3tJBXlK9KBt8NGwh2X/UIW?= =?utf-8?q?8gFgfsF5jyT9IYWLflrl8VVwLa5HmqEsPh7ukC/wX4pcZFx6FyD0QnUwZ26unuA5h?= =?utf-8?q?wLTA33F3yldyn7YxxWqV2Q0ktpf75ZBfRDHYfiVrGWrV/QwcSWzenMUFzwUDU56H2?= =?utf-8?q?4fmDU0mhey90qi8rklRvW4QvVv9TySYkcopbj6SChpNExeIjWcweXVbE98r00XhSB?= =?utf-8?q?7gswBmzwZvM07uJVT83c1wgqgLa+vOEmPTdOp5cdSgeNuVJ1W/Ou1nQ5VJ3H/nSBG?= =?utf-8?q?xNvVI5U7r9sKV0Vt2p7tnlO8PkoyTPAJjNZpc2/gcWk87rrS1cq+K8BANkUZ8Rz29?= =?utf-8?q?LffRWKdIeigazJi25oZEwzzZdPAnNOG2TvPcehtmPmSggnF75ucky9uWubWjwW3bw?= =?utf-8?q?RmasakH+exC5GLFK9IUG3j5tpQoPrRbQl6QFg+VeQp/vZq8NmGx4iezo/khgc5klF?= =?utf-8?q?Y/ewD/yMg0e7ho0dF35K76w3KN2Du3iXNyDW2hKH4ufhfHyJsHQnBc=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DU0PR04MB9496.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(52116014)(7416014)(1800799024)(366016)(38350700014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?jE+PzsAWUhOLzdsg3tly8A8Nnqiq?= =?utf-8?q?Uap4HBK8weFCES4nhbPd/SqT80d1CKr9F/d0Um4kaBDH6jXeez36vvmJpyhIk/s3f?= =?utf-8?q?eKjvRjiOx3oC4Zc2PlxxqFkhofTgXHXZIkI63uWAiGvuHtttVphKB1XFRmewpG1g1?= =?utf-8?q?1OJ8i1hXCQaKIfPROSh5m0esajkAjocmmADQdJitxKWG3dscyHl29guplEZWg+0be?= =?utf-8?q?C5XkCBh7dFt2ubjQ4JLMsvJ7z6KsvOnZq9uj+Bk0D45tNvFwQZKkuyA3dGy2B5aRG?= =?utf-8?q?vfXClTwFq9SLmq7ZadtDycr0pb5EvNDxsOzybXOI4qODlyqnwAXaowm4U+56ARs/p?= =?utf-8?q?vKu6Swpsfqo3WJrYLnPdzqttZXSSu6OlrTS6iq8NP2fJ2eXVFBkm5vlSZ041+gw0q?= =?utf-8?q?OhOeodMoeJO2uX5OCjshO8vbDNjEW1nKfnaSnogyExaLFwyvx0ZR9IOFNgeDOeX1q?= =?utf-8?q?N/i5pU7fDkD1DOewrWqeC0qO9O0ZN0l0nc8v2aGZvibDhMV93pK4hlhjxlD8r6DMQ?= =?utf-8?q?DGpizotDsmyZvGudr+whe89guEzTTzb65U5Kn9R5zpTnVi2GVr87zpQYLmCWZzKii?= =?utf-8?q?w6+jwKlIHELE+FUgStvTZqyir6gDTj89NDe0qHV/qqjrogCi+SycvtAZtUajcEw5K?= =?utf-8?q?QoA9A/UclCu7B9hLb0WGbLO4tpPrpdRjL6Tltwp69VY2KQSmlVH86n5hDoTh2JPqL?= =?utf-8?q?cFVH/hY+VVhshtmcxT9xRq5heLfidlfWyJSSCQl4TuV7IYL9hWonNvCM73PKAca1k?= =?utf-8?q?QDHunlqtT0hM2za+ER+2nkYCUVr0YiCuetml9xBLLy6JNy4sWLfrvlilWtIFAZgcM?= =?utf-8?q?lMGxdtUDXA99IWk/Q0G3QLR2hE7Unxp0KSK34pKnHXxUnfnO0ay6Rt3SUilB1JQ1h?= =?utf-8?q?MSHliTNuD+csOPr8v/ozizg9spJLBGS9p0JqhyGQ0il4g+Qn5MhLZxa5vNHiXsU/j?= =?utf-8?q?HjjyXuLmZ+VGgtTF1/SlL3X51eaYV37JooyyBOEIZ/DFu3XYDXbE/3q2Psu6ICTyt?= =?utf-8?q?F+XCIf6TdMEvLcWaLQF4Av9Moneizsw4/VSstUkoZ4nUn0qJlThJxmGUUWTVs6vJM?= =?utf-8?q?FQgunbvfx3nSO8Qn5XCJkAGH1F52wFbHHBvnlRxkXhmyH4GlcL69OhmFfGUM2ylkr?= =?utf-8?q?3OtkVH1MDcJbWS9uYdPlqUF2aTlkgnWrStw6cfv7kbLDA5szw7hLHewDlK0Qpxc2x?= =?utf-8?q?d45ZOtwESWSmwU06Jzhvo6yxRNXS/CHvVysM8wcqPxxPzx0yZeBHGbZq03YPP/LuG?= =?utf-8?q?QDxkKh7gfqae79wmPgVXgMviSKGx8a3aIRO4rEeXafV1ma+TcXm7q6TlaCznLKYcF?= =?utf-8?q?20TjerXhqE+XxHx+eEgsHbA6aC1WK+Xe23D+IBa3EduYgNGRiPeXkn6HsE4yw4vYE?= =?utf-8?q?kWJK6JHgJmQamP4Hp+2yOaDjqKlkF63GOkRQF4dc0PBWlzc5D5UXnMkik1o4Hm0PE?= =?utf-8?q?WbR7WPCxuCeIebw7HlSdGb667iQFkn42gbZ2Jn6YaCWl+zhoyvkyQZTaO71cxuIFL?= =?utf-8?q?0+2hXUonRJ/t?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4631c8a8-3fca-4788-4472-08dd944d8900 X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9496.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 May 2025 07:44:49.0753 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: DuE4+o7QDUG2COMjlcbPFlt+Z2iYIFULB6XxGL8JkOe7SC5JCzuQdQX5wrWFoZpLIlcvgX221PnWyHnUioQvxg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR04MB7401 drivers/mmc/host/sdhci-esdhc-imx.c:1566 sdhci_esdhc_imx_hwinit() warn: inconsistent indenting drivers/mmc/host/sdhci-esdhc-imx.c:1251 esdhc_executing_tuning() error: uninitialized symbol 'target_min'. drivers/mmc/host/sdhci-esdhc-imx.c:1251 esdhc_executing_tuning() error: uninitialized symbol 'target_max'. Fixes: be953af79cc6 ("mmc: sdhci-esdhc-imx: widen auto-tuning window for standard tuning") Fixes: 541a95e64d76 ("mmc: sdhci-esdhc-imx: optimize the manual tuing logic to get the best timing") Reported-by: kernel test robot Closes: https://lore.kernel.org/all/202505160225.Csr5USfq-lkp@intel.com/ Acked-by: Adrian Hunter Signed-off-by: Haibo Chen --- drivers/mmc/host/sdhci-esdhc-imx.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) --- base-commit: 484803582c77061b470ac64a634f25f89715be3f change-id: 20250516-b4-usdhc-bcd8cea08ed6 Best regards, diff --git a/drivers/mmc/host/sdhci-esdhc-imx.c b/drivers/mmc/host/sdhci-esdhc-imx.c index c0160c69a027826c4099c9bcf82cd4d83f1113fd..741db169f44d9c9c1e5e1dee591b72221fa1e2b9 100644 --- a/drivers/mmc/host/sdhci-esdhc-imx.c +++ b/drivers/mmc/host/sdhci-esdhc-imx.c @@ -1216,8 +1216,8 @@ static int esdhc_executing_tuning(struct sdhci_host *host, u32 opcode) int win_length, target_min, target_max, target_win_length; u32 clk_tune_ctrl_status, temp; - min = ESDHC_TUNE_CTRL_MIN; - max = ESDHC_TUNE_CTRL_MIN; + min = target_min = ESDHC_TUNE_CTRL_MIN; + max = target_max = ESDHC_TUNE_CTRL_MIN; target_win_length = 0; while (max < ESDHC_TUNE_CTRL_MAX) { /* find the mininum delay first which can pass tuning */ @@ -1591,8 +1591,8 @@ static void sdhci_esdhc_imx_hwinit(struct sdhci_host *host) * wider, give auto tuning enough space to handle the sample * point shift cause by temperature change. */ - tmp &= ~ESDHC_TUNING_WINDOW_MASK; - tmp |= FIELD_PREP(ESDHC_TUNING_WINDOW_MASK, ESDHC_AUTO_TUNING_WINDOW); + tmp &= ~ESDHC_TUNING_WINDOW_MASK; + tmp |= FIELD_PREP(ESDHC_TUNING_WINDOW_MASK, ESDHC_AUTO_TUNING_WINDOW); /* Disable the CMD CRC check for tuning, if not, need to * add some delay after every tuning command, because