From patchwork Thu Feb 29 14:20:07 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Xiongwei Song X-Patchwork-Id: 777305 Received: from mx0a-0064b401.pphosted.com (mx0a-0064b401.pphosted.com [205.220.166.238]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9892112F58D; Thu, 29 Feb 2024 14:22:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.166.238 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709216541; cv=none; b=mUUhIYDS/PVx84a9RgnAyK/x2opbsegOGXlztTH0vnCOscqmIUCFdyYzBQfOniSPWjWqYluZFhr9Reouk8clUVijYZmV7+XKwWWqTq05fVSe9SzK+aQbyuPhVASRYddH5q6Zv6zQSbZ/wvb5nK1R6ffpCeZMSAUM7WD560F9LF8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709216541; c=relaxed/simple; bh=5tRPmXL2TVv6kom3cQU7ugeRZCPtoU7puLCKLDcp4wA=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=uGkA6jUQrrtKsSUeNodr89HYcp+chViBfQBubXzwAht359ASlpEckVahejKdiV3dW0lAdYlifQNbU9tm++OLM2ppJwOLvKSXYzbICoKqRzvXw55lsMCEqYM/qIxO549W/xsuKDkGDN2O0LjdPc4xA/hjLj7jQnWEiTY4eNB9hZg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=windriver.com; spf=pass smtp.mailfrom=windriver.com; dkim=pass (2048-bit key) header.d=windriver.com header.i=@windriver.com header.b=sOntqjeT; arc=none smtp.client-ip=205.220.166.238 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=windriver.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=windriver.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=windriver.com header.i=@windriver.com header.b="sOntqjeT" Received: from pps.filterd (m0250810.ppops.net [127.0.0.1]) by mx0a-0064b401.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id 41T6NeDS014776; Thu, 29 Feb 2024 06:20:28 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=windriver.com; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s= PPS06212021; bh=2udlK6bNAriNhByS7Iy3jsJU3amaElXU/XABWbmgNfc=; b= sOntqjeT7qgWOl9nx/HSpKtXrTSVs1EJI3ufWOw1CsVk8mB6xKui6wxfg9wYbjli 8QO4hPPhakPUCLI529zzChGKDjrZnssWhlNpNjGYaRHU+2uN7z2RUCqOgfuNPUqm VATA0egIg/XYgZS10aqNOGPozpJVzZaWKpuTlEE/8CcjdcFbj2GovC0HO6/cnSc4 4jJ3qGaPSrKkhJ5N17X94zP76nGvKOgyOaTJ6lCS/NLPIMlKL8bwNbnqBHjKQvl1 HklMgL21HUGymNsts+M0SOrx8bc8a2b1N2QA8SuFR6ILCg2md9ziV7qpxvg8/vi+ Kh9zS7HEedVepqPDbYR8AQ== Received: from ala-exchng01.corp.ad.wrs.com (ala-exchng01.wrs.com [147.11.82.252]) by mx0a-0064b401.pphosted.com (PPS) with ESMTPS id 3wfcm45aaf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT); Thu, 29 Feb 2024 06:20:27 -0800 (PST) Received: from ala-exchng01.corp.ad.wrs.com (147.11.82.252) by ala-exchng01.corp.ad.wrs.com (147.11.82.252) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 29 Feb 2024 06:20:27 -0800 Received: from pek-lpd-ccm6.wrs.com (147.11.1.11) by ala-exchng01.corp.ad.wrs.com (147.11.82.252) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Thu, 29 Feb 2024 06:20:23 -0800 From: Xiongwei Song To: , , , , CC: , , , , , , , , , Subject: [PATCH 2/2] cgroup/cpuset: Mark memory_spread_slab as obsolete Date: Thu, 29 Feb 2024 22:20:07 +0800 Message-ID: <20240229142007.1278610-2-xiongwei.song@windriver.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240229142007.1278610-1-xiongwei.song@windriver.com> References: <20240229142007.1278610-1-xiongwei.song@windriver.com> Precedence: bulk X-Mailing-List: linux-mmc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Proofpoint-ORIG-GUID: qSydO_QdNgcpzUfXcE3ufBZrizF9vWxf X-Proofpoint-GUID: qSydO_QdNgcpzUfXcE3ufBZrizF9vWxf X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-02-29_02,2024-02-29_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 impostorscore=0 spamscore=0 bulkscore=0 mlxlogscore=934 mlxscore=0 lowpriorityscore=0 clxscore=1015 adultscore=0 suspectscore=0 phishscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2402120000 definitions=main-2402290110 We've removed the SLAG allocator, cpuset_do_slab_mem_spread() and SLAB_MEM_SPREAD, memory_spread_slab is a no-op now. We can mark memory_spread_slab as obsolete in case someone still wants to use it after cpuset_do_slab_mem_spread() removed. For more details, please check [1]. [1] https://lore.kernel.org/lkml/32bc1403-49da-445a-8c00-9686a3b0d6a3@redhat.com/T/#m8e292e21b00f95a4bb8086371fa7387fa4ea8f60 Signed-off-by: Xiongwei Song --- Documentation/admin-guide/cgroup-v1/cpusets.rst | 2 +- kernel/cgroup/cpuset.c | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/Documentation/admin-guide/cgroup-v1/cpusets.rst b/Documentation/admin-guide/cgroup-v1/cpusets.rst index ae646d621a8a..88d0e7fa2ee0 100644 --- a/Documentation/admin-guide/cgroup-v1/cpusets.rst +++ b/Documentation/admin-guide/cgroup-v1/cpusets.rst @@ -179,7 +179,7 @@ files describing that cpuset: - cpuset.mem_hardwall flag: is memory allocation hardwalled - cpuset.memory_pressure: measure of how much paging pressure in cpuset - cpuset.memory_spread_page flag: if set, spread page cache evenly on allowed nodes - - cpuset.memory_spread_slab flag: if set, spread slab cache evenly on allowed nodes + - cpuset.memory_spread_slab flag: IT'S OBSOLETE. Please don't use it anymore - cpuset.sched_load_balance flag: if set, load balance within CPUs on that cpuset - cpuset.sched_relax_domain_level: the searching range when migrating tasks diff --git a/kernel/cgroup/cpuset.c b/kernel/cgroup/cpuset.c index ba36c073304a..728d06fe9382 100644 --- a/kernel/cgroup/cpuset.c +++ b/kernel/cgroup/cpuset.c @@ -3897,6 +3897,9 @@ static struct cftype legacy_files[] = { }, { + /* It's obsolete. Please don't use it anymore. We will remove it + * in the future. + */ .name = "memory_spread_slab", .read_u64 = cpuset_read_u64, .write_u64 = cpuset_write_u64,