From patchwork Tue Mar 10 15:33:39 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ulf Hansson X-Patchwork-Id: 184356 Delivered-To: patches@linaro.org Received: by 2002:a92:1f12:0:0:0:0:0 with SMTP id i18csp848417ile; Tue, 10 Mar 2020 08:33:52 -0700 (PDT) X-Received: by 2002:a2e:b6c6:: with SMTP id m6mr13217959ljo.3.1583854432471; Tue, 10 Mar 2020 08:33:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1583854432; cv=none; d=google.com; s=arc-20160816; b=UQp70uIMeVljl8imL2CaQI+o6v3Vuo36BXHGKJjXRsgYJDBNDwK9uwmx4ZNoaAmU+v MSfTVsZGYvQbW3c/k2N4vRNM0ZE3oKNo1NPsc5EM77eHEf6ycAhMo9rAV/mQrkr7vVz2 38xmxReShDkWWyJVPMcFOCS88j/Ph5ZrfqirEWPQQGGt0HuNG68tc7SxJxE3MSVEQa3z xNoVITq8zDBwzd5PvuvP+WdDletdjuGKRCeCbo3ijADth8gDintYOMmaq8A0hf+cwbyp 9ktJdY/Dc+KvqvXM6OnCkz4yqke2bnCEUHo9NdoEqgzb9RydIBHphawxa/ozL0R1BcTu BaEg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=tQ91NJmSAV4APRs3KHb2zhKlTLEt52ygW4o1xrxv0Yc=; b=Q7cSO6PsZ4ymmQOW4s6HcVzqp36mWJDdJHgU0GXlw1JpqsC7MB+YjO15ftgvIi16eN LuThjxiaZ37hETvx6o7GRVvejRTTn1AbQUO7U5pLVPaRlV66ankYz5fFFwTeYN7HJjCu XEat7Ov2vCBX5+lWqpdS5kbeZPn0decQ2oUCZZN41Oztb0XhkhiPYR5wrkErcFkksIjl aa3BrLv077sVPZvW+M+rvg1SfUwr1LpD+9fJcHhnlk/Cbfer4tM+hpg/SWf76/7kjkqB ePZOFu8jlsN5ETq+hXoVo/tIkLE88IajJ9FglpTktDfqgF49G1NMkBdeEzQRqf2aM5a3 MVnQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=cGdazkWP; spf=pass (google.com: domain of ulf.hansson@linaro.org designates 209.85.220.65 as permitted sender) smtp.mailfrom=ulf.hansson@linaro.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from mail-sor-f65.google.com (mail-sor-f65.google.com. [209.85.220.65]) by mx.google.com with SMTPS id x6sor4099265lfq.26.2020.03.10.08.33.52 for (Google Transport Security); Tue, 10 Mar 2020 08:33:52 -0700 (PDT) Received-SPF: pass (google.com: domain of ulf.hansson@linaro.org designates 209.85.220.65 as permitted sender) client-ip=209.85.220.65; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=cGdazkWP; spf=pass (google.com: domain of ulf.hansson@linaro.org designates 209.85.220.65 as permitted sender) smtp.mailfrom=ulf.hansson@linaro.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=tQ91NJmSAV4APRs3KHb2zhKlTLEt52ygW4o1xrxv0Yc=; b=cGdazkWPAfKhtnRnEI2GJzFwuVajaBOS4BQ8hqRTuAgc81uzqNxFrUtq6heoNaKsSU OZWF59ABGCQQRm43Ezooj5qClm98b4lC2ETvbslgeg1zcRIOc1kNWoBa9yfyTCd2hDTH g7XZ7EGusHb2yPm3G2Etafv9bDdPlhF9oBgHUNy3s4ZUJINM88zPILHB7p8b/0UVKxmc IFspfNsRKQ8Agq6u/MYR+v+NA5Mak11gbH6sJsz2yh6pgaq8E7bcQ3eCzFnIaBXBvZjy hlzn9nd296Q6BaA2E20i1LCYf4xImX9mORB10ES0NGu3Fa5+zE4k/uCtDB7PsEWR4gPc SdIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=tQ91NJmSAV4APRs3KHb2zhKlTLEt52ygW4o1xrxv0Yc=; b=K9oviOEceEIys3f09bloQsZ6jZcCzjy6QkdXDHPdiXqAbXyOg3txaxMpyyGbtDntp8 fxpZIDsP/K3+pMWhDNmkqD4STx8Ek2OfFiuxWbXwhx+L7oMS0SZcXgE3gtPYVaBRWfLP il8e713TEu4Di1PlCSL3G/vozw7oi0wBIqFSdUCLvv2UOTI6oE5E+gGC4kR8Zaw0upy3 AN0NFSKFywGWCyMPXKthLjvl7fKJ8V+PUfAIKn3Lw2nfJDBMrAG9kKsn+qsGsIOhKHRK v8WxermBDY7I9A48gNtYtzQHBzFHKeOy+bjMR6YPa38MUY+uADtH+ZC+cm6w/mwx1QaO NH4Q== X-Gm-Message-State: ANhLgQ1A0Pyiy3e33q+lUIOdgxCYYzTpT/x5KFFKMKd3S7fceZYzYSRD 6prcgKzMZrRi7nbepeS99gwAYx5R X-Google-Smtp-Source: ADFU+vsIvho5Opw/cggl/Q7zZCuGRhCYRY6r8tou4/ZEGVeYx3TZIfDapQeyl9aT5hVka/YBRvw9Jw== X-Received: by 2002:a2e:a419:: with SMTP id p25mr3027492ljn.206.1583854432037; Tue, 10 Mar 2020 08:33:52 -0700 (PDT) Return-Path: Received: from localhost.localdomain (h-158-174-22-210.NA.cust.bahnhof.se. [158.174.22.210]) by smtp.gmail.com with ESMTPSA id c22sm17283776lfi.41.2020.03.10.08.33.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Mar 2020 08:33:51 -0700 (PDT) From: Ulf Hansson To: linux-mmc@vger.kernel.org, Ulf Hansson Cc: Adrian Hunter , Wolfram Sang , Ludovic Barre , Baolin Wang , Linus Walleij , Chaotian Jing , Shawn Lin , mirq-linux@rere.qmqm.pl, Bitan Biswas , Peter Geis , Sowjanya Komatineni , Faiz Abbas , Anders Roxell , Naresh Kamboju , Jon Hunter , stable@vger.kernel.org Subject: [PATCH 3/4] mmc: sdhci-omap: Fix busy detection by enabling MMC_CAP_NEED_RSP_BUSY Date: Tue, 10 Mar 2020 16:33:39 +0100 Message-Id: <20200310153340.5593-4-ulf.hansson@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200310153340.5593-1-ulf.hansson@linaro.org> References: <20200310153340.5593-1-ulf.hansson@linaro.org> MIME-Version: 1.0 It has turned out that the sdhci-omap controller requires the R1B response, for commands that has this response associated with them. So, converting from an R1B to an R1 response for a CMD6 for example, leads to problems with the HW busy detection support. Fix this by informing the mmc core about the requirement, via setting the host cap, MMC_CAP_NEED_RSP_BUSY. Reported-by: Naresh Kamboju Reported-by: Anders Roxell Reported-by: Faiz Abbas Cc: Signed-off-by: Ulf Hansson --- drivers/mmc/host/sdhci-omap.c | 3 +++ 1 file changed, 3 insertions(+) -- 2.20.1 Tested-by: Faiz Abbas diff --git a/drivers/mmc/host/sdhci-omap.c b/drivers/mmc/host/sdhci-omap.c index 882053151a47..c4978177ef88 100644 --- a/drivers/mmc/host/sdhci-omap.c +++ b/drivers/mmc/host/sdhci-omap.c @@ -1192,6 +1192,9 @@ static int sdhci_omap_probe(struct platform_device *pdev) if (of_find_property(dev->of_node, "dmas", NULL)) sdhci_switch_external_dma(host, true); + /* R1B responses is required to properly manage HW busy detection. */ + mmc->caps |= MMC_CAP_NEED_RSP_BUSY; + ret = sdhci_setup_host(host); if (ret) goto err_put_sync;