From patchwork Tue Sep 3 14:22:05 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ulf Hansson X-Patchwork-Id: 172802 Delivered-To: patches@linaro.org Received: by 2002:ac9:5c4b:0:0:0:0:0 with SMTP id r11csp5641544ocp; Tue, 3 Sep 2019 07:22:45 -0700 (PDT) X-Received: by 2002:a19:f204:: with SMTP id q4mr6969623lfh.29.1567520565562; Tue, 03 Sep 2019 07:22:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1567520565; cv=none; d=google.com; s=arc-20160816; b=cMtDwJkShSYhN/AoyZR/02BxEl/HrLx8FK5fbigyZsXRR8KscTQhsW32EszkqKJHIV 5YLFAEJQQtpgtkoWyW8oLP8vkqqv9h8kuuOdkMk6F+YocEUlKKbCVahUZpoDJCwzKvCe PnBqiN7dLt28dyCsiO7GWSjKoH3KwhQjgD1WAFj2jL+TT6arphf66rWVL2KExNJnQFJX DzI7Wz6YuLOXHnIPTku4No2yvuOqfULpE/EbyAr2OM4fmfEXPlcrSEu9HlFfEkZbYstR WIMGGMC3+2HoRM12pUTHUsAKWs1+55no2Q2ldLKptqY67tGEsoGE8ikl7tCVPfSQ/Lpg 0ffw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=hUKvWKooE3Nr2LfWI7qknPBybhkMjg8O69FVSs9vXkc=; b=q5MFdnXaMQvx27DK03NKpDicWKLVIkZh14UV095j34U8zOtCGzD0hqXUZaBSH4G2ts ajKVKVpHFGCGnzvhvI4ynuYxY0mZzbe9MLpMJzv8i+6FYCjFiMfy7gYdxesUxTeFuQDH brkqXnFbzTeMzja3IPBPxMPlpdw+La/8uCJ6doWJGgBu7WPeDF8hmDzQzRG6UXP6y5mL QU2zYcTGyjPrKVfE7o7jKooXs5JfBawl7+NjipntY6UCtIU+VrJE55IXp+yuWguEGCLY 9AGBr/1ADdc0vINdLHDagTX50onN3eXUYZ7tB/czPzCboNbmOFC/Cun9z9L2oOdedAtn /Plg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=IyCgQPw2; spf=pass (google.com: domain of ulf.hansson@linaro.org designates 209.85.220.65 as permitted sender) smtp.mailfrom=ulf.hansson@linaro.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from mail-sor-f65.google.com (mail-sor-f65.google.com. [209.85.220.65]) by mx.google.com with SMTPS id p3sor2161286lfc.0.2019.09.03.07.22.45 for (Google Transport Security); Tue, 03 Sep 2019 07:22:45 -0700 (PDT) Received-SPF: pass (google.com: domain of ulf.hansson@linaro.org designates 209.85.220.65 as permitted sender) client-ip=209.85.220.65; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=IyCgQPw2; spf=pass (google.com: domain of ulf.hansson@linaro.org designates 209.85.220.65 as permitted sender) smtp.mailfrom=ulf.hansson@linaro.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=hUKvWKooE3Nr2LfWI7qknPBybhkMjg8O69FVSs9vXkc=; b=IyCgQPw2ykZcke64WeocrNRFfaD/9n4LX7jp4OolaJu1chstHr8JQY7az9MsM2LHfu 8LnV9+FB2P45atdwxzfs9q/98aYbBbqFB5/0BxMEdS//a2gDnHY/GYf8z0Qp5EBNSK85 IIJ7o+AfG0+am8hlLHi+fYcB7rdS3ni89UoSdaaIUQ7vTBikpGzly3mo3OcRApe7OwGQ twMGIlge9iU3ldpxwXFOFGJcklC/73gUGANUrHanqOveSb0DgprvK6HLjkK2NFnak9YP X3XrGDU2OW5ywt4hKN45BGBzSvIzXn5Pspth/FugIwTE4wJW1Otk2zU2/sS0ea0xxdFt askQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=hUKvWKooE3Nr2LfWI7qknPBybhkMjg8O69FVSs9vXkc=; b=ud0o+1YFFuAgM48ZfZDO9L5jUUuKH3JO6BzR1Bs2SZZB46ew+/TPx2GG2HgNzcALDN PLQrR/hrF6daQg1zHksobCEIqlHoDdxihP07gipGhXD8Z979IYuXFxUDP4KxznlHTaQ7 h6syu0y3VcVkGJFtwUXFukNIpaVqkaShU70MnKtCdQu/fl704Xnm98lvDf2MIS1NEy/S B9syQc3w6YOjdo+Z4lHwBH/ZLRXX75WJBosZCZLk27fMyiCW649SU2UFnsFSQepcmwA+ 97BqCIrfby3BBHk5LT2/M8nBcfviJs86hTdF2+TCY6mGVfxh92agWJzO85xcKZXBhJm2 vbvw== X-Gm-Message-State: APjAAAVonCuEp9JFCCQxWAsbiBnEVqSfq5OLE02KyDfF5pNhPjWuTPUU nLPExxFvQ6RYXoHaMhJk3SSkA+lkL2u9VQ== X-Google-Smtp-Source: APXvYqxdOyp0rTA+keK8Vz0OkfEJsyNPg/rV68LgoYLikCASTYSTPK8ZKcshiuJ0b1rvVD46hW0z+g== X-Received: by 2002:ac2:5633:: with SMTP id b19mr4772155lff.103.1567520565203; Tue, 03 Sep 2019 07:22:45 -0700 (PDT) Return-Path: Received: from uffe-XPS-13-9360.ideon.se ([85.235.10.227]) by smtp.gmail.com with ESMTPSA id v10sm2430862ljc.64.2019.09.03.07.22.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Sep 2019 07:22:44 -0700 (PDT) From: Ulf Hansson To: linux-mmc@vger.kernel.org, Ulf Hansson , Adrian Hunter , Douglas Anderson , Matthias Kaehlcke Cc: Shawn Lin , Jaehoon Chung , Yong Mao , Chaotian Jing , linux-kernel@vger.kernel.org Subject: [PATCH 09/11] mmc: sdhci: Drop redundant check in sdhci_ack_sdio_irq() Date: Tue, 3 Sep 2019 16:22:05 +0200 Message-Id: <20190903142207.5825-10-ulf.hansson@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190903142207.5825-1-ulf.hansson@linaro.org> References: <20190903142207.5825-1-ulf.hansson@linaro.org> The sdhci_ack_sdio_irq() is called only when SDIO IRQs are enabled. Therefore, let's drop the redundant check of the internal SDHCI_SDIO_IRQ_ENABLED flag and just re-enable the IRQs immediately. Signed-off-by: Ulf Hansson --- drivers/mmc/host/sdhci.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) -- 2.17.1 Reviewed-by: Matthias Kaehlcke diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c index c1ebc26846db..2a9be044448a 100644 --- a/drivers/mmc/host/sdhci.c +++ b/drivers/mmc/host/sdhci.c @@ -2161,8 +2161,7 @@ static void sdhci_ack_sdio_irq(struct mmc_host *mmc) unsigned long flags; spin_lock_irqsave(&host->lock, flags); - if (host->flags & SDHCI_SDIO_IRQ_ENABLED) - sdhci_enable_sdio_irq_nolock(host, true); + sdhci_enable_sdio_irq_nolock(host, true); spin_unlock_irqrestore(&host->lock, flags); }