| Message ID | 20190306140456.28187-3-ulf.hansson@linaro.org |
|---|---|
| State | New |
| Headers | show
Delivered-To: patches@linaro.org Received: by 2002:a02:5cc1:0:0:0:0:0 with SMTP id w62csp6205989jad; Wed, 6 Mar 2019 06:05:03 -0800 (PST) X-Received: by 2002:a19:381c:: with SMTP id f28mr4256543lfa.169.1551881103279; Wed, 06 Mar 2019 06:05:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1551881103; cv=none; d=google.com; s=arc-20160816; b=KwQfUc8v/7RVB4SwTPTC6BMdHJHIQNboyZ3PfR0d+bsdnyETJJsyFk95SRcQloxDoI MiQUosBD2OIc4rnoRHDpMuuidmC0KqjtCQRTl0HoUdrZtvfPkAlxU7fhCame3NHRBSRK FTGHLW825fH9yUjjvpvTlM5QQ8Aqp0PIWRl28sBn9hn6D/DAlUffSMKFabySOqoNggJJ WzL4p1DEf+Y8OS+XXSXSP1j1/Sc3dp4bMJUAClAs67a5tSNf+870GUsXmNVReScmlEmH sBN2tfJEaXtMSYCyzVwtZ6VB8FlmpO/+N+ZzvuLZ6jI8NeTnEhujxKIMDZnG/oY2n86O 1drA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=cnQWFgoj5dStb9SDgruunD1B301/yL7MXH4brDMgT0I=; b=k7nGcnNcsjXi/bwkL/+ngsyulJh0T3geciLLUBgoJB37n74ATk/SdZXCW1e2qeqaQV fTIsd3F08iupiqYfwjpFkux+Z+65LcCnDn0hQ5+i2mpe7/Tkqt8l83lWTmr7klhwVxSy ZosX27er9oP0Ddh17DGSGSVXANfEuofMrHbE/Sao5zigtt+9mae8GpbOZIsdHNKvGMS4 3CqjXoobma5JhwoTgBq2J0ENR7JyIdhNrPJ5mhbGuVPZWFGzoBax/3CbGLuea5EGwOMq hVbwNvt11KJdFF3xd2taw8hNLPa1PlWcfYElIMo/RVqZHphF9PmrM1USaEdpQSuQa44o aosw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=fKui5pBs; spf=pass (google.com: domain of ulf.hansson@linaro.org designates 209.85.220.65 as permitted sender) smtp.mailfrom=ulf.hansson@linaro.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: <ulf.hansson@linaro.org> Received: from mail-sor-f65.google.com (mail-sor-f65.google.com. [209.85.220.65]) by mx.google.com with SMTPS id h19sor548811lfh.5.2019.03.06.06.05.03 for <patches@linaro.org> (Google Transport Security); Wed, 06 Mar 2019 06:05:03 -0800 (PST) Received-SPF: pass (google.com: domain of ulf.hansson@linaro.org designates 209.85.220.65 as permitted sender) client-ip=209.85.220.65; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=fKui5pBs; spf=pass (google.com: domain of ulf.hansson@linaro.org designates 209.85.220.65 as permitted sender) smtp.mailfrom=ulf.hansson@linaro.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=cnQWFgoj5dStb9SDgruunD1B301/yL7MXH4brDMgT0I=; b=fKui5pBsDoW5m0iU6XU2css8QF2T0fMTM9EYtO0OcvnD+R+kl0O27h4IHQ/D4oRbG9 2IfoXM+rmAPHw/sCcdYO4VEWL+7mipKon1ROMzAZ9FX5EFwhnuAvQuDpol+W46i0QoQL 9UxrigVKL8P4YG8xzh9m8A/c4lMpHgP7LiUT7NCi50pYS4Rbv8PeMyR4XsFVEynMGZUu +sz49O/BoZsU3ltubFjMPeRUzXcUHjKLkvwPxPkNc3CTN5QhAHDFOeSg0CbQFQQTNGqq H2cOOzrhL2llOthnnrxCXn/uDXJuFy0V0DcI+MXxTZ/jb98rNCNVld8Aj8jSlLMpezjt bgrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=cnQWFgoj5dStb9SDgruunD1B301/yL7MXH4brDMgT0I=; b=bH5+eOX4NmpMZ1UnYnDIZK21bR1WJubqAakA17oyl8ts4F+FFY8xvLt7pg/eACfdYt nkwJt3se/fysg0EhyWfDAIkcSE0N51mInb4wyE7ksaxV+nRbncnxa6DpNrNeLON3rS9c lJYhp5hvM1hS5aa3Jm9T70hWm44P+HobS85p5TL6LniqF3zVur7CcjB+7THAdJzoVBAV NEgEqdyhW808eHBCNTHyO59kcULUU8E3h+caHNyNjcLumb8bILglZqybBAF6BtDTfYB2 dWAMS8nvT8D3WvSOf3Io05lWkueWbRVQeiY/9722zoW4ntnomLFnBMRmROs3YnU+xqWi ya5A== X-Gm-Message-State: APjAAAXHd3etp7dnjDm7S+2U2v4n/6jTHHvtNiqvWuK0uaoouLQyBVy4 E/YSHn/mSm4JcYRGKerV+VavqQzG X-Google-Smtp-Source: APXvYqxScOwDJQve8oKkRyRPtJxLoo+Nix97UXS3Aa8oYhj3ZQsKhI9hhTocilAWUgaDikXdsAAXVw== X-Received: by 2002:ac2:5607:: with SMTP id v7mr3908412lfd.50.1551881102842; Wed, 06 Mar 2019 06:05:02 -0800 (PST) Return-Path: <ulf.hansson@linaro.org> Received: from localhost.localdomain (h-158-174-22-210.NA.cust.bahnhof.se. [158.174.22.210]) by smtp.gmail.com with ESMTPSA id o12sm343734ljc.37.2019.03.06.06.05.01 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 06 Mar 2019 06:05:02 -0800 (PST) From: Ulf Hansson <ulf.hansson@linaro.org> To: linux-mmc@vger.kernel.org, Ludovic Barre <ludovic.barre@st.com> Cc: Russell King <linux@armlinux.org.uk>, Linus Walleij <linus.walleij@linaro.org>, Ulf Hansson <ulf.hansson@linaro.org> Subject: [PATCH 2/6] mmc: mmci: Drop unnecessary clear of variant->qcom_dml flag Date: Wed, 6 Mar 2019 15:04:52 +0100 Message-Id: <20190306140456.28187-3-ulf.hansson@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190306140456.28187-1-ulf.hansson@linaro.org> References: <20190306140456.28187-1-ulf.hansson@linaro.org> |
| Series |
mmc: mmci: Cleanup some variant related code
|
expand
|
diff --git a/drivers/mmc/host/mmci_qcom_dml.c b/drivers/mmc/host/mmci_qcom_dml.c index 25d0a75533ea..b942d4aeeb77 100644 --- a/drivers/mmc/host/mmci_qcom_dml.c +++ b/drivers/mmc/host/mmci_qcom_dml.c @@ -133,7 +133,6 @@ static int qcom_dma_setup(struct mmci_host *host) producer_id = of_get_dml_pipe_index(np, "rx"); if (producer_id < 0 || consumer_id < 0) { - host->variant->qcom_dml = false; mmci_dmae_release(host); return -EINVAL; }
There's no point clearing the variant flag in case the qcom variant fails to setup DMA. This is because if mmci_dma_setup() fails, then the use_dma flag remains set to false, which leads to mmci using PIO mode and not DMA. Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org> --- drivers/mmc/host/mmci_qcom_dml.c | 1 - 1 file changed, 1 deletion(-) -- 2.17.1