From patchwork Fri Nov 10 10:01:36 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 118520 Delivered-To: patch@linaro.org Received: by 10.140.22.164 with SMTP id 33csp7722568qgn; Fri, 10 Nov 2017 02:02:08 -0800 (PST) X-Google-Smtp-Source: ABhQp+SptKOHWFmLNCU/bBaLXfr7b7j0Y69kp0S997SJN4kNyzcqb/VmIa24ss/5LFMYxkuVXB4d X-Received: by 10.98.71.25 with SMTP id u25mr3808142pfa.75.1510308128373; Fri, 10 Nov 2017 02:02:08 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1510308128; cv=none; d=google.com; s=arc-20160816; b=cD7IviU5kNQatu7muvclkGwbvw93nngSaFMsb9n4PdGiaM1xgcT7SwrLkHqS8w/nLt X4bYhnmCWAcezkq2FU6ekTGZfdHswrMwh20r0em2cK/n5hfXu+NNt/blnZVyZesHYn96 Mr8dEkiGmhtDFlTq6nZEOeXv5hOh0I9HhIFaaQGuNYGl1iJXGvcNUi8PxC79Lmx6513M r0iQ3UvG0B6Vx9RLoJA3UuPTwR3bzjq2Asi6XHwpl+ONiKq93cx1BOzd2HB4D9NEF4jI rqCpR0muL+8uIFWAuP2TV+mj+1B+FaNZIG29FeI5bEvmkP6MO1O0B504IIRD7CQrY9XQ aZvA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:arc-authentication-results; bh=KsXAi2/Qigw74r6XcDX8JU5pEqHmF+bUY+2PsW3IW6A=; b=HXdp9SnjTAhludnh+lUXzYk1OCb8sVrglcHChH5vLhMgYaqg2lJfSNiRY0SbunZXrw Iqh2F//UE8bDtQ+8gA2YW3YKLzKPXEfFBE+O9rYwHZvD5fu2GRPJDthBpFxrEjRJC1Tq VlNzqfpmZFPT+o4nmLCDLsWPTVkrDP2RNeqhGcJSkhLbpmbnB9XPED3C8vooiluWac7k 5G9446LQeuj0P9tI2Uw6QwIZ1Nb+apTeigN8xOC6/yyHchMxqkn6mPjz9ARSZdu/FkZL 91LBcn+g/5QqJSMUTBc0Ht9vhOzNt4VvAR6V2wdu3TNncV8N5QRmteU76dPfLUXU5Xzn ERHQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=gVcIEbw5; spf=pass (google.com: best guess record for domain of linux-mmc-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-mmc-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z14si8801659plh.282.2017.11.10.02.02.08; Fri, 10 Nov 2017 02:02:08 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-mmc-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=gVcIEbw5; spf=pass (google.com: best guess record for domain of linux-mmc-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-mmc-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752289AbdKJKCE (ORCPT + 6 others); Fri, 10 Nov 2017 05:02:04 -0500 Received: from mail-lf0-f66.google.com ([209.85.215.66]:47163 "EHLO mail-lf0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751496AbdKJKCC (ORCPT ); Fri, 10 Nov 2017 05:02:02 -0500 Received: by mail-lf0-f66.google.com with SMTP id f125so10365624lff.4 for ; Fri, 10 Nov 2017 02:02:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=E7YlvG7DlQwP+vdm50/EiojcBTJPzzEzXt9DrRyxwrA=; b=gVcIEbw500BzGvgH1ZgT/rYq5OXOcCP37tX4dP0+Aahz04RiPRW1EoycQhX8ItXTsb Z4xYwf2XhYbWhU5kJVFPKiFBW/lHchf6jFeojEyIBzIytDpFXekgBzVVXpb1rgBawU2W lYy8C9Eew/vs+e9knI+aIlR9KqwP0Ds56c84s= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=E7YlvG7DlQwP+vdm50/EiojcBTJPzzEzXt9DrRyxwrA=; b=GB3n2bD16cTQo+oTvEsHrvB+5d0w6jVhdwACQxP5I3oI+E7giLUH0Pe60k+Cl0od+3 LaOpJ+2UBNKhO8AZKoSPQpxBIG4jxWWgcRpdaCoY2okXebPWlIgtnbfZ4l88EGa9HYC1 SipuejwBPxI08SyW5d18J6sqgHEf+tnkrt2IAs/NcH/B9xn0X0ex5qIxcn+DnuyD1T8K WQ+jNGxAoK7zqk5uBxe3fydq7AYWvJb1o2ytzIYfZSrxhiJxhc1YZKC4VXES72+a4RgM w1LrC9h+kbgrYv6dUk6vVRXhccojdXIg4YwRw94IowLERQNZAH3jXPMr1ku4MszoGM1c ueuw== X-Gm-Message-State: AJaThX7UOHQDqxOtO5oRokSjAecsDIlTERG/rKRhooKkdfkajXiCcEKC MMZjXVLzKF9tvh/NpEndhuw8IxXKGhQ= X-Received: by 10.46.89.147 with SMTP id g19mr1398584ljf.26.1510308120399; Fri, 10 Nov 2017 02:02:00 -0800 (PST) Received: from genomnajs.ideon.se ([85.235.10.227]) by smtp.gmail.com with ESMTPSA id n36sm310843lfi.78.2017.11.10.02.01.58 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 10 Nov 2017 02:01:59 -0800 (PST) From: Linus Walleij To: linux-mmc@vger.kernel.org, Ulf Hansson Cc: linux-block@vger.kernel.org, Jens Axboe , Christoph Hellwig , Arnd Bergmann , Bartlomiej Zolnierkiewicz , Paolo Valente , Avri Altman , Adrian Hunter , Linus Walleij Subject: [PATCH 05/12] mmc: core: do away with is_new_req Date: Fri, 10 Nov 2017 11:01:36 +0100 Message-Id: <20171110100143.12256-6-linus.walleij@linaro.org> X-Mailer: git-send-email 2.13.6 In-Reply-To: <20171110100143.12256-1-linus.walleij@linaro.org> References: <20171110100143.12256-1-linus.walleij@linaro.org> Sender: linux-mmc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org The host context member "is_new_req" is only assigned values, never checked. Delete it. Signed-off-by: Linus Walleij --- ChangeLog v1->v5: - Rebasing on the "next" branch in the MMC tree. --- drivers/mmc/core/core.c | 1 - drivers/mmc/core/queue.c | 5 ----- include/linux/mmc/host.h | 2 -- 3 files changed, 8 deletions(-) -- 2.13.6 -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/mmc/core/core.c b/drivers/mmc/core/core.c index 15a664d3c199..b1a5059f6cd1 100644 --- a/drivers/mmc/core/core.c +++ b/drivers/mmc/core/core.c @@ -3007,7 +3007,6 @@ void mmc_unregister_pm_notifier(struct mmc_host *host) */ void mmc_init_context_info(struct mmc_host *host) { - host->context_info.is_new_req = false; host->context_info.is_waiting_last_req = false; } diff --git a/drivers/mmc/core/queue.c b/drivers/mmc/core/queue.c index c46be4402803..4a0752ef6154 100644 --- a/drivers/mmc/core/queue.c +++ b/drivers/mmc/core/queue.c @@ -55,7 +55,6 @@ static int mmc_queue_thread(void *d) req = blk_fetch_request(q); mq->asleep = false; cntx->is_waiting_last_req = false; - cntx->is_new_req = false; if (!req) { /* * Dispatch queue is empty so set flags for @@ -109,10 +108,6 @@ static void mmc_request_fn(struct request_queue *q) cntx = &mq->card->host->context_info; - if (cntx->is_waiting_last_req) { - cntx->is_new_req = true; - } - if (mq->asleep) wake_up_process(mq->thread); } diff --git a/include/linux/mmc/host.h b/include/linux/mmc/host.h index d43d26562fae..36af19990683 100644 --- a/include/linux/mmc/host.h +++ b/include/linux/mmc/host.h @@ -241,11 +241,9 @@ struct mmc_slot { /** * mmc_context_info - synchronization details for mmc context - * @is_new_req wake up reason was new request * @is_waiting_last_req mmc context waiting for single running request */ struct mmc_context_info { - bool is_new_req; bool is_waiting_last_req; };