From patchwork Mon Aug 28 14:29:14 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jerome Brunet X-Patchwork-Id: 111165 Delivered-To: patch@linaro.org Received: by 10.140.95.78 with SMTP id h72csp4919475qge; Mon, 28 Aug 2017 07:30:19 -0700 (PDT) X-Received: by 10.84.215.149 with SMTP id l21mr988855pli.308.1503930619516; Mon, 28 Aug 2017 07:30:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1503930619; cv=none; d=google.com; s=arc-20160816; b=JeBXDHDP/GlEctKCL6HAt5prH7dIvCLRgSYyGhCzmpqUhNw7MaVNqqN3rlACg8ALiY z8r5TlhnCw00Ar5ifjh2EkgP+ZMZspojxsKT8eag2V2xq/fSLbn/MfiJfWQaJ0IwqF3d l4vmMjxlU3bbFvZSmor+RWeTdihawmKrsnFrWJLkbEuZdBYQji9ODlh/lo3isjSok2KD CGTGZSOFXeI2TSCUPJjBBFMiz+llbcYT3a/9PvVuuX2HGN2ZEZRcQBGv72eZirdrKkrA an/KD1eoow/LNHC3hFTSDXiMb0wcTsURcDeSMqySU+INbwSPI9tPmpZ7xkhe4DKnmOQZ OiMQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:arc-authentication-results; bh=wNFR0M6D31/qb7g2xbd2znfZ7WyiAohrEMcw7DPHgdQ=; b=hrSrNVryCFtKrzuZU232l6YiRLmC7q2bLoCz3U0M0wt2eD/bUX3BruTUwwetyt33Cj oGYhwWVEs7/B3O5VlgCmxScfWnqOelwpZpmAa+I4Q13C6pnJZFu1oRWlERmteBdIfOvF +GqYaxd/R7nuky1kHA/LTrhghI3QR3ryQL2Xp5BonmOtwzbO9nOuCrkGcqdWKDu1vYlU T7HerUw1mPaVmghRvVT7IPfJU/lHrVfuInRF4OLzXWp5iD1plY3oF5e+YQa8tVaxcL1I 0a1a5EbocRM9cRIIZkbACJgyZ7gkwwJuhfiqI0lQ3WhWFDcWXkgd/eDXjWN+ykV29eIP Nl9Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@baylibre-com.20150623.gappssmtp.com header.s=20150623 header.b=NSmJm8ej; spf=pass (google.com: best guess record for domain of linux-mmc-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-mmc-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p11si361113pgc.797.2017.08.28.07.30.19; Mon, 28 Aug 2017 07:30:19 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-mmc-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@baylibre-com.20150623.gappssmtp.com header.s=20150623 header.b=NSmJm8ej; spf=pass (google.com: best guess record for domain of linux-mmc-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-mmc-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751787AbdH1OaO (ORCPT + 6 others); Mon, 28 Aug 2017 10:30:14 -0400 Received: from mail-wr0-f182.google.com ([209.85.128.182]:35953 "EHLO mail-wr0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751485AbdH1O3c (ORCPT ); Mon, 28 Aug 2017 10:29:32 -0400 Received: by mail-wr0-f182.google.com with SMTP id p14so2202954wrg.3 for ; Mon, 28 Aug 2017 07:29:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=pKHhUpHQ3bkHhnlF2wqNG/5BoyWKwqpXO5w79ZiBWcI=; b=NSmJm8ejzwgNLoM68Hgw8yBmHGqNvEyiZSoboAR+ou7rETMglc5/HjRGLda4Q3z2Pv 0aosVe32Vd8qlw5TYWOcjtY6ykbvaUI8cLzO7Gh6EFq/00uBxOt+QuGhVpaxx/DlyGQi Kwl687W4quGDp0oo6wz0qYPGxkTJKsetbQqB/xH7ak1Hn2L0eVr/f5Yz4EBPRXHw1mES GAoOw19J6VlA3kFo7f54+aCvJXvjqEftDG3t1IpuiZjN6iDzpTy7Ak1H31kyFgZbqNBi I5y903qHPuN3XcBeAY2qJs5/SMJq8FQdLM6jaG0pFypS46qWgp5GppX4jXrQR2IchD9K n7bw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=pKHhUpHQ3bkHhnlF2wqNG/5BoyWKwqpXO5w79ZiBWcI=; b=kXs69Au7FTK5Umfkg8Yo8e5kZYNTNL4HJZUNzXrNWsFbb9YaCm1PDoQR4AAZAPJ1oo Av0kVqcuKyjcNxT7FX+ViuyjwBeMk3be6cu8GtGo8yhuv/zKY5zrXTJ3I7J/Lhh5Tqf2 rHDdqJ+ALyhFuyFgAdvyehQ/l3zwqHWpNfFIoFUjQtnWzK+2gSrGI43aYDLSzWmUHpFV JXU4TDFbheHTn9HwFZbb+RjLwDMQCYugaK1silkyiBKfrRg0IzIjoq5ZXWh85h0h43+H JWg21t4uOn/ikGmWhCBnrl1LvYGFXT1venuN/6Jpr4B5s9KknJGlJOz7hJ2wXhqyF1ZJ uE+A== X-Gm-Message-State: AHYfb5hHMgrqnm9n2qqnPVFWvs5pwXPjcqWQd1763BiUNKPwHJXisVcU KQ+lxQY7urpfM84N X-Received: by 10.223.148.100 with SMTP id 91mr534430wrq.15.1503930571394; Mon, 28 Aug 2017 07:29:31 -0700 (PDT) Received: from localhost.localdomain (uluru.liltaz.com. [163.172.81.188]) by smtp.googlemail.com with ESMTPSA id z39sm604792wrz.61.2017.08.28.07.29.30 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 28 Aug 2017 07:29:30 -0700 (PDT) From: Jerome Brunet To: Ulf Hansson , Kevin Hilman , Carlo Caione Cc: Jerome Brunet , linux-mmc@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 12/13] mmc: meson-gx: change default tx phase Date: Mon, 28 Aug 2017 16:29:14 +0200 Message-Id: <20170828142915.27020-13-jbrunet@baylibre.com> X-Mailer: git-send-email 2.9.5 In-Reply-To: <20170828142915.27020-1-jbrunet@baylibre.com> References: <20170828142915.27020-1-jbrunet@baylibre.com> Sender: linux-mmc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org Initial default tx phase was set to 0 while the datasheet recommends 270. Some cards fails to initialize with this setting and eMMC mode DDR52 does not work. Changing this setting to 270 fixes these issues, without any regression so far Reviewed-by: Kevin Hilman Signed-off-by: Jerome Brunet --- drivers/mmc/host/meson-gx-mmc.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) -- 2.9.5 -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/mmc/host/meson-gx-mmc.c b/drivers/mmc/host/meson-gx-mmc.c index 0cffc705bfe3..efffd36c8d77 100644 --- a/drivers/mmc/host/meson-gx-mmc.c +++ b/drivers/mmc/host/meson-gx-mmc.c @@ -1156,8 +1156,14 @@ static int meson_mmc_probe(struct platform_device *pdev) if (ret) goto free_host; + /* + * Set phases : These values are mostly the datasheet recommended ones + * except for the Tx phase. Datasheet recommends 180 but some cards + * fail at initialisation with it. 270 works just fine, it fixes these + * initialisation issues and enable eMMC DDR52 mode. + */ host->tp.core_phase = 180; - host->tp.tx_phase = 0; + host->tp.tx_phase = 270; host->tp.rx_phase = 0; ret = meson_mmc_clk_init(host);