From patchwork Thu Feb 9 15:33:55 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 93720 Delivered-To: patch@linaro.org Received: by 10.182.3.34 with SMTP id 2csp81254obz; Thu, 9 Feb 2017 07:36:24 -0800 (PST) X-Received: by 10.84.129.3 with SMTP id 3mr4928502plb.153.1486654584015; Thu, 09 Feb 2017 07:36:24 -0800 (PST) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p1si10315679pga.393.2017.02.09.07.36.23; Thu, 09 Feb 2017 07:36:24 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-mmc-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org; spf=pass (google.com: best guess record for domain of linux-mmc-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-mmc-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752954AbdBIPgQ (ORCPT + 5 others); Thu, 9 Feb 2017 10:36:16 -0500 Received: from mail-lf0-f43.google.com ([209.85.215.43]:36860 "EHLO mail-lf0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753920AbdBIPgI (ORCPT ); Thu, 9 Feb 2017 10:36:08 -0500 Received: by mail-lf0-f43.google.com with SMTP id z134so4499843lff.3 for ; Thu, 09 Feb 2017 07:35:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=iz4KMC/d9NZUEsp3w+X1dhR5CGyVn8pJb3DutyhS2T4=; b=j9/M747JmBKsu1htjr61Jtmda/bOMPnyLt10ksv8tuZlguqqJex4VqHHGgkAret1jA Ge9Hlw9TAnkbaX3SoMQQiBEChjPWFmdHXfWJJw9ceQR9SCDIVpJGGZG8G3P2rZophMIF PYjD2/sZDxi4bRkBcM/5gdzobjO8BG95xzZD0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=iz4KMC/d9NZUEsp3w+X1dhR5CGyVn8pJb3DutyhS2T4=; b=iDoTrXhmR/i3Y5Oat1ai+Jr2lafbr6yU5R51bvof72FLPSbdGCn+d6zWkkOeh0m/k4 iiJoPhzEzR7OHc5FOMtjz2bMpEXWSl3uV+SC/2l/WQPkGcbLEWA6WmaPEebTBzlOhIKL OaGEHqLG/XepfSOFa6QNyyhDJUgTo0MJmaKrnuVh0dhx/Qp2x6OtNO+f9Te5cmD23tsX 8vm6ZHzYjw8q3bkRSClgS2v79Ca2cmJoY5PptxXnx7Qo/75kj2tARbG7ESBGUS5RPCsH WIJHMesry5YVPxP1iUYImxFqVgmPJKdr9a2e3KBaS5B/jeXTQfp3AzEVjDxguNc9BUwt PdBQ== X-Gm-Message-State: AMke39mm3TtsU251ndNuiNMFRnTTAyZ2gyX3jW86csiwgmQ0kGTPm957PlwF1p7d+zbWPGcg X-Received: by 10.25.200.14 with SMTP id y14mr1328251lff.98.1486654507119; Thu, 09 Feb 2017 07:35:07 -0800 (PST) Received: from gnarp.ideon.se ([85.235.10.227]) by smtp.gmail.com with ESMTPSA id e86sm3670614lji.32.2017.02.09.07.35.05 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 09 Feb 2017 07:35:05 -0800 (PST) From: Linus Walleij To: linux-mmc@vger.kernel.org, Ulf Hansson , Adrian Hunter , Paolo Valente Cc: Chunyan Zhang , Baolin Wang , linux-block@vger.kernel.org, Jens Axboe , Christoph Hellwig , Arnd Bergmann , Linus Walleij Subject: [PATCH 08/16] mmc: core: do away with is_new_req Date: Thu, 9 Feb 2017 16:33:55 +0100 Message-Id: <20170209153403.9730-9-linus.walleij@linaro.org> X-Mailer: git-send-email 2.9.3 In-Reply-To: <20170209153403.9730-1-linus.walleij@linaro.org> References: <20170209153403.9730-1-linus.walleij@linaro.org> Sender: linux-mmc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org The host context member "is_new_req" is only assigned values, never checked. Delete it. Signed-off-by: Linus Walleij --- drivers/mmc/core/core.c | 1 - drivers/mmc/core/queue.c | 5 ----- include/linux/mmc/host.h | 2 -- 3 files changed, 8 deletions(-) -- 2.9.3 -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Reviewed-by: Bartlomiej Zolnierkiewicz diff --git a/drivers/mmc/core/core.c b/drivers/mmc/core/core.c index fcb40ade9b82..933a4d1f20d5 100644 --- a/drivers/mmc/core/core.c +++ b/drivers/mmc/core/core.c @@ -2985,7 +2985,6 @@ void mmc_unregister_pm_notifier(struct mmc_host *host) */ void mmc_init_context_info(struct mmc_host *host) { - host->context_info.is_new_req = false; host->context_info.is_waiting_last_req = false; } diff --git a/drivers/mmc/core/queue.c b/drivers/mmc/core/queue.c index 73250ed8f093..63927ffd6825 100644 --- a/drivers/mmc/core/queue.c +++ b/drivers/mmc/core/queue.c @@ -66,7 +66,6 @@ static int mmc_queue_thread(void *d) req = blk_fetch_request(q); mq->asleep = false; cntx->is_waiting_last_req = false; - cntx->is_new_req = false; if (!req) { /* * Dispatch queue is empty so set flags for @@ -136,10 +135,6 @@ static void mmc_request_fn(struct request_queue *q) cntx = &mq->card->host->context_info; - if (cntx->is_waiting_last_req) { - cntx->is_new_req = true; - } - if (mq->asleep) wake_up_process(mq->thread); } diff --git a/include/linux/mmc/host.h b/include/linux/mmc/host.h index cbb40682024a..970d7f9b1eba 100644 --- a/include/linux/mmc/host.h +++ b/include/linux/mmc/host.h @@ -194,11 +194,9 @@ struct mmc_slot { /** * mmc_context_info - synchronization details for mmc context - * @is_new_req wake up reason was new request * @is_waiting_last_req mmc context waiting for single running request */ struct mmc_context_info { - bool is_new_req; bool is_waiting_last_req; };