From patchwork Tue Jan 24 10:17:54 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 92322 Delivered-To: patch@linaro.org Received: by 10.182.3.34 with SMTP id 2csp1624307obz; Tue, 24 Jan 2017 02:18:19 -0800 (PST) X-Received: by 10.99.109.143 with SMTP id i137mr37756809pgc.11.1485253099114; Tue, 24 Jan 2017 02:18:19 -0800 (PST) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m1si7259622pfb.261.2017.01.24.02.18.18; Tue, 24 Jan 2017 02:18:19 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-mmc-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org; spf=pass (google.com: best guess record for domain of linux-mmc-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-mmc-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750950AbdAXKSS (ORCPT + 5 others); Tue, 24 Jan 2017 05:18:18 -0500 Received: from mail-lf0-f47.google.com ([209.85.215.47]:34588 "EHLO mail-lf0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750897AbdAXKSR (ORCPT ); Tue, 24 Jan 2017 05:18:17 -0500 Received: by mail-lf0-f47.google.com with SMTP id v186so108165860lfa.1 for ; Tue, 24 Jan 2017 02:18:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=yPKkcMuzMsbiustzhJoXGYnVRUcv+qI1oydyp0QpwZc=; b=FKhzY0eqQA6CLooxGL/P8ByHTDr4/j2mGZa2pQUEcai4b49cp6Kxvu5JsSH3rvj7V0 8xMOmHQ4TOADABv4vOsZNGOMQ6CNlOjHnqYXYIJNvmDbG1B/iW5mHB6Hnl3/D7W1QIOB ZP91gEiQKbRlQMX0Raq7oxrgL9/3HYQFovMpI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=yPKkcMuzMsbiustzhJoXGYnVRUcv+qI1oydyp0QpwZc=; b=sVNdoLOh9ciOKE4JrIVF8eBOa3PLCpInxWbaNWpGBv8kBBs39fILOLEc+x+o+A3PuL na+qCUoGdEWsEk2dZbUyM4a4vdv3XUBgvlIvAVlJtv9v0pS2vCdGSeLlCqRQiw6/FlsP YSs71SQ72yWMdR+vMrtrlyXpHSy+1LNkbda2zIOPRhEY6yxT4p5QasLXfowfTDedmCYC QLsGaJQoRB4c6VJgIvUKPjdEv6vMbcina7KOQewpIttkvbK3iRJuqiz802wVBTyu+V77 VLxkBKKTEFKFxAY6GIuGSauamnJVSLX1XLCOnV2lQSK/nYoqlGeDLRRrBvAGvbvNs+gq ngcA== X-Gm-Message-State: AIkVDXIbFkr7LmFoGdwMUp7PdxreuQBrJSZ0faDDvuC3oXkK40NqavfMBDNyLH9r1NTKSedn X-Received: by 10.25.221.217 with SMTP id w86mr9767833lfi.141.1485253095552; Tue, 24 Jan 2017 02:18:15 -0800 (PST) Received: from gnarp.ideon.se ([85.235.10.227]) by smtp.gmail.com with ESMTPSA id o91sm7410797lfg.17.2017.01.24.02.18.14 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 24 Jan 2017 02:18:14 -0800 (PST) From: Linus Walleij To: linux-mmc@vger.kernel.org, linux-block@vger.kernel.org, Ulf Hansson Cc: Chunyan Zhang , Baolin Wang , Paolo Valente , Linus Walleij Subject: [PATCH 3/6] mmc: block: do not assign mq_rq when aborting command Date: Tue, 24 Jan 2017 11:17:54 +0100 Message-Id: <20170124101757.19676-4-linus.walleij@linaro.org> X-Mailer: git-send-email 2.9.3 In-Reply-To: <20170124101757.19676-1-linus.walleij@linaro.org> References: <20170124101757.19676-1-linus.walleij@linaro.org> Sender: linux-mmc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org The code in mmc_blk_issue_rq_rq() aborts a command if the request is not properly aligned on large sectors. As part of the path jumping out, it assigns the local variable mq_rq reflecting a MMC queue request to the current MMC queue request, which is confusing since the variable is not used after this jump. Signed-off-by: Linus Walleij --- drivers/mmc/core/block.c | 1 - 1 file changed, 1 deletion(-) -- 2.9.3 -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/mmc/core/block.c b/drivers/mmc/core/block.c index b60d1fb3a07a..13e6fe060f26 100644 --- a/drivers/mmc/core/block.c +++ b/drivers/mmc/core/block.c @@ -1649,7 +1649,6 @@ static int mmc_blk_issue_rw_rq(struct mmc_queue *mq, struct request *rqc) !IS_ALIGNED(blk_rq_sectors(rqc), 8)) { pr_err("%s: Transfer size is not 4KB sector size aligned\n", rqc->rq_disk->disk_name); - mq_rq = mq->mqrq_cur; req = rqc; rqc = NULL; goto cmd_abort;