From patchwork Wed Nov 16 10:51:14 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ulf Hansson X-Patchwork-Id: 82470 Delivered-To: patches@linaro.org Received: by 10.140.97.165 with SMTP id m34csp82360qge; Wed, 16 Nov 2016 02:51:35 -0800 (PST) X-Received: by 10.55.0.65 with SMTP id 62mr2260309qka.106.1479293495809; Wed, 16 Nov 2016 02:51:35 -0800 (PST) Return-Path: Received: from mail-qt0-x230.google.com (mail-qt0-x230.google.com. [2607:f8b0:400d:c0d::230]) by mx.google.com with ESMTPS id b124si21318194qkg.291.2016.11.16.02.51.35 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 16 Nov 2016 02:51:35 -0800 (PST) Received-SPF: pass (google.com: domain of ulf.hansson@linaro.org designates 2607:f8b0:400d:c0d::230 as permitted sender) client-ip=2607:f8b0:400d:c0d::230; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org; spf=pass (google.com: domain of ulf.hansson@linaro.org designates 2607:f8b0:400d:c0d::230 as permitted sender) smtp.mailfrom=ulf.hansson@linaro.org; dmarc=pass (p=NONE dis=NONE) header.from=linaro.org Received: by mail-qt0-x230.google.com with SMTP id c47so95936799qtc.2 for ; Wed, 16 Nov 2016 02:51:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=6BZAnPdhzCYfwAGtIxPubfuymbMszR65uh3sbT4RXpE=; b=XHiAuKNsn3B90ZOhsPcGi7pZEnh9vOuLptWDG1654PDXoNuYuKflYsba50teVEJl+t 38MomD6Clr3Wzy4jvlTluwmrfw4Sjw49e8bn6/e4fiPaYBucTqHnpQA4qqSwSS4856DV XW6wRTYKWDJSGoWs4+6Lcaa07PH/SqToeFuzU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=6BZAnPdhzCYfwAGtIxPubfuymbMszR65uh3sbT4RXpE=; b=epBvmc+/mSVHL/0cx8xJgWVoxiOskuUvlqrDDVc7syVekCD61JLeG1posi0YRiiNtL avkonpX/Iv1bwZCwGc5vgxNFZX03to4KQ6bf8ONqZjlWsIHThcAriIVfp2nHcIUbbrVo UDARkrULjwrwxucM3zAfKQJyYUs8k4o070DdoPi45QKUnRkDfWg1HZDsYPXGY/DNA9WU R2Knuk3EIzcqQq+ccAqbgGCIIa4IKgplxmZ4n22P1K881f17+/Ow2535AdXYLynKpNbQ 1vAZwZIAJnaHNNigtPr+aAk4nn/Wfg+U9oRCNFPLqM3CU5ls8bNlCLaNtmFLhZ/vYqcF jy+Q== X-Gm-Message-State: ABUngvc4hw/dMRZZGMvV7f0k47zyoKC+ouzO2frhGFsWPQAiVZrQ4Jq2KuEg40AVdGT/IShNJTE= X-Received: by 10.25.210.147 with SMTP id j141mr852409lfg.78.1479293495439; Wed, 16 Nov 2016 02:51:35 -0800 (PST) Return-Path: Received: from uffe-Latitude-E6430s.ideon.se ([85.235.10.227]) by smtp.gmail.com with ESMTPSA id 34sm7711369lja.25.2016.11.16.02.51.33 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 16 Nov 2016 02:51:34 -0800 (PST) From: Ulf Hansson To: linux-mmc@vger.kernel.org, Ulf Hansson Cc: Jaehoon Chung , Adrian Hunter , Linus Walleij , Chaotian Jing , Stephen Boyd , Michael Walle , Yong Mao , Shawn Lin Subject: [PATCH 2/9] mmc: core: Remove redundant __mmc_send_status() Date: Wed, 16 Nov 2016 11:51:14 +0100 Message-Id: <1479293481-20186-3-git-send-email-ulf.hansson@linaro.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1479293481-20186-1-git-send-email-ulf.hansson@linaro.org> References: <1479293481-20186-1-git-send-email-ulf.hansson@linaro.org> There are only one users left which calls __mmc_send_status(). Moreover, the ignore_crc parameter isn't being used, so let's just remove these redundant parts. Signed-off-by: Ulf Hansson --- drivers/mmc/core/mmc_ops.c | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) -- 1.9.1 diff --git a/drivers/mmc/core/mmc_ops.c b/drivers/mmc/core/mmc_ops.c index 4773c56..0515748 100644 --- a/drivers/mmc/core/mmc_ops.c +++ b/drivers/mmc/core/mmc_ops.c @@ -54,8 +54,7 @@ 0xff, 0x77, 0x77, 0xff, 0x77, 0xbb, 0xdd, 0xee, }; -static inline int __mmc_send_status(struct mmc_card *card, u32 *status, - bool ignore_crc) +int mmc_send_status(struct mmc_card *card, u32 *status) { int err; struct mmc_command cmd = {0}; @@ -67,8 +66,6 @@ static inline int __mmc_send_status(struct mmc_card *card, u32 *status, if (!mmc_host_is_spi(card->host)) cmd.arg = card->rca << 16; cmd.flags = MMC_RSP_SPI_R2 | MMC_RSP_R1 | MMC_CMD_AC; - if (ignore_crc) - cmd.flags &= ~MMC_RSP_CRC; err = mmc_wait_for_cmd(card->host, &cmd, MMC_CMD_RETRIES); if (err) @@ -83,11 +80,6 @@ static inline int __mmc_send_status(struct mmc_card *card, u32 *status, return 0; } -int mmc_send_status(struct mmc_card *card, u32 *status) -{ - return __mmc_send_status(card, status, false); -} - static int _mmc_select_card(struct mmc_host *host, struct mmc_card *card) { struct mmc_command cmd = {0};