From patchwork Mon Aug 15 02:28:18 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Shawn Guo X-Patchwork-Id: 3447 Return-Path: X-Original-To: patchwork@peony.canonical.com Delivered-To: patchwork@peony.canonical.com Received: from fiordland.canonical.com (fiordland.canonical.com [91.189.94.145]) by peony.canonical.com (Postfix) with ESMTP id A95CB23E54 for ; Mon, 15 Aug 2011 02:14:47 +0000 (UTC) Received: from mail-ew0-f52.google.com (mail-ew0-f52.google.com [209.85.215.52]) by fiordland.canonical.com (Postfix) with ESMTP id 974D5A184B0 for ; Mon, 15 Aug 2011 02:14:47 +0000 (UTC) Received: by ewy28 with SMTP id 28so2460335ewy.11 for ; Sun, 14 Aug 2011 19:14:47 -0700 (PDT) Received: by 10.213.3.155 with SMTP id 27mr416979ebn.18.1313374487150; Sun, 14 Aug 2011 19:14:47 -0700 (PDT) X-Forwarded-To: linaro-patchwork@canonical.com X-Forwarded-For: patch@linaro.org linaro-patchwork@canonical.com Delivered-To: patches@linaro.org Received: by 10.213.102.5 with SMTP id e5cs75495ebo; Sun, 14 Aug 2011 19:14:46 -0700 (PDT) Received: from mr.google.com ([10.142.196.20]) by 10.142.196.20 with SMTP id t20mr1893970wff.355.1313374486521 (num_hops = 1); Sun, 14 Aug 2011 19:14:46 -0700 (PDT) Received: by 10.142.196.20 with SMTP id t20mr1662955wff.355.1313374485395; Sun, 14 Aug 2011 19:14:45 -0700 (PDT) Received: from mail-pz0-f45.google.com (mail-pz0-f45.google.com [209.85.210.45]) by mx.google.com with ESMTPS id r2si7801929pbp.119.2011.08.14.19.14.43 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 14 Aug 2011 19:14:44 -0700 (PDT) Received-SPF: neutral (google.com: 209.85.210.45 is neither permitted nor denied by best guess record for domain of shawn.guo@linaro.org) client-ip=209.85.210.45; Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.210.45 is neither permitted nor denied by best guess record for domain of shawn.guo@linaro.org) smtp.mail=shawn.guo@linaro.org Received: by pzk33 with SMTP id 33so3182270pzk.32 for ; Sun, 14 Aug 2011 19:14:43 -0700 (PDT) Received: by 10.142.180.3 with SMTP id c3mr1716021wff.211.1313374483125; Sun, 14 Aug 2011 19:14:43 -0700 (PDT) Received: from localhost.localdomain ([114.216.149.134]) by mx.google.com with ESMTPS id l10sm2840446pbl.62.2011.08.14.19.14.36 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 14 Aug 2011 19:14:42 -0700 (PDT) From: Shawn Guo To: linux-mmc@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Chris Ball , Stephen Rothwell , patches@linaro.org, Shawn Guo Subject: [PATCH] mmc: sdhci-esdhc-imx: add missing inclusion of linux/module.h Date: Mon, 15 Aug 2011 10:28:18 +0800 Message-Id: <1313375298-18546-1-git-send-email-shawn.guo@linaro.org> X-Mailer: git-send-email 1.7.4.1 MIME-Version: 1.0 There are following warning and error when compiling the driver. The patch adds the missing inclusion of linux/module.h to fix them. drivers/mmc/host/sdhci-esdhc-imx.c:87:1: warning: data definition has no type or storage class drivers/mmc/host/sdhci-esdhc-imx.c:87:1: warning: type defaults to ‘int’ in declaration of ‘MODULE_DEVICE_TABLE’ drivers/mmc/host/sdhci-esdhc-imx.c:87:1: warning: parameter names (without types) in function declaration drivers/mmc/host/sdhci-esdhc-imx.c:96:1: warning: data definition has no type or storage class drivers/mmc/host/sdhci-esdhc-imx.c:96:1: warning: type defaults to ‘int’ in declaration of ‘MODULE_DEVICE_TABLE’ drivers/mmc/host/sdhci-esdhc-imx.c:96:1: warning: parameter names (without types) in function declaration drivers/mmc/host/sdhci-esdhc-imx.c:563:12: error: ‘THIS_MODULE’ undeclared here (not in a function) drivers/mmc/host/sdhci-esdhc-imx.c:587:20: error: expected declaration specifiers or ‘...’ before string constant drivers/mmc/host/sdhci-esdhc-imx.c:587:1: warning: data definition has no type or storage class drivers/mmc/host/sdhci-esdhc-imx.c:587:1: warning: type defaults to ‘int’ in declaration of ‘MODULE_DESCRIPTION’ drivers/mmc/host/sdhci-esdhc-imx.c:587:20: warning: function declaration isn’t a prototype drivers/mmc/host/sdhci-esdhc-imx.c:588:15: error: expected declaration specifiers or ‘...’ before string constant drivers/mmc/host/sdhci-esdhc-imx.c:588:1: warning: data definition has no type or storage class drivers/mmc/host/sdhci-esdhc-imx.c:588:1: warning: type defaults to ‘int’ in declaration of ‘MODULE_AUTHOR’ drivers/mmc/host/sdhci-esdhc-imx.c:588:15: warning: function declaration isn’t a prototype drivers/mmc/host/sdhci-esdhc-imx.c:589:16: error: expected declaration specifiers or ‘...’ before string constant drivers/mmc/host/sdhci-esdhc-imx.c:589:1: warning: data definition has no type or storage class drivers/mmc/host/sdhci-esdhc-imx.c:589:1: warning: type defaults to ‘int’ in declaration of ‘MODULE_LICENSE’ drivers/mmc/host/sdhci-esdhc-imx.c:589:16: warning: function declaration isn’t a prototype Signed-off-by: Shawn Guo Cc: Chris Ball --- Hi Stephen, I spot this on linux-next-20110812. Regards, Shawn drivers/mmc/host/sdhci-esdhc-imx.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/mmc/host/sdhci-esdhc-imx.c b/drivers/mmc/host/sdhci-esdhc-imx.c index 2a1ba84..4557aa1 100644 --- a/drivers/mmc/host/sdhci-esdhc-imx.c +++ b/drivers/mmc/host/sdhci-esdhc-imx.c @@ -16,6 +16,7 @@ #include #include #include +#include #include #include #include