| Message ID | 20240830-atmel-sdhci-v3-0-7c97a0872af4@microchip.com |
|---|---|
| Headers | show |
| Series | Update sdhci-atmel dt-binding documentation | expand |
On Fri, Aug 30, 2024 at 08:21:20PM +0530, Dharma Balasubiramani wrote: > Convert sdhci-atmel documentation to yaml format. The new file will inherit > from sdhci-common.yaml. > > Note: Add microchip,sama7g5-sdhci to compatible list as we already use it > in the DT. > > Signed-off-by: Dharma Balasubiramani <dharma.b@microchip.com> > --- > .../bindings/mmc/atmel,sama5d2-sdhci.yaml | 90 ++++++++++++++++++++++ > .../devicetree/bindings/mmc/sdhci-atmel.txt | 35 --------- > 2 files changed, 90 insertions(+), 35 deletions(-) > > diff --git a/Documentation/devicetree/bindings/mmc/atmel,sama5d2-sdhci.yaml b/Documentation/devicetree/bindings/mmc/atmel,sama5d2-sdhci.yaml > new file mode 100644 > index 000000000000..ba4786328833 > --- /dev/null > +++ b/Documentation/devicetree/bindings/mmc/atmel,sama5d2-sdhci.yaml > @@ -0,0 +1,90 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/mmc/atmel,sama5d2-sdhci.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Atmel SDHCI controller > + > +maintainers: > + - Aubin Constans <aubin.constans@microchip.com> > + - Nicolas Ferre <nicolas.ferre@microchip.com> > + > +description: > + Bindings for the SDHCI controller found in Atmel/Microchip SoCs. > + > +properties: > + compatible: > + oneOf: > + - enum: > + - atmel,sama5d2-sdhci > + - atmel,sama5d3-sdhci This wasn't in the old binding. > + - atmel,sama5d4-sdhci Neither this. > + - microchip,sam9x60-sdhci > + - items: > + - enum: > + - microchip,sama7g5-sdhci > + - const: microchip,sam9x60-sdhci What happened with microchip,sam9x7-sdhci compatible from the old binding? And none of above changes are explained in commit msg. Best regards, Krzysztof
Hi Krzysztof, On 31/08/24 11:49 am, Krzysztof Kozlowski wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > On Fri, Aug 30, 2024 at 08:21:20PM +0530, Dharma Balasubiramani wrote: >> Convert sdhci-atmel documentation to yaml format. The new file will inherit >> from sdhci-common.yaml. >> >> Note: Add microchip,sama7g5-sdhci to compatible list as we already use it >> in the DT. >> >> Signed-off-by: Dharma Balasubiramani <dharma.b@microchip.com> >> --- >> .../bindings/mmc/atmel,sama5d2-sdhci.yaml | 90 ++++++++++++++++++++++ >> .../devicetree/bindings/mmc/sdhci-atmel.txt | 35 --------- >> 2 files changed, 90 insertions(+), 35 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/mmc/atmel,sama5d2-sdhci.yaml b/Documentation/devicetree/bindings/mmc/atmel,sama5d2-sdhci.yaml >> new file mode 100644 >> index 000000000000..ba4786328833 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/mmc/atmel,sama5d2-sdhci.yaml >> @@ -0,0 +1,90 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/mmc/atmel,sama5d2-sdhci.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Atmel SDHCI controller >> + >> +maintainers: >> + - Aubin Constans <aubin.constans@microchip.com> >> + - Nicolas Ferre <nicolas.ferre@microchip.com> >> + >> +description: >> + Bindings for the SDHCI controller found in Atmel/Microchip SoCs. >> + >> +properties: >> + compatible: >> + oneOf: >> + - enum: >> + - atmel,sama5d2-sdhci >> + - atmel,sama5d3-sdhci > > This wasn't in the old binding. > >> + - atmel,sama5d4-sdhci > > Neither this. My bad, I accidentally added those compatibles that are not present in the old binding or the DTS files. > >> + - microchip,sam9x60-sdhci >> + - items: >> + - enum: >> + - microchip,sama7g5-sdhci >> + - const: microchip,sam9x60-sdhci > > What happened with microchip,sam9x7-sdhci compatible from the old binding? > > And none of above changes are explained in commit msg. Since there are no users of microchip,sam9x7-sdhci compatible from the old binding I missed adding it during the conversion. I'll correct these issues and make the necessary adjustments (remove the "atmel,sama5d3-sdhci" and "atmel,sama5d4-sdhci" compatibles and add back the "microchip,sam9x7-sdhci" compatible) in the next revision of this patch series. Thanks. > > > > Best regards, > Krzysztof > >
This patch series converts the sdhci-atmel dt-binding to yaml format and adds the sama7d65,sama7g5 compatibles to the list. Signed-off-by: Dharma Balasubiramani <dharma.b@microchip.com> --- Changes in v3: - update the items in clocks instead of plain description. - move the items list to clock-names. - since baseclk is must, change maxitems to minitems: 3, and modify the conditional bits accordingly. - Link to v2: https://lore.kernel.org/r/20240830-atmel-sdhci-v2-0-b7f58973f3fc@microchip.com Changes in v2: - Add missing deleted file to the patch "Documentation/devicetree/bindings/mmc/sdhci-atmel.txt" - Link to v1: https://lore.kernel.org/r/20240830-atmel-sdhci-v1-0-01e3ec8c9804@microchip.com --- Dharma Balasubiramani (2): dt-bindings: mmc: sdhci-atmel: Convert to json schema dt-bindings: mmc: atmel,sama5d2-sdhci: Add sama7d65 compatible .../bindings/mmc/atmel,sama5d2-sdhci.yaml | 95 ++++++++++++++++++++++ .../devicetree/bindings/mmc/sdhci-atmel.txt | 35 -------- 2 files changed, 95 insertions(+), 35 deletions(-) --- base-commit: 4b7d983dd85a5cdf4938f4a0a93adedf697ac04d change-id: 20240830-atmel-sdhci-c9a92b710624 Best regards,