| Message ID | 20230415-mmc-hi3798mv200-v4-0-44096e187f53@outlook.com |
|---|---|
| Headers | show |
| Series | mmc: add support for the dw-mmc controller on Hi3798MV200 | expand |
On 16/04/2023 11:19, Yang Xiwen via B4 Relay wrote: > From: Yang Xiwen <forbidden405@outlook.com> > > Add Hi3798MV200 compatible string and an extra clock for it. > > Signed-off-by: Yang Xiwen <forbidden405@outlook.com> > --- > .../bindings/mmc/hisilicon,histb-dw-mshc.yaml | 26 +++++++++++++++++++++- > 1 file changed, 25 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/mmc/hisilicon,histb-dw-mshc.yaml b/Documentation/devicetree/bindings/mmc/hisilicon,histb-dw-mshc.yaml > index 301b6ad39c5af..2f8335fd2c965 100644 > --- a/Documentation/devicetree/bindings/mmc/hisilicon,histb-dw-mshc.yaml > +++ b/Documentation/devicetree/bindings/mmc/hisilicon,histb-dw-mshc.yaml > @@ -19,6 +19,7 @@ properties: > compatible: > enum: > - hisilicon,hi3798cv200-dw-mshc > + - hisilicon,hi3798mv200-dw-mshc > > reg: > maxItems: 1 > @@ -27,14 +28,16 @@ properties: > maxItems: 1 > > clocks: > - maxItems: 4 You miss now minItems. Are you sure you tested your bindings? This should fail. Anyway, wait with sending new versions of patches to give other people chance to review. It's already second patchset today. Best regards, Krzysztof
On 4/16/2023 7:16 PM, Krzysztof Kozlowski wrote: > On 16/04/2023 11:19, Yang Xiwen via B4 Relay wrote: >> From: Yang Xiwen <forbidden405@outlook.com> >> >> Add Hi3798MV200 compatible string and an extra clock for it. >> >> Signed-off-by: Yang Xiwen <forbidden405@outlook.com> >> --- >> .../bindings/mmc/hisilicon,histb-dw-mshc.yaml | 26 +++++++++++++++++++++- >> 1 file changed, 25 insertions(+), 1 deletion(-) >> >> diff --git a/Documentation/devicetree/bindings/mmc/hisilicon,histb-dw-mshc.yaml b/Documentation/devicetree/bindings/mmc/hisilicon,histb-dw-mshc.yaml >> index 301b6ad39c5af..2f8335fd2c965 100644 >> --- a/Documentation/devicetree/bindings/mmc/hisilicon,histb-dw-mshc.yaml >> +++ b/Documentation/devicetree/bindings/mmc/hisilicon,histb-dw-mshc.yaml >> @@ -19,6 +19,7 @@ properties: >> compatible: >> enum: >> - hisilicon,hi3798cv200-dw-mshc >> + - hisilicon,hi3798mv200-dw-mshc >> >> reg: >> maxItems: 1 >> @@ -27,14 +28,16 @@ properties: >> maxItems: 1 >> >> clocks: >> - maxItems: 4 > > You miss now minItems. Are you sure you tested your bindings? This > should fail. > > Anyway, wait with sending new versions of patches to give other people > chance to review. It's already second patchset today. > > Best regards, > Krzysztof > Sorry for that. I'll fix that in v5 and send the new patchset a few days later, waiting for others to review the driver.
On 4/16/2023 5:19 PM, Yang Xiwen via B4 Relay wrote: > The dw-mmc controller found on Hi3798MV200 is like the one found on > Hi3798CV200, but has some tweaks. > Also refreshed the dt-binding and converted it to YAML. > > Signed-off-by: Yang Xiwen <forbidden405@outlook.com> > --- > Changes in v4: > - fix license of dt-binding document. > - some other fixes to dt-binding document. > - Link to v3: https://lore.kernel.org/r/20230415-mmc-hi3798mv200-v3-0-00e2368c0709@outlook.com > > Changes in v3: > - split dt-binding commit into 2 parts, one for renaming, the other for > new compatible string. > - some other fixes to dt-binding document. > - Link to v2: https://lore.kernel.org/r/20230415-mmc-hi3798mv200-v2-0-1d274f9b71da@outlook.com > > Changes in v2: > - add DDR52 support > - edit dt-binding, substitude all hi3798cv200 with histb > - send email to more people > - Link to v1: https://lore.kernel.org/r/20230415-mmc-hi3798mv200-v1-0-db5b91d939d4@outlook.com > > --- > Yang Xiwen (4): > mmc: dw_mmc: hi3798cv200: rename to dw_mmc-histb > mmc: dw_mmc: histb: add support for hi3798mv200 > dt-binding: mmc: hi3798cv200-dw-mshc: convert to YAML and rename to histb-dw-mshc > dt-binding: mmc: histb-dw-mshc: Add Hi3798MV200 compatible string > > .../bindings/mmc/hi3798cv200-dw-mshc.txt | 40 --- > .../bindings/mmc/hisilicon,histb-dw-mshc.yaml | 93 ++++++ > drivers/mmc/host/Kconfig | 8 +- > drivers/mmc/host/Makefile | 2 +- > drivers/mmc/host/dw_mmc-hi3798cv200.c | 206 ------------- > drivers/mmc/host/dw_mmc-histb.c | 339 +++++++++++++++++++++ > 6 files changed, 437 insertions(+), 251 deletions(-) > --- > base-commit: 76f598ba7d8e2bfb4855b5298caedd5af0c374a8 > change-id: 20230415-mmc-hi3798mv200-ce15e9b96866 > > Best regards, Sorry for wasting your time, but please don't review this patchset anymore. I decided to rewrite it.
The dw-mmc controller found on Hi3798MV200 is like the one found on Hi3798CV200, but has some tweaks. Also refreshed the dt-binding and converted it to YAML. Signed-off-by: Yang Xiwen <forbidden405@outlook.com> --- Changes in v4: - fix license of dt-binding document. - some other fixes to dt-binding document. - Link to v3: https://lore.kernel.org/r/20230415-mmc-hi3798mv200-v3-0-00e2368c0709@outlook.com Changes in v3: - split dt-binding commit into 2 parts, one for renaming, the other for new compatible string. - some other fixes to dt-binding document. - Link to v2: https://lore.kernel.org/r/20230415-mmc-hi3798mv200-v2-0-1d274f9b71da@outlook.com Changes in v2: - add DDR52 support - edit dt-binding, substitude all hi3798cv200 with histb - send email to more people - Link to v1: https://lore.kernel.org/r/20230415-mmc-hi3798mv200-v1-0-db5b91d939d4@outlook.com --- Yang Xiwen (4): mmc: dw_mmc: hi3798cv200: rename to dw_mmc-histb mmc: dw_mmc: histb: add support for hi3798mv200 dt-binding: mmc: hi3798cv200-dw-mshc: convert to YAML and rename to histb-dw-mshc dt-binding: mmc: histb-dw-mshc: Add Hi3798MV200 compatible string .../bindings/mmc/hi3798cv200-dw-mshc.txt | 40 --- .../bindings/mmc/hisilicon,histb-dw-mshc.yaml | 93 ++++++ drivers/mmc/host/Kconfig | 8 +- drivers/mmc/host/Makefile | 2 +- drivers/mmc/host/dw_mmc-hi3798cv200.c | 206 ------------- drivers/mmc/host/dw_mmc-histb.c | 339 +++++++++++++++++++++ 6 files changed, 437 insertions(+), 251 deletions(-) --- base-commit: 76f598ba7d8e2bfb4855b5298caedd5af0c374a8 change-id: 20230415-mmc-hi3798mv200-ce15e9b96866 Best regards,