mbox series

[0/4] mmc: pwrseq: sd8787: add support for selectable

Message ID 20210806113001.821660-1-claudiu.beznea@microchip.com
Headers show
Series mmc: pwrseq: sd8787: add support for selectable | expand

Message

Claudiu Beznea Aug. 6, 2021, 11:29 a.m. UTC
Hi,

This series adds support for selecting the delay b/w reset and power
lines on pwrseq-sd8787. With this the driver could also be used by
other devices (e.g. WILC1000/WILC3000 which needs a delay of 5ms). Along
with this added the DT bindings for WILC3000 device present on
SAMA5D27 WLSOM1 board.

Thank you,
Claudiu Beznea

Claudiu Beznea (3):
  dt-bindings: mmc: pwrseq-sd8787: add binding for delay b/w reset and
    power
  mmc: pwrseq: sd8787: add support for specifying the delay b/w power
    and reset
  mmc: pwrseq: add wilc1000_sdio dependency for pwrseq_sd8787

Eugen Hristev (1):
  ARM: dts: at91: sama5d27_wlsom1: add wifi device

 .../bindings/mmc/mmc-pwrseq-sd8787.yaml       |  4 ++
 arch/arm/boot/dts/at91-sama5d27_wlsom1.dtsi   | 72 +++++++++++++++++++
 drivers/mmc/core/Kconfig                      |  2 +-
 drivers/mmc/core/pwrseq_sd8787.c              | 11 ++-
 4 files changed, 87 insertions(+), 2 deletions(-)

Comments

Claudiu Beznea Aug. 16, 2021, 6:46 a.m. UTC | #1
On 13.08.2021 23:23, Rob Herring wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe

> 

> On Fri, Aug 06, 2021 at 02:29:57PM +0300, Claudiu Beznea wrote:

>> Hi,

>>

>> This series adds support for selecting the delay b/w reset and power

>> lines on pwrseq-sd8787. With this the driver could also be used by

>> other devices (e.g. WILC1000/WILC3000 which needs a delay of 5ms). Along

>> with this added the DT bindings for WILC3000 device present on

>> SAMA5D27 WLSOM1 board.

> 

> A 300ms delay doesn't work?


It should work as the datasheet specifies a minimum of 5ms is necessary.

> Is powering on the device so timing

> critical?

> 

> Add a new compatible for your device and imply the timing from that.

> That way we're not extending the binding a property at a time in a

> poorly designed way for each new timing quirk.


OK, will do it in v2.

Thank you for your review,
Claudiu Beznea

> 

> Rob

>