From patchwork Fri Mar 20 16:11:42 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alex Riesen X-Patchwork-Id: 210511 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A578C4332D for ; Fri, 20 Mar 2020 16:17:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DDF8F20739 for ; Fri, 20 Mar 2020 16:17:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727148AbgCTQRZ (ORCPT ); Fri, 20 Mar 2020 12:17:25 -0400 Received: from mout.kundenserver.de ([212.227.17.10]:39465 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726935AbgCTQRZ (ORCPT ); Fri, 20 Mar 2020 12:17:25 -0400 Received: from mail.cetitecgmbh.com ([87.190.42.90]) by mrelayeu.kundenserver.de (mreue106 [212.227.15.183]) with ESMTPSA (Nemesis) id 1N2mS2-1jOyNC3IRo-013350 for ; Fri, 20 Mar 2020 17:17:22 +0100 Received: from pflvmailgateway.corp.cetitec.com (unknown [127.0.0.1]) by mail.cetitecgmbh.com (Postfix) with ESMTP id 9440064FA81 for ; Fri, 20 Mar 2020 16:17:22 +0000 (UTC) X-Virus-Scanned: amavisd-new at cetitec.com Received: from mail.cetitecgmbh.com ([127.0.0.1]) by pflvmailgateway.corp.cetitec.com (pflvmailgateway.corp.cetitec.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id s6FGqP_ixXsI for ; Fri, 20 Mar 2020 17:17:22 +0100 (CET) Received: from pfwsexchange.corp.cetitec.com (unknown [10.10.1.99]) by mail.cetitecgmbh.com (Postfix) with ESMTPS id 31EE064F8FB for ; Fri, 20 Mar 2020 17:17:22 +0100 (CET) Received: from pflmari.corp.cetitec.com (10.8.5.41) by PFWSEXCHANGE.corp.cetitec.com (10.10.1.99) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 20 Mar 2020 17:17:22 +0100 Received: by pflmari.corp.cetitec.com (Postfix, from userid 1000) id 0F67C804FD; Fri, 20 Mar 2020 17:11:42 +0100 (CET) Date: Fri, 20 Mar 2020 17:11:42 +0100 From: Alex Riesen To: Kieran Bingham CC: Geert Uytterhoeven , Mauro Carvalho Chehab , Hans Verkuil , "Laurent Pinchart" , Rob Herring , Mark Rutland , Kuninori Morimoto , , , , , Subject: [PATCH v3 01/11] media: adv748x: fix end-of-line terminators in diagnostic statements Message-ID: Mail-Followup-To: Alex Riesen , Kieran Bingham , Geert Uytterhoeven , Mauro Carvalho Chehab , Hans Verkuil , Laurent Pinchart , Rob Herring , Mark Rutland , Kuninori Morimoto , devel@driverdev.osuosl.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-renesas-soc@vger.kernel.org References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Originating-IP: [10.8.5.41] X-ClientProxiedBy: PFWSEXCHANGE.corp.cetitec.com (10.10.1.99) To PFWSEXCHANGE.corp.cetitec.com (10.10.1.99) X-EsetResult: clean, is OK X-EsetId: 37303A290D7F536A6D7662 X-Provags-ID: V03:K1:Ywxajj3nfNV5QSyw0jIFmjLVJEp92D5NnhhhSeCCxKt9pv2l9Cn eK0gRfsEAyEj2VCCPROWKywYuOvVPIzRTnE/D27Trlctptb5dcyCuMl8cZKr7EB1QTmyvjd 4ilxnAC47gDLNj/mn4qrOSoLpJ1mH7C4oZ1utO0RqE1irDwLgOScXLw1ebWPie5esaU8hN7 3Y9N9jY8sopY29Vo0SHgQ== X-UI-Out-Filterresults: notjunk:1; V03:K0:nT3heB0CeT8=:ylF2Ct9TdgSdlKNmSHweve mSPh54rt0XlNTLsXrgp4ME8pjaOZdLw2QLCZ6XAzktVXW3DzvEheHKNuXMhp04wafb+TjEYmN GxemHBgxOEjOVT3upIc1UTnPyGwmLE7FWhhK+A+XNYGFRxrzAnAeCy7pKjGH58mgASE+1Ex1X m+kDUkSPfNGyM4vk3xSi2gBr+rN9DZTJoe8LaeD9jT6MEh/YINbBdxQreOvdr9+ZIs6gUhU0b H256FHg7phTSvm/PV0JK/ob5Xkys+/T6Stz9n3RITwWAwReoEPW3JBWsCNsz6zw5ks/pdaaIs oaXS+2CTuCcj3onhTaKLOgp8qp7cISXqhLKl+Nb9vMigUbdVW3OqJZyoMN1hHGb5Z8OdTOncs JfbGhZDZDcKX9RWyH4rBN8/6cyccPKldLjacGCMSqFm+goBQ8TfzDPEv4otvfU1Y805VDDZbr ITEroO3PAAaa8iAGc+zj3K4gSIeVp55B4HdSqfVv0qpR5R2ixZ4ueWP30z1OIhZbwkCYDsd+G D/dwSnt0/01q5YdABNXmkWerR5JUH2K0Oo8EW09zg7Uq3fq3MwP06Rq6nP+5g2vMx2+zmapsj GPjWyZGxTqrjtOGfjKtMWwSw5wQ4b8z6WpVy7gx+4/q79wVTvfABlkXOt23wh5j0rZT520XxE 3f2pZqfsq0Aone7u9I05kOBo+4DxhShGewW5PByzyTZTqU3r4ZW5CeWnDocV3xZpZY+19K4LR nFYaFqunSzesFJg7joX0wxfXEMEQCp3eJQgv0lgLhMIT8wqnKpN3j5BIsNO7+5D0ZnC+fx1sz D/iN212gvSPUh9n/39KAGhI28PRLkN42AQx/3OxQvNVM9Zat6+/wORu6TMAS1xIw80Vik3x Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Signed-off-by: Alexander Riesen Reviewed-by: Laurent Pinchart --- drivers/media/i2c/adv748x/adv748x-core.c | 24 ++++++++++++------------ drivers/media/i2c/adv748x/adv748x-csi2.c | 2 +- 2 files changed, 13 insertions(+), 13 deletions(-) diff --git a/drivers/media/i2c/adv748x/adv748x-core.c b/drivers/media/i2c/adv748x/adv748x-core.c index 23e02ff27b17..c3fb113cef62 100644 --- a/drivers/media/i2c/adv748x/adv748x-core.c +++ b/drivers/media/i2c/adv748x/adv748x-core.c @@ -623,11 +623,11 @@ static int adv748x_parse_dt(struct adv748x_state *state) for_each_endpoint_of_node(state->dev->of_node, ep_np) { of_graph_parse_endpoint(ep_np, &ep); - adv_info(state, "Endpoint %pOF on port %d", ep.local_node, + adv_info(state, "Endpoint %pOF on port %d\n", ep.local_node, ep.port); if (ep.port >= ADV748X_PORT_MAX) { - adv_err(state, "Invalid endpoint %pOF on port %d", + adv_err(state, "Invalid endpoint %pOF on port %d\n", ep.local_node, ep.port); continue; @@ -635,7 +635,7 @@ static int adv748x_parse_dt(struct adv748x_state *state) if (state->endpoints[ep.port]) { adv_err(state, - "Multiple port endpoints are not supported"); + "Multiple port endpoints are not supported\n"); continue; } @@ -702,62 +702,62 @@ static int adv748x_probe(struct i2c_client *client) /* Discover and process ports declared by the Device tree endpoints */ ret = adv748x_parse_dt(state); if (ret) { - adv_err(state, "Failed to parse device tree"); + adv_err(state, "Failed to parse device tree\n"); goto err_free_mutex; } /* Configure IO Regmap region */ ret = adv748x_configure_regmap(state, ADV748X_PAGE_IO); if (ret) { - adv_err(state, "Error configuring IO regmap region"); + adv_err(state, "Error configuring IO regmap region\n"); goto err_cleanup_dt; } ret = adv748x_identify_chip(state); if (ret) { - adv_err(state, "Failed to identify chip"); + adv_err(state, "Failed to identify chip\n"); goto err_cleanup_dt; } /* Configure remaining pages as I2C clients with regmap access */ ret = adv748x_initialise_clients(state); if (ret) { - adv_err(state, "Failed to setup client regmap pages"); + adv_err(state, "Failed to setup client regmap pages\n"); goto err_cleanup_clients; } /* SW reset ADV748X to its default values */ ret = adv748x_reset(state); if (ret) { - adv_err(state, "Failed to reset hardware"); + adv_err(state, "Failed to reset hardware\n"); goto err_cleanup_clients; } /* Initialise HDMI */ ret = adv748x_hdmi_init(&state->hdmi); if (ret) { - adv_err(state, "Failed to probe HDMI"); + adv_err(state, "Failed to probe HDMI\n"); goto err_cleanup_clients; } /* Initialise AFE */ ret = adv748x_afe_init(&state->afe); if (ret) { - adv_err(state, "Failed to probe AFE"); + adv_err(state, "Failed to probe AFE\n"); goto err_cleanup_hdmi; } /* Initialise TXA */ ret = adv748x_csi2_init(state, &state->txa); if (ret) { - adv_err(state, "Failed to probe TXA"); + adv_err(state, "Failed to probe TXA\n"); goto err_cleanup_afe; } /* Initialise TXB */ ret = adv748x_csi2_init(state, &state->txb); if (ret) { - adv_err(state, "Failed to probe TXB"); + adv_err(state, "Failed to probe TXB\n"); goto err_cleanup_txa; } diff --git a/drivers/media/i2c/adv748x/adv748x-csi2.c b/drivers/media/i2c/adv748x/adv748x-csi2.c index 2091cda50935..c43ce5d78723 100644 --- a/drivers/media/i2c/adv748x/adv748x-csi2.c +++ b/drivers/media/i2c/adv748x/adv748x-csi2.c @@ -72,7 +72,7 @@ static int adv748x_csi2_registered(struct v4l2_subdev *sd) struct adv748x_state *state = tx->state; int ret; - adv_dbg(state, "Registered %s (%s)", is_txa(tx) ? "TXA":"TXB", + adv_dbg(state, "Registered %s (%s)\n", is_txa(tx) ? "TXA":"TXB", sd->name); /*