From patchwork Wed Aug 30 20:34:51 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christophe JAILLET X-Patchwork-Id: 718892 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5EA1C83F15 for ; Wed, 30 Aug 2023 21:12:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240844AbjH3VMG (ORCPT ); Wed, 30 Aug 2023 17:12:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33910 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240865AbjH3VMF (ORCPT ); Wed, 30 Aug 2023 17:12:05 -0400 Received: from smtp.smtpout.orange.fr (smtp-27.smtpout.orange.fr [80.12.242.27]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 051A3CE7 for ; Wed, 30 Aug 2023 14:11:28 -0700 (PDT) Received: from pop-os.home ([86.243.2.178]) by smtp.orange.fr with ESMTPA id bRtwq9Cq9LJHlbRtxqZvkj; Wed, 30 Aug 2023 22:34:59 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=wanadoo.fr; s=t20230301; t=1693427699; bh=ukX6nIzTyaosUbrTkIXJsNBtFe8mTALHzfMVVvM42bc=; h=From:To:Cc:Subject:Date; b=tU2kvuBiW/eMCF/tn/6aangRq7DihAInl+uRWuVrVN6dJggGpARY3DvpgCM+yCtwC vba8qjDthJoeGKkNKxh2tlEhFKVIaUzW0irEWjA8IVUcbY7Ln89PQxzCpc/nfLmjBf uHcaOo78+807a8dM9rj7uHizW915ThG0BjY1bGnjpU4V6mOxJX514C92zu58N/tQY9 EqXgPtDLws83Lku51aBt9/uwLU4/RSxBLH7E2YeSL1ZSbjQ6p+hCYPVEcqsX5XICmS 5SPxqwmXJ0kKeMDrGHrYbBwlGWn428Ekau1G7pcupynJVG938rH9aweYLbIhmLfUP2 eqH7LVw/cOn3g== X-ME-Helo: pop-os.home X-ME-Auth: Y2hyaXN0b3BoZS5qYWlsbGV0QHdhbmFkb28uZnI= X-ME-Date: Wed, 30 Aug 2023 22:34:59 +0200 X-ME-IP: 86.243.2.178 From: Christophe JAILLET To: Jacopo Mondi , Kieran Bingham , Laurent Pinchart , =?utf-8?q?Nik?= =?utf-8?q?las_S=C3=B6derlund?= , Mauro Carvalho Chehab , Sakari Ailus Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Christophe JAILLET , Jacopo Mondi , linux-media@vger.kernel.org Subject: [PATCH v2] media: i2c: rdacm21: Remove an incorrect fwnode_handle_put() call Date: Wed, 30 Aug 2023 22:34:51 +0200 Message-Id: X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org The commit in Fixes has removed an fwnode_handle_put() call in the error handling path of the probe. Remove the same call from the remove function. Fixes: 1029939b3782 ("media: v4l: async: Simplify async sub-device fwnode matching") Signed-off-by: Christophe JAILLET Reviewed-by: Jacopo Mondi Reviewed-by: Laurent Pinchart --- v2: s/rdacm2/rdacm21/ in the subject [Laurent Pinchart] Add R-b tags v1: https://lore.kernel.org/all/d9230082aefcb7bab6363c51c08598eb5ab62cfc.1693037086.git.christophe.jaillet@wanadoo.fr/ --- drivers/media/i2c/rdacm21.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/media/i2c/rdacm21.c b/drivers/media/i2c/rdacm21.c index a36a709243fd..3e22df36354f 100644 --- a/drivers/media/i2c/rdacm21.c +++ b/drivers/media/i2c/rdacm21.c @@ -608,7 +608,6 @@ static void rdacm21_remove(struct i2c_client *client) v4l2_async_unregister_subdev(&dev->sd); v4l2_ctrl_handler_free(&dev->ctrls); i2c_unregister_device(dev->isp); - fwnode_handle_put(dev->sd.fwnode); } static const struct of_device_id rdacm21_of_ids[] = {