From patchwork Thu May 6 15:22:57 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mauro Carvalho Chehab X-Patchwork-Id: 432366 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01622C433ED for ; Thu, 6 May 2021 15:23:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B15A26109E for ; Thu, 6 May 2021 15:23:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235189AbhEFPY3 (ORCPT ); Thu, 6 May 2021 11:24:29 -0400 Received: from mail.kernel.org ([198.145.29.99]:37940 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235063AbhEFPY2 (ORCPT ); Thu, 6 May 2021 11:24:28 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 29E83610C8; Thu, 6 May 2021 15:23:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1620314610; bh=88Q2GGxTdA6m8Rsuuzf1i/TAz4J4CJAtybbFo3TSOco=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=rX8XPqzS9ObsqJaPbrNX5iV1hxAmS8nPVdCIboWyo3eogd4cfA81zk3BXQgMrjXTF 3J9I11YIasoRCkSG8+KWP4nNwFloVjGG0O2L+bxIbnR1A1Ocyd0y/8+X60XvXOJQWM McZQi9Znj+zRMmqgLlwoH+Wt5C2/a/xd1HjwI2xwwUz0zqMtvlPnokW8+gWXfxwIey pa4RUxdiZfhBCWY5LCRF2IxRRrw3xAzPXsk9Bcous9WNTxDhgzo7Xsw2h4Xsvrggg+ 5mdEjvFdK1oYTOLyVM7dY6ZbU6EeYslc7AFKQhci2TKgBs8FJfkeYaKpPmucUkQXS7 ALHa0G33iY4Pw== Received: by mail.kernel.org with local (Exim 4.94.2) (envelope-from ) id 1lefqa-000RuY-0J; Thu, 06 May 2021 17:23:28 +0200 From: Mauro Carvalho Chehab Cc: linuxarm@huawei.com, mauro.chehab@huawei.com, Mauro Carvalho Chehab , Mauro Carvalho Chehab , Tianshu Qiu , linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, Jonathan Cameron Subject: [PATCH v5 01/30] media: i2c: ak7375: use pm_runtime_resume_and_get() Date: Thu, 6 May 2021 17:22:57 +0200 Message-Id: X-Mailer: git-send-email 2.30.2 In-Reply-To: References: MIME-Version: 1.0 Sender: Mauro Carvalho Chehab To: unlisted-recipients:; (no To-header on input) Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Commit dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get to deal with usage counter") added pm_runtime_resume_and_get() in order to automatically handle dev->power.usage_count decrement on errors. Use the new API, in order to cleanup the error check logic. Reviewed-by: Jonathan Cameron Signed-off-by: Mauro Carvalho Chehab --- drivers/media/i2c/ak7375.c | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/drivers/media/i2c/ak7375.c b/drivers/media/i2c/ak7375.c index e1f94ee0f48f..40b1a4aa846c 100644 --- a/drivers/media/i2c/ak7375.c +++ b/drivers/media/i2c/ak7375.c @@ -87,15 +87,7 @@ static const struct v4l2_ctrl_ops ak7375_vcm_ctrl_ops = { static int ak7375_open(struct v4l2_subdev *sd, struct v4l2_subdev_fh *fh) { - int ret; - - ret = pm_runtime_get_sync(sd->dev); - if (ret < 0) { - pm_runtime_put_noidle(sd->dev); - return ret; - } - - return 0; + return pm_runtime_resume_and_get(sd->dev); } static int ak7375_close(struct v4l2_subdev *sd, struct v4l2_subdev_fh *fh)