From patchwork Mon Feb 24 22:35:54 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ian Kumlien X-Patchwork-Id: 210812 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9E23C38BFA for ; Mon, 24 Feb 2020 22:36:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B1EEF21744 for ; Mon, 24 Feb 2020 22:36:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="evcJnC3a" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727520AbgBXWgH (ORCPT ); Mon, 24 Feb 2020 17:36:07 -0500 Received: from mail-qk1-f195.google.com ([209.85.222.195]:41918 "EHLO mail-qk1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726651AbgBXWgH (ORCPT ); Mon, 24 Feb 2020 17:36:07 -0500 Received: by mail-qk1-f195.google.com with SMTP id b5so3088951qkh.8 for ; Mon, 24 Feb 2020 14:36:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to:cc; bh=YGKm8j6kzzt6cj98Y900BzukBQh2ZQfkDcKpSbnNfog=; b=evcJnC3ag9p6y+Xz5p+Cv9ekOjfXjMu58P8lEjfd/aqg5d+JiDAxNPHYJuAJsIhR9Q jG7glm7cAny457yzoqiywGAsVbMyaC6M3WshrGZRr5dnNCSZAEabQ0I019STtNcEnmWp 653fhc3kH4JSwokFE87H9RSwK7/28svEVwuKcTgoaJtay1EEAMLi5r0IUKBOFrASzTAu jAONdlFoNuZgeRqK8dJcCSY0amSgiOVK8HcxLf8OiYb1um4QSCnIrfvW38sDD5LfLAN5 hXrCoxvh2ZGG6w0bdTuKcxsEWeFihf2FXz+OyWDeALZbteDQF6WmPe9z1QCLtG5fm5Mt s6JA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to:cc; bh=YGKm8j6kzzt6cj98Y900BzukBQh2ZQfkDcKpSbnNfog=; b=UcA0MF5JznRURUCmKWHj7XLLeGhl+vc4zfORjuyQLVdNE5mjXioFTmQU8ZwatJUp3L 993bKwT9shlnI86Lp5cx4MC7PvVMyjjYEqksKej1kZNyyLHuFnTpE189piu5vEtZD9KO Ii5rtDmICJAvWic2vDyOo1mSjGiruzcrjVZTBedZKy6KD7MPHReo9fdQA8dP8qxQz+t6 4ysWMs6Mrzh/ZODpa2EF70cIY6yPoI/xGyg+nSygygMD/9ZLMajRQgi/h+cLzH0HJJg0 X8GV1kubWyDNgjk/GhajxkpIkBL+hxBG7qucbrFaZt4QnpctnBaGuTHnxoxGwCeIIjlG BKoQ== X-Gm-Message-State: APjAAAWTOYJQlKhYibMj197E6CwQWsoNPN+tSH1virnZ5th91a+Cf/Do Aw0VUbVLQgr73uJTxEtz/WfPFIg/PXzYe3HA0Z0= X-Google-Smtp-Source: APXvYqwsFXwvlH/3ktG99jExMqFeGLQWK4HTYnvIbwmY5PjFGF/S66tCR+f0+LSq8g/F7BFRPhvisHs2BnopProEyDk= X-Received: by 2002:a05:620a:1458:: with SMTP id i24mr11375372qkl.435.1582583765623; Mon, 24 Feb 2020 14:36:05 -0800 (PST) MIME-Version: 1.0 From: Ian Kumlien Date: Mon, 24 Feb 2020 23:35:54 +0100 Message-ID: Subject: [RFC] Buildfailure due to mising "select REGMAP_I2C" To: hverkuil-cisco@xs4all.nl, petrcvekcz@gmail.com, sakari.ailus@linux.intel.com, Ricardo Ribalda Delgado , leonl@leopardimaging.com Cc: linux-media@vger.kernel.org Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Hi, I got surprised by: ld: drivers/media/i2c/tvp5150.o: in function `tvp5150_probe': tvp5150.c:(.text+0x11ac): undefined reference to `__devm_regmap_init_i2c' make: *** [Makefile:1078: vmlinux] Error 1 When going from 5.5.2 -> 5.5.6 A quick git grep shows that something like this might be needed, but it should be verified. I'm really uncertain about the ones that say REGMAP_SCCB... diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig index c68e002d26ea..fc40c111f461 100644 --- a/drivers/media/i2c/Kconfig +++ b/drivers/media/i2c/Kconfig @@ -238,6 +238,7 @@ config VIDEO_ADV7604 tristate "Analog Devices ADV7604 decoder" depends on VIDEO_V4L2 && I2C && VIDEO_V4L2_SUBDEV_API depends on GPIOLIB || COMPILE_TEST + select REGMAP_I2C select HDMI select V4L2_FWNODE help @@ -379,6 +380,7 @@ config VIDEO_TVP5150 tristate "Texas Instruments TVP5150 video decoder" depends on VIDEO_V4L2 && I2C select V4L2_FWNODE + select REGMAP_I2C help Support for the Texas Instruments TVP5150 video decoder. @@ -584,6 +586,7 @@ config VIDEO_IMX214 tristate "Sony IMX214 sensor support" depends on GPIOLIB && I2C && VIDEO_V4L2 && VIDEO_V4L2_SUBDEV_API depends on V4L2_FWNODE + select REGMAP_I2C help This is a Video4Linux2 sensor driver for the Sony IMX214 camera. @@ -612,6 +615,7 @@ config VIDEO_IMX274 config VIDEO_IMX290 tristate "Sony IMX290 sensor support" depends on I2C && VIDEO_V4L2 && VIDEO_V4L2_SUBDEV_API + select REGMAP_I2C select V4L2_FWNODE help This is a Video4Linux2 sensor driver for the Sony @@ -774,6 +778,7 @@ config VIDEO_OV7251 config VIDEO_OV772X tristate "OmniVision OV772x sensor support" depends on I2C && VIDEO_V4L2 + select REGMAP_I2C select REGMAP_SCCB help This is a Video4Linux2 sensor driver for the OmniVision @@ -804,6 +809,7 @@ config VIDEO_OV7670 config VIDEO_OV7740 tristate "OmniVision OV7740 sensor support" depends on I2C && VIDEO_V4L2 + select REGMAP_I2C help This is a Video4Linux2 sensor driver for the OmniVision OV7740 VGA camera sensor. @@ -829,6 +835,7 @@ config VIDEO_OV9640 config VIDEO_OV9650 tristate "OmniVision OV9650/OV9652 sensor support" depends on I2C && VIDEO_V4L2 && VIDEO_V4L2_SUBDEV_API + select REGMAP_I2C select REGMAP_SCCB help This is a V4L2 sensor driver for the Omnivision