diff mbox series

[096/141] media: rcar_jpu: Fix fall-through warnings for Clang

Message ID 55b0dd100f6c2799e0250ce479291fceb40bb462.1605896060.git.gustavoars@kernel.org
State Accepted
Commit bbcab30420f41288250aed8eea9d0cc059a6307d
Headers show
Series Fix fall-through warnings for Clang | expand

Commit Message

Gustavo A. R. Silva Nov. 20, 2020, 6:37 p.m. UTC
In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning
by explicitly adding a break statement instead of letting the code fall
through to the next case.

Link: https://github.com/KSPP/linux/issues/115
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
---
 drivers/media/platform/rcar_jpu.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Mauro Carvalho Chehab Nov. 22, 2020, 4:33 p.m. UTC | #1
Em Fri, 20 Nov 2020 12:37:02 -0600
"Gustavo A. R. Silva" <gustavoars@kernel.org> escreveu:

> In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning

> by explicitly adding a break statement instead of letting the code fall

> through to the next case.

> 

> Link: https://github.com/KSPP/linux/issues/115

> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>


Reviewed-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>


> ---

>  drivers/media/platform/rcar_jpu.c | 1 +

>  1 file changed, 1 insertion(+)

> 

> diff --git a/drivers/media/platform/rcar_jpu.c b/drivers/media/platform/rcar_jpu.c

> index 9b99ff368698..87466edf8a5e 100644

> --- a/drivers/media/platform/rcar_jpu.c

> +++ b/drivers/media/platform/rcar_jpu.c

> @@ -648,6 +648,7 @@ static u8 jpu_parse_hdr(void *buffer, unsigned long size, unsigned int *width,

>  			if (get_word_be(&jpeg_buffer, &word))

>  				return 0;

>  			skip(&jpeg_buffer, (long)word - 2);

> +			break;

>  		case 0:

>  			break;

>  		default:




Thanks,
Mauro
diff mbox series

Patch

diff --git a/drivers/media/platform/rcar_jpu.c b/drivers/media/platform/rcar_jpu.c
index 9b99ff368698..87466edf8a5e 100644
--- a/drivers/media/platform/rcar_jpu.c
+++ b/drivers/media/platform/rcar_jpu.c
@@ -648,6 +648,7 @@  static u8 jpu_parse_hdr(void *buffer, unsigned long size, unsigned int *width,
 			if (get_word_be(&jpeg_buffer, &word))
 				return 0;
 			skip(&jpeg_buffer, (long)word - 2);
+			break;
 		case 0:
 			break;
 		default: