| Message ID | 20250423-media-rpi-hevc-dec-v3-3-8fd3fad1d6fb@raspberrypi.com |
|---|---|
| State | New |
| Headers | show |
| Series | Raspberry Pi HEVC decoder driver | expand |
On Wed, Apr 23, 2025 at 06:20:20PM GMT, Dave Stevenson wrote: > Adds a binding for the HEVC decoder found on th +maintainers: > + - John Cox <john.cox@raspberrypi.com> > + - Dom Cobley <dom@raspberrypi.com> > + - Dave Stevenson <dave.stevenson@raspberrypi.com> > + - Raspberry Pi internal review list <kernel-list@raspberrypi.com> Drop, no mailing lists in bindings maintainers. These must be people. > + > +description: > + The Raspberry Pi HEVC decoder is a hardware video decode accelerator block > + found in the BCM2711 and BCM2712 processors used on Raspberry Pi 4 and 5 > + boards respectively. > + > +properties: > + compatible: > + items: > + - enum: > + - brcm,bcm2711-hevc-dec > + - brcm,bcm2712-hevc-dec > + - const: raspberrypi,hevc-dec Not what Rob asked. You should use specific SoC compatible as fallback. You referred to file "raspberrypi,pisbe.yaml" before, but there is no such file in the next. Before you reply that there is a binding using different rules: well, there is always poor code. Above two comments are repeated, especially this about specific compatible - all the time, so these are not new rules. These are given in reviews since some years. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/media/raspberrypi,hevc-dec.yaml b/Documentation/devicetree/bindings/media/raspberrypi,hevc-dec.yaml new file mode 100644 index 000000000000..b86534f2689f --- /dev/null +++ b/Documentation/devicetree/bindings/media/raspberrypi,hevc-dec.yaml @@ -0,0 +1,70 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/media/raspberrypi,hevc-dec.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Raspberry Pi HEVC Decoder + +maintainers: + - John Cox <john.cox@raspberrypi.com> + - Dom Cobley <dom@raspberrypi.com> + - Dave Stevenson <dave.stevenson@raspberrypi.com> + - Raspberry Pi internal review list <kernel-list@raspberrypi.com> + +description: + The Raspberry Pi HEVC decoder is a hardware video decode accelerator block + found in the BCM2711 and BCM2712 processors used on Raspberry Pi 4 and 5 + boards respectively. + +properties: + compatible: + items: + - enum: + - brcm,bcm2711-hevc-dec + - brcm,bcm2712-hevc-dec + - const: raspberrypi,hevc-dec + + reg: + items: + - description: The HEVC main register region + - description: The Interrupt control register region + + reg-names: + items: + - const: hevc + - const: intc + + interrupts: + maxItems: 1 + + clocks: + items: + - description: The HEVC block clock + +required: + - compatible + - reg + - reg-names + - interrupts + - clocks + +additionalProperties: false + +examples: + - | + #include <dt-bindings/interrupt-controller/arm-gic.h> + + video-codec@7eb10000 { + compatible = "brcm,bcm2711-hevc-dec", "raspberrypi,hevc-dec"; + reg = <0x7eb00000 0x10000>, /* HEVC */ + <0x7eb10000 0x1000>; /* INTC */ + reg-names = "hevc", + "intc"; + + interrupts = <GIC_SPI 98 IRQ_TYPE_LEVEL_HIGH>; + + clocks = <&clk 0>; + }; + +...
Adds a binding for the HEVC decoder found on the BCM2711 / Raspberry Pi 4, and BCM2712 / Raspberry Pi 5. Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com> --- .../bindings/media/raspberrypi,hevc-dec.yaml | 70 ++++++++++++++++++++++ 1 file changed, 70 insertions(+)