From patchwork Fri Jan 31 21:33:55 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Li X-Patchwork-Id: 861129 Received: from DU2PR03CU002.outbound.protection.outlook.com (mail-northeuropeazon11012007.outbound.protection.outlook.com [52.101.66.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9B8AF1F63FE; Fri, 31 Jan 2025 21:35:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.66.7 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738359303; cv=fail; b=RRGYwswrWqAuQaA7ueX2oHgeIAIhw95YI6geTZ+dMdJubWIggkdJq8nCfbBtUblHz7Oae9SF8vUmeszdq11icrJ3QP5NCOTU0FhS0H4Ngr3X6xjJYicXV0Sqzqe+7ih/8F+oeulFt9wAi+K5/00yAvDU4HpedIfVHhKnYy1ARPw= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738359303; c=relaxed/simple; bh=1oLpwAyrYNf6Ig/blWTgvYhrlicXZ0tTYOH1sW3sX70=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=Q4ijiDqaMPndGoKEwpQGtZnXWoofba5Hyog5us7UluotWqOLtr2sVpa3q1eo896dnFQgws1uY1ddk8L4talNt/vvmH7rHqOhNh8bM1FV/uZa//h+XYmLrfe8lx+oKNW7Nsv8hK8246M1er+G+QZrzssPOpX+HDjtF1jhEaCQ7ZU= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=kq0Y2c5k; arc=fail smtp.client-ip=52.101.66.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="kq0Y2c5k" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=iE4mNMfqVa50kRh2h0+9edgHYPadvYemjnjDUaQwl/JudWB+q9M3jtC25AF0z2T7TZR1MStW9r08rW+2fAMo8ke8ERBMIk95F69CM1TE/iUkfPCUYJE9ZtNd4JRvkTptkIYfzwU0nEQYwWAq3tcbfjqPjj0a2CI0mBk78KBOdiwjdL/G63GfYugPXd+sIypDH6jhxwNSCcoFQoaAEboS6Et+QiRzWkdU9AhuZcFcXZlzyKbsakKj83k+haK7wNuDkTTsaxEjr96enQrCnCXsKdi/LapEb0RM7s6QvdB18fjtBXCEpubxgH07xWh9Xx5RBTa9Y+bM9KTRa3iRqmoU/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=y2VwGfFdXjpracPZASbDZNkCa9YmcKdmrQin11NIj+I=; b=ynXC2K9yu8Olpx0u3ANunpj/u9hyndIn6+JOzjCFEbCiPr2VFqn4sSEikwESjADSiV3NlDlj+UQ9wc4cegcBqtk4MBbqBd+QMyNAHhBnnqXREtnkLJqyAFx1xIM2S8jvnyT6zjApxXTwgfJ4OwBcRdog/RcPD3kuv9GaS1R7jEBG7h3rbcxcQl+X1SflxNHFWcss5JkNw5S9OImL4wJ7qUsvdKJx+nb46XkuNpLyWUH25WpgmVfLa6KtGL7o90LqjV1xN2/ODoEW89cVS5B+J4nxdWmXdRfW5o5Ci1xmtxyvkys0LUO8QIulGglhW7jp1128x6f5EZh35pl3PKdTIA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=y2VwGfFdXjpracPZASbDZNkCa9YmcKdmrQin11NIj+I=; b=kq0Y2c5kGHxcn/Eowx/mYzRFJLPLTFQGXbnkdOT0/o4aFpkqdPVDjA0rQVObvPSH6306sdlKoEysjaCKz4rNpqCLFTIoV/6teGeu4ON8zuhj72zvyojOrqdH2dWVNeSmtZ8/jT7+0NR+KoE0p+yPAUWau2S5XQ5bG673I+E1fEx9ki9ve67byjQIkVejFXGZXxGQB0ThWdgMFhsNBzjP61hwig6oMMj31v5qRgfX3zEeYDso2qVxV9VI+baIns2ZewGFlbmVgEkhEd5YNUDu/co2nt+wAoadOgrMLgP8ICrKRHWl2Bz8TUsqf/PcfPPEtlKE+QuvbXNPXxEGloFm6Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) by VI2PR04MB10980.eurprd04.prod.outlook.com (2603:10a6:800:274::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8377.22; Fri, 31 Jan 2025 21:34:59 +0000 Received: from PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06]) by PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06%6]) with mapi id 15.20.8398.018; Fri, 31 Jan 2025 21:34:59 +0000 From: Frank Li Date: Fri, 31 Jan 2025 16:33:55 -0500 Subject: [PATCH 10/14] media: imx8mq-mipi-csi2: Add support for i.MX8QM Message-Id: <20250131-8qxp_camera-v1-10-319402ab606a@nxp.com> References: <20250131-8qxp_camera-v1-0-319402ab606a@nxp.com> In-Reply-To: <20250131-8qxp_camera-v1-0-319402ab606a@nxp.com> To: Vinod Koul , Kishon Vijay Abraham I , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Philipp Zabel , Laurent Pinchart , Mauro Carvalho Chehab , Rui Miguel Silva , Martin Kepplinger , Purism Kernel Team Cc: linux-phy@lists.infradead.org, devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, "Guoniu.zhou" , Robby Cai , Robert Chiras , Frank Li X-Mailer: b4 0.13-dev-e586c X-Developer-Signature: v=1; a=ed25519-sha256; t=1738359234; l=3213; i=Frank.Li@nxp.com; s=20240130; h=from:subject:message-id; bh=1oLpwAyrYNf6Ig/blWTgvYhrlicXZ0tTYOH1sW3sX70=; b=2oKEwVa0aL78BBv7CBxujsD+7GzrfomFN/iovpE26hG8HGvSkETKTgyIfGiDGIPXEtAzRgE+d /bsrx/ZkJEvDM4IQPYeAdz+SNim4Vc1qHmv5xA0gz1ngmUaC+M8H1jm X-Developer-Key: i=Frank.Li@nxp.com; a=ed25519; pk=I0L1sDUfPxpAkRvPKy7MdauTuSENRq+DnA+G4qcS94Q= X-ClientProxiedBy: BY5PR04CA0007.namprd04.prod.outlook.com (2603:10b6:a03:1d0::17) To PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB9642:EE_|VI2PR04MB10980:EE_ X-MS-Office365-Filtering-Correlation-Id: eb9d7df9-b9fe-4f98-d97d-08dd423f1cee X-LD-Processed: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|376014|52116014|7416014|366016|1800799024|921020|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?q?gEHql5F221Gsvi6MVQNDml2W6OePP4E?= =?utf-8?q?1eXsbJSc9F1z2hb1yHVaC6XyFMVVjE2rqWn+CLv6Ui+PGKI/LyjfpBhaoleLMI/4Q?= =?utf-8?q?Zndei5QVrZ1Vht7AxLDxD+G8752xu4sEJE7vXk7wV6jeqKYSwZckWAAbeehsdnsa7?= =?utf-8?q?cCoJj0c9l9WdehG4vNkuee72P5lTZPskK9YtO85vaUKqCUZDFuv7V+3c+u8eZbC1V?= =?utf-8?q?hcy4fuIY3nmfztibO4U2tyHgaMwgQKhJL8RI7R+gUK6PEisaouPZRn75PwFPUHQy1?= =?utf-8?q?RpTIea+/93THLl3fS/QkqDXN1GvnpTK+9fY55R9ev3UyaAFVa73lwN2nlUWVJeWVw?= =?utf-8?q?qTMcifVwTGMTgIeuwLokDcZ2S/I6Q5Uqi+7WoiDmktkq66xTrWKu5tDFc+p2FMxJ2?= =?utf-8?q?DoHfIqzSFA+3cdDhfJiEte9k5OF177lGui05/uyHrW11dY8/Bd+qSApYMnBt4Fw6u?= =?utf-8?q?tFLdz3QRMwVKX88akIwYJXNF7n7wvmg48CC3xYR4HHjZmSTrExX9wzUHvUxCqqsFh?= =?utf-8?q?N1HMi2Xp0wV7Vrj8eJT//ab/VfrHQkAJufdbMBSMFytEi4ssgfTvZqfL/EgCaw0jA?= =?utf-8?q?oxrIFEyvXiUizpVgAxxORJF4rFwtAO/F+20YOFz55SE+WRjjMM8I58u8xhWRGpx39?= =?utf-8?q?C/BbkdP+22Knrc1MYNQpd8a6zZHnC0R/Ebea8cjkrB7JNIhsyT7IMTgnE7/4tUQaB?= =?utf-8?q?Gfl5IXYWJuU2kM/8+DBFKGKudDpFGHJBH1rrOqvpS4WWmAODatThJ+o1RYUYQjEef?= =?utf-8?q?7Yf2pIWklknN+lyH9ddJbCyxLkexeQ8WRx4U+fOcUScK2Gnd1ZVCvycAjURXLVPmm?= =?utf-8?q?gW+5ktkw+09Lf0ohg0/hfWCUUGgs416JOOVuTw5KCNwVkEDKUk24dgBPnFvaTW8a6?= =?utf-8?q?5Cq9jN32FnTvKIThArjBlWXRANCBiI4zjFqmUjH1abFRMpLWqFylJF7ho526Ah+oi?= =?utf-8?q?xiZEJUuocX7klp1QZUyw1ksy+lWbkIa8OMUC63uWtn/bFRPa1Tz+f4r0eBwNEHMi4?= =?utf-8?q?rwKeujGSO9xR5r5zV4QcatX/pVY1IyjzAJ/tZZCh7YhGtpg2aIrkHxgLIPbQfWOOG?= =?utf-8?q?ATrhEg4DaInpGV1ljXR79WHLieJU2DE3yW7ED+327Ks1EtkhLZi4pMiKD7IyXQM+Y?= =?utf-8?q?Ho8eWw8LXGYFhmg0+bdB6OcRzfwF+qQtH6tjb9+hC1ibD5xEoZhuhZbj8vOfbwmZn?= =?utf-8?q?hdNWSk3VCl8xKuXFd1HKT5FVHyaMdQi4ERnCwoyb1+cF5qprEiXBxtMdlQUoSZyde?= =?utf-8?q?AolK6VyGFFLS8GkVilyPttqOvXsKriMalYmhAVNJDbzErj2rpo0JNYgUX8VnDiFKU?= =?utf-8?q?eqsaxUxFjYKwWAqrd6ZxREzyu2YKYKVQT95w8AkOI9F2H68lTqXpG+HQqaCTg9s0f?= =?utf-8?q?NWAw9tnWW1+1y+dcDw2oZrWMXyhuQ8+GA=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PAXPR04MB9642.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(52116014)(7416014)(366016)(1800799024)(921020)(38350700014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?Uv+rDDfblxhGIdaA2ikBxRXy9/wP?= =?utf-8?q?mSIy7e3x8LjDZFCKIqyfPZ9fs9u+2RXc/Wj6Vxog60mYkTcrLzIUH+WbKDvFLFPsi?= =?utf-8?q?qUFmr4aBM6gzydOR5iicE6MYaamQVNi5AhiLxncik3SIRKfC6eRmiKpuVWQeYVA59?= =?utf-8?q?Taly5xi5eQ4E7TOdXXWo+S1V+3mnbLqHWwN4tZi66McVZkMWHcgAcNR6URw2G2YRp?= =?utf-8?q?ia4k8WPxGetT9jqGdWQQjqUxiu/h98Oe0aneBIwuLk6oX7X/6l5X7t1UW1TiRg+Xa?= =?utf-8?q?PZib3bXpGLna6formSmoYjOpRWMCjv91upe2nU7nFkhYMdhJ/fPZgYuISVVJ/A3iS?= =?utf-8?q?v0n+NFrhS/90/+Rcwl+f+1s63So3le35oRuKudgSOQDnUR4QOB8c7yxkA2xOXsvwB?= =?utf-8?q?l5AwU/fpnxRt2lcfirhFOvpj01qz928kJLuSrNxmo6m6uN0ytz7x7c/wTYRuTeZeK?= =?utf-8?q?4RaVBB3wx6qge3C9ofUkBkCxy4aoM+43SmtSo91LmjPvd35BUZZ14r4jlhTOTFWBR?= =?utf-8?q?VX7YMs+8Y9Rxe6yQy0DeOegl0t9u08Mw5kWgk2r7fEOki+9aA255BRtMDd93nicss?= =?utf-8?q?6GWsUZkem5KpL6XLmxsjxpse7Q/6KGTj0mWCRByJaOPBP/TZ6iPtwcrH7KCU731O2?= =?utf-8?q?bSXIJAi5/Cjn5t79GmEJ3Z0SZ+jgnjk/aN5jfFHBJYMz5h9pn/EkHoxhaL+d4mJD9?= =?utf-8?q?EWAgcHvVxF/RPoLfksuCoK0gEo2ivBRHF/Go9P9CqTzIz4LM/9/6Sx7NUBOk2ifzc?= =?utf-8?q?cGH5z+iJ9anCYRmr/byilmMNadR6pvskKYI3szabupxncVZugv4lh+JR2E54LoXdi?= =?utf-8?q?ZeUu4VQMJhQS7DtcKA7pIREco4Da+YCI/tdB4QGcLVTlfrJUxVjtMWBLAZJxBXjaf?= =?utf-8?q?D9PokTWeRNG+BUOzVeKyZPmj6C4sln/K5Cr30WDPLJQK04kXcJJUO130vu+7cmgzE?= =?utf-8?q?LAA8AOjdKkSzYFQGl/R7ofhmhfFrir+eF5Or3R8vTM5UC0NjYzNqkepjtrkFkYMTE?= =?utf-8?q?gwfE0U/9qHmLUMWqcoS6Oc2BaFA9I9LA8hkkF5hUagxHOz5akKJBnEf9F8sMsBIoi?= =?utf-8?q?r9219UWkSSvgjrxQNVofcmmW5SrSvWFWKY9ijy+InrsltDYY0yT4If390LgQBAWBi?= =?utf-8?q?yB0C8toJbGgANBcuKV/2wAjMhIYw2EDZGTXIMOiEGOQi73daQf2qTehBipyCGNaKo?= =?utf-8?q?D7IXJpztD/pDav+Ln5X1EAleYsnXewuLmS/bMoxBTNxm6SyS2MnhSqwaxBNHnoH++?= =?utf-8?q?1PSYJUwd3w9EpvMKMdZVhpNduGnEeV+IPDgYbnF1jFMLLCakrZHks6vmArNDfnrj4?= =?utf-8?q?6BeSP8RETT8IeaiQMcHQK6xe/6nmdcqFY9JNzACxoo3hxnQGCocZH2pD04L1Ujw7T?= =?utf-8?q?1+9QDAnuk39zyYHWOXCsYA4QRfgJkwg9e6nm72WWrR1q35+JY5OQOC7aPHUW5jk8/?= =?utf-8?q?ghGzKljbVIYlzWylTfgn228wXkEB2d6+linblO4qToRotFCP02rrUR5g=3D?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: eb9d7df9-b9fe-4f98-d97d-08dd423f1cee X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Jan 2025 21:34:59.3396 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: r3gojYEZ9USqHgOMDNc598AWCIGcFgthJl1Zg/NMx2eOtbZjNIVrE0miRXmZE0ZO+7K6Rtvv3KWBhjctsShFAw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI2PR04MB10980 Add support for the common PHY interface to enable and disable the MIPI CSI PHY. This is required for platforms like i.MX8QM, which rely on the PHY driver for powering the MIPI CSI PHY on and off. Add reset delay for i.MX8QM. It needs a delay after toggle reset. Signed-off-by: Frank Li --- drivers/media/platform/nxp/imx8mq-mipi-csi2.c | 46 +++++++++++++++++++++++++++ 1 file changed, 46 insertions(+) diff --git a/drivers/media/platform/nxp/imx8mq-mipi-csi2.c b/drivers/media/platform/nxp/imx8mq-mipi-csi2.c index b5eae56d92f49..df34caffd4a3a 100644 --- a/drivers/media/platform/nxp/imx8mq-mipi-csi2.c +++ b/drivers/media/platform/nxp/imx8mq-mipi-csi2.c @@ -17,6 +17,7 @@ #include #include #include +#include #include #include #include @@ -89,6 +90,8 @@ struct imx8mq_plat_data { const char *name; int (*enable)(struct csi_state *state, u32 hs_settle); void (*disable)(struct csi_state *state); + bool use_phydrv: 1; + int reset_delay; }; /* @@ -125,6 +128,7 @@ struct csi_state { u32 state; struct regmap *phy_gpr; + struct phy *phy; u8 phy_gpr_reg; struct icc_path *icc_path; @@ -169,6 +173,37 @@ static const struct imx8mq_plat_data imx8mq_data = { .enable = imx8mq_gpr_enable, }; +/* ----------------------------------------------------------------------------- + * Use common PHY interface + */ +static int imx8_phy_enable(struct csi_state *state, u32 hs_settle) +{ + int ret; + + ret = phy_set_speed(state->phy, hs_settle); + if (ret) + return ret; + + ret = phy_power_on(state->phy); + if (ret) + return ret; + + return 0; +} + +static void imx8_phy_disable(struct csi_state *state) +{ + phy_power_off(state->phy); +} + +static const struct imx8mq_plat_data imx8qm_data = { + .name = "i.MX8QM", + .enable = imx8_phy_enable, + .disable = imx8_phy_disable, + .use_phydrv = 1, + .reset_delay = 10000, +}; + static const struct csi2_pix_format imx8mq_mipi_csi_formats[] = { /* RAW (Bayer and greyscale) formats. */ { @@ -273,6 +308,8 @@ static int imx8mq_mipi_csi_sw_reset(struct csi_state *state) return ret; } + fsleep(state->pdata->reset_delay); + return 0; } @@ -860,6 +897,14 @@ static int imx8mq_mipi_csi_parse_dt(struct csi_state *state) return PTR_ERR(state->rst); } + if (state->pdata->use_phydrv) { + state->phy = devm_of_phy_get_by_index(dev, dev->of_node, 0); + if (IS_ERR(state->phy)) + return dev_err_probe(dev, PTR_ERR(state->phy), "Can't get mipi phy\n"); + + return 0; + } + ret = of_property_read_u32_array(np, "fsl,mipi-phy-gpr", out_val, ARRAY_SIZE(out_val)); if (ret) { @@ -979,6 +1024,7 @@ static void imx8mq_mipi_csi_remove(struct platform_device *pdev) static const struct of_device_id imx8mq_mipi_csi_of_match[] = { { .compatible = "fsl,imx8mq-mipi-csi2", .data = &imx8mq_data }, + { .compatible = "fsl,imx8qm-mipi-csi2", .data = &imx8qm_data }, { /* sentinel */ }, }; MODULE_DEVICE_TABLE(of, imx8mq_mipi_csi_of_match);