| Message ID | 20240610100530.1107771-8-sakari.ailus@linux.intel.com |
|---|---|
| State | New |
| Headers | show |
| Series | Media device lifetime management | expand |
This needs a proper commit log. Specifically it should mention that due to the revert in patch 05/26 the media_dev field was deleted, but that that revert didn't remove it from the kerneldoc comments. I would also suggest that you move this patch to 06/26 so that it comes right after the 05/26 revert, since the two really belong together. With that, you can add my: Acked-by: Hans Verkuil <hverkuil-cisco@xs4all.nl> Regards, Hans On 10/06/2024 12:05, Sakari Ailus wrote: > Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com> > --- > include/media/media-devnode.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/include/media/media-devnode.h b/include/media/media-devnode.h > index 1117d1dfd6bf..024dfb98a6fd 100644 > --- a/include/media/media-devnode.h > +++ b/include/media/media-devnode.h > @@ -55,7 +55,6 @@ struct media_file_operations { > > /** > * struct media_devnode - Media device node > - * @media_dev: pointer to struct &media_device > * @fops: pointer to struct &media_file_operations with media device ops > * @dev: pointer to struct &device containing the media controller device > * @cdev: struct cdev pointer character device
Hi Hans, Thanks for the review. On Mon, Jun 17, 2024 at 11:02:16AM +0200, Hans Verkuil wrote: > This needs a proper commit log. Oops. I thought this had been fixed already but I'll do that now. I'll use: The revert of patch "[media] media-device: dynamically allocate struct media_devnode" did not remove the kerneldoc documentation of the field media_dev in struct media_devnode. Do it now. > > Specifically it should mention that due to the revert in patch 05/26 > the media_dev field was deleted, but that that revert didn't remove it > from the kerneldoc comments. > > I would also suggest that you move this patch to 06/26 so that it > comes right after the 05/26 revert, since the two really belong together. I agree. > > With that, you can add my: > > Acked-by: Hans Verkuil <hverkuil-cisco@xs4all.nl> Thank you!
diff --git a/include/media/media-devnode.h b/include/media/media-devnode.h index 1117d1dfd6bf..024dfb98a6fd 100644 --- a/include/media/media-devnode.h +++ b/include/media/media-devnode.h @@ -55,7 +55,6 @@ struct media_file_operations { /** * struct media_devnode - Media device node - * @media_dev: pointer to struct &media_device * @fops: pointer to struct &media_file_operations with media device ops * @dev: pointer to struct &device containing the media controller device * @cdev: struct cdev pointer character device
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com> --- include/media/media-devnode.h | 1 - 1 file changed, 1 deletion(-)