From patchwork Sat Apr 15 15:56:30 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Pinchart X-Patchwork-Id: 673538 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86B24C77B71 for ; Sat, 15 Apr 2023 15:56:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229961AbjDOP4v (ORCPT ); Sat, 15 Apr 2023 11:56:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37682 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229764AbjDOP4u (ORCPT ); Sat, 15 Apr 2023 11:56:50 -0400 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D3FB549FF for ; Sat, 15 Apr 2023 08:56:48 -0700 (PDT) Received: from pendragon.ideasonboard.com (133-32-181-51.west.xps.vectant.ne.jp [133.32.181.51]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id ECED09C; Sat, 15 Apr 2023 17:56:42 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1681574203; bh=Zq29F8fmebdAV0lOV0/Euey42c1n8IFjZyVSuNPjG8s=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=DKv6YtkgVvqfLMx9d8fdW27KmyHXE4eMeu7MUpq8SP5A0Py3wOuOrzNACnmUXckyM 86gu0hfpTy65nVy/YleYgGtiF7I0jhZa4BETNhBZrl7UdSk4WdLJafxyUh+b37c3lj hOF3P1xGy6IrWYyIGrBKoHSm5V2SPwrTjzstgny0= From: Laurent Pinchart To: linux-media@vger.kernel.org Cc: Jacopo Mondi , Xavier Roumegue , linux-imx@nxp.com, kernel@pengutronix.de, Adam Ford Subject: [PATCH v5 5/5] media: nxp: imx8-isi: Remove 300ms sleep after enabling channel Date: Sat, 15 Apr 2023 18:56:30 +0300 Message-Id: <20230415155630.7492-6-laurent.pinchart@ideasonboard.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230415155630.7492-1-laurent.pinchart@ideasonboard.com> References: <20230415155630.7492-1-laurent.pinchart@ideasonboard.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org From: Jacopo Mondi The current implementation of the mxc_isi_channel_enable() function has a hard 300ms sleep. This was copied from the NXP BSP, which has since dropped the sleep in a commit that implied the delay was meant to wait for the sensor to be "stable". As the sensor is started after the ISI, the delay won't affect sensor operation. Drop it. Signed-off-by: Jacopo Mondi Reviewed-by: Laurent Pinchart Signed-off-by: Laurent Pinchart --- drivers/media/platform/nxp/imx8-isi/imx8-isi-hw.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/media/platform/nxp/imx8-isi/imx8-isi-hw.c b/drivers/media/platform/nxp/imx8-isi/imx8-isi-hw.c index be12d0d2f42f..db538f3d88ec 100644 --- a/drivers/media/platform/nxp/imx8-isi/imx8-isi-hw.c +++ b/drivers/media/platform/nxp/imx8-isi/imx8-isi-hw.c @@ -515,8 +515,6 @@ void mxc_isi_channel_enable(struct mxc_isi_pipe *pipe) mxc_isi_write(pipe, CHNL_CTRL, val); mutex_unlock(&pipe->lock); - - msleep(300); } void mxc_isi_channel_disable(struct mxc_isi_pipe *pipe)