| Message ID | 20230326143224.572654-21-u.kleine-koenig@pengutronix.de |
|---|---|
| State | Accepted |
| Commit | a5a86c2ee0050c8162fdf968b42bf8174a238aaa |
| Headers | show |
| Series | media: Convert to platform remove callback returning void | expand |
On 26/03/2023 at 16:30, Uwe Kleine-König wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > The .remove() callback for a platform driver returns an int which makes > many driver authors wrongly assume it's possible to do error handling by > returning an error code. However the value returned is (mostly) ignored > and this typically results in resource leaks. To improve here there is a > quest to make the remove callback return void. In the first step of this > quest all drivers are converted to .remove_new() which already returns > void. > > Trivially convert this driver from always returning zero in the remove > callback to the void returning variant. > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com> Thanks. Best regards, Nicolas > --- > drivers/media/platform/atmel/atmel-isi.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/media/platform/atmel/atmel-isi.c b/drivers/media/platform/atmel/atmel-isi.c > index 4d15814e4481..b063f980f9e0 100644 > --- a/drivers/media/platform/atmel/atmel-isi.c > +++ b/drivers/media/platform/atmel/atmel-isi.c > @@ -1317,7 +1317,7 @@ static int atmel_isi_probe(struct platform_device *pdev) > return ret; > } > > -static int atmel_isi_remove(struct platform_device *pdev) > +static void atmel_isi_remove(struct platform_device *pdev) > { > struct atmel_isi *isi = platform_get_drvdata(pdev); > > @@ -1329,8 +1329,6 @@ static int atmel_isi_remove(struct platform_device *pdev) > v4l2_async_nf_unregister(&isi->notifier); > v4l2_async_nf_cleanup(&isi->notifier); > v4l2_device_unregister(&isi->v4l2_dev); > - > - return 0; > } > > #ifdef CONFIG_PM > @@ -1368,7 +1366,7 @@ static struct platform_driver atmel_isi_driver = { > .pm = &atmel_isi_dev_pm_ops, > }, > .probe = atmel_isi_probe, > - .remove = atmel_isi_remove, > + .remove_new = atmel_isi_remove, > }; > > module_platform_driver(atmel_isi_driver); > -- > 2.39.2 >
diff --git a/drivers/media/platform/atmel/atmel-isi.c b/drivers/media/platform/atmel/atmel-isi.c index 4d15814e4481..b063f980f9e0 100644 --- a/drivers/media/platform/atmel/atmel-isi.c +++ b/drivers/media/platform/atmel/atmel-isi.c @@ -1317,7 +1317,7 @@ static int atmel_isi_probe(struct platform_device *pdev) return ret; } -static int atmel_isi_remove(struct platform_device *pdev) +static void atmel_isi_remove(struct platform_device *pdev) { struct atmel_isi *isi = platform_get_drvdata(pdev); @@ -1329,8 +1329,6 @@ static int atmel_isi_remove(struct platform_device *pdev) v4l2_async_nf_unregister(&isi->notifier); v4l2_async_nf_cleanup(&isi->notifier); v4l2_device_unregister(&isi->v4l2_dev); - - return 0; } #ifdef CONFIG_PM @@ -1368,7 +1366,7 @@ static struct platform_driver atmel_isi_driver = { .pm = &atmel_isi_dev_pm_ops, }, .probe = atmel_isi_probe, - .remove = atmel_isi_remove, + .remove_new = atmel_isi_remove, }; module_platform_driver(atmel_isi_driver);
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> --- drivers/media/platform/atmel/atmel-isi.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)