From patchwork Tue Feb 28 15:24:25 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Konrad Dybcio X-Patchwork-Id: 657626 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72B7BC7EE32 for ; Tue, 28 Feb 2023 15:24:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229504AbjB1PYj (ORCPT ); Tue, 28 Feb 2023 10:24:39 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39980 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229600AbjB1PYi (ORCPT ); Tue, 28 Feb 2023 10:24:38 -0500 Received: from mail-lf1-x12a.google.com (mail-lf1-x12a.google.com [IPv6:2a00:1450:4864:20::12a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 26B4323DAB for ; Tue, 28 Feb 2023 07:24:37 -0800 (PST) Received: by mail-lf1-x12a.google.com with SMTP id m7so13684644lfj.8 for ; Tue, 28 Feb 2023 07:24:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1677597875; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=qXugSA6r2tV+X0iFO+lGhptFx82s88fjNq0jEwrsdR0=; b=RPRIrotIE+koozd7vn/zocKpX5RSWm/6VDAD2UGrFh0IctGRRyHRnEGh+sSpoDTvRW ksd+hq83BAcnNyvyyxR8mcsHaW5kTw/hPn4rRjxpwpe74lDJvyKE5XReeUYZE3shedp/ FuNQw5+aYrryJlzGHXh+uUgxQvl2+MQpfSdpBNzfZX0nL3d6mwJI+J/Bd+gZUSVEUP2U VvrFr+johfkEaj7kJ0rmBFYyB+dj2egWh1mSU3QbsPC1ZMeft4JFzA/GQePiQc0GzxFP 0mi71GPNpc+ULpMi7owlLwbtBaG3rHwr9lYsUy/dRKxNpoDIVSg7E42CWllIVB4d2OA8 9BZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677597875; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qXugSA6r2tV+X0iFO+lGhptFx82s88fjNq0jEwrsdR0=; b=eqwAJhTG29l7qm8brepG82DqrHTl5gU1d8zFWDGv4uXHm6H1stMA/V4vbdDY9/ZkOH gfyZNFvFm7dCodADxyiTa7jG57c50TFQUI49bpYj/5U5ob3JrfLbKiEbSw9YsHRW45P/ QXuAcEwIAA8cXNxUD6Ta2/ftVnPBPGUM/gUj3pTVf1aGKdVqVOIlElp6kFEs/wFzGgl8 OqH8Iltq4q/YQTbRuV9hMIMbP53Ki9hsH7CdBHLHZG0WWx3iaLWrAuJv55im9Iq4ihSJ SWLRbU/Zb28du/Lu9aoYXcA9HWRNi5apUqeaJLdYboCXfHkEtEA7gKSIy5KwwJix/aSX 0n3A== X-Gm-Message-State: AO0yUKVUSiDhv9TMF9v69HAjshRAezyZRIlcykRldt9VoHfgY/dOVvPu JUj1uRWirp+nbVCBT4vWMpymTA== X-Google-Smtp-Source: AK7set/ETuGKMpQpJ4OQLtd/G98Lx8jAQPHrQ5KgigYJm1favsWQ3qmU/avdWBaWD5bBi2H3RAmQxg== X-Received: by 2002:ac2:5df8:0:b0:4df:998d:79d7 with SMTP id z24-20020ac25df8000000b004df998d79d7mr771300lfq.8.1677597875450; Tue, 28 Feb 2023 07:24:35 -0800 (PST) Received: from [192.168.1.101] (abym99.neoplus.adsl.tpnet.pl. [83.9.32.99]) by smtp.gmail.com with ESMTPSA id h17-20020ac250d1000000b004db3aa3c542sm1363688lfm.47.2023.02.28.07.24.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Feb 2023 07:24:35 -0800 (PST) From: Konrad Dybcio Date: Tue, 28 Feb 2023 16:24:25 +0100 Subject: [PATCH 01/18] media: venus: hfi_venus: Set venus_sys_idle_indicator to false on V6 MIME-Version: 1.0 Message-Id: <20230228-topic-venus-v1-1-58c2c88384e9@linaro.org> References: <20230228-topic-venus-v1-0-58c2c88384e9@linaro.org> In-Reply-To: <20230228-topic-venus-v1-0-58c2c88384e9@linaro.org> To: Stanimir Varbanov , Vikash Garodia , Andy Gross , Bjorn Andersson , Mauro Carvalho Chehab , Dikshita Agarwal , Bryan O'Donoghue , Dikshita Agarwal , Mansur Alisha Shaik , Jonathan Marek Cc: Mauro Carvalho Chehab , Stanimir Varbanov , linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Vikash Garodia , Konrad Dybcio X-Mailer: b4 0.12.1 X-Developer-Signature: v=1; a=ed25519-sha256; t=1677597872; l=1210; i=konrad.dybcio@linaro.org; s=20230215; h=from:subject:message-id; bh=l21Hj3clKvJ5WDgOnhsicYzRTtdql9epuJV12nTy5r8=; b=WE/7f4vV02g5I5rmyHXeuw4wZOzwD2LPxcq1Q+IVLDzZ+6E2EdCHTjVF6JVDiYpFBH2ghcDOvGJx 1Bj0zUymCybQ0fyG7CTW50knq8ZpeeEk14URBba4rDbYpJ6L6gOl X-Developer-Key: i=konrad.dybcio@linaro.org; a=ed25519; pk=iclgkYvtl2w05SSXO5EjjSYlhFKsJ+5OSZBjOkQuEms= Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org This call does not seem to have been cast on any kernel with support for VPU-1.0 or newer (and by extension, HFI6 and newer). Restrict it to V4 only, as it seems to have been enabled by mistake and causes a hang & reboot to EDL on at least one occasion with SM6115 / AR50L Fixes: 7ed9e0b3393c ("media: venus: hfi, vdec: v6 Add IS_V6() to existing IS_V4() if locations") Signed-off-by: Konrad Dybcio --- drivers/media/platform/qcom/venus/hfi_venus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/qcom/venus/hfi_venus.c b/drivers/media/platform/qcom/venus/hfi_venus.c index 2ad40b3945b0..4ccf31147c2a 100644 --- a/drivers/media/platform/qcom/venus/hfi_venus.c +++ b/drivers/media/platform/qcom/venus/hfi_venus.c @@ -952,7 +952,7 @@ static int venus_sys_set_default_properties(struct venus_hfi_device *hdev) * enable it explicitly in order to make suspend functional by checking * WFI (wait-for-interrupt) bit. */ - if (IS_V4(hdev->core) || IS_V6(hdev->core)) + if (IS_V4(hdev->core)) venus_sys_idle_indicator = true; ret = venus_sys_set_idle_message(hdev, venus_sys_idle_indicator);