| Message ID | 20230208173343.37582-3-andriy.shevchenko@linux.intel.com |
|---|---|
| State | Accepted |
| Commit | 7a49bfde01961dac9efb734f031f3e77ce537f6d |
| Headers | show |
| Series | [v4,01/18] ARM: orion/gpio: Use the right include | expand |
On Wed, Feb 8, 2023 at 6:39 PM Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > On 08/02/2023 18:33, Andy Shevchenko wrote: > > From: Linus Walleij <linus.walleij@linaro.org> > > > > The file s3c64xx.c is including <linux/gpio.h> despite using no > > symbols from the file, however it needs it to implicitly bring in > > of_have_populated_dt() so include <linux/of.h> explicitly instead. > > > > Signed-off-by: Linus Walleij <linus.walleij@linaro.org> > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > --- > > arch/arm/mach-s3c/s3c64xx.c | 2 +- > > It's not s3c24xx anymore, so subject prefix: > ARM: s3c64xx: My mistake, mea culpa. Yours, Linus Walleij
diff --git a/arch/arm/mach-s3c/s3c64xx.c b/arch/arm/mach-s3c/s3c64xx.c index e97bd59083a8..9f9717874d67 100644 --- a/arch/arm/mach-s3c/s3c64xx.c +++ b/arch/arm/mach-s3c/s3c64xx.c @@ -21,13 +21,13 @@ #include <linux/ioport.h> #include <linux/serial_core.h> #include <linux/serial_s3c.h> +#include <linux/of.h> #include <linux/platform_device.h> #include <linux/reboot.h> #include <linux/io.h> #include <linux/clk/samsung.h> #include <linux/dma-mapping.h> #include <linux/irq.h> -#include <linux/gpio.h> #include <linux/irqchip/arm-vic.h> #include <clocksource/samsung_pwm.h>