From patchwork Mon Nov 7 20:49:57 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jacopo Mondi X-Patchwork-Id: 622525 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0AD93C4332F for ; Mon, 7 Nov 2022 20:50:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233054AbiKGUuZ (ORCPT ); Mon, 7 Nov 2022 15:50:25 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40718 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233050AbiKGUuW (ORCPT ); Mon, 7 Nov 2022 15:50:22 -0500 Received: from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::229]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EB57F1E3D5 for ; Mon, 7 Nov 2022 12:50:20 -0800 (PST) Received: (Authenticated sender: jacopo@jmondi.org) by mail.gandi.net (Postfix) with ESMTPSA id 0ABC9FF811; Mon, 7 Nov 2022 20:50:17 +0000 (UTC) From: Jacopo Mondi To: Sakari Ailus , Laurent Pinchart , Dave Stevenson , Hans Verkuil , Mauro Carvalho Chehab Cc: Jacopo Mondi , Linux Media Mailing List Subject: [PATCH 1/3] Documentation: media: camera-sensor: Correct frame interval Date: Mon, 7 Nov 2022 21:49:57 +0100 Message-Id: <20221107204959.37691-2-jacopo@jmondi.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221107204959.37691-1-jacopo@jmondi.org> References: <20221107204959.37691-1-jacopo@jmondi.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org The formula to compute the frame interval uses the analogue crop rectangle dimensions to compute the total frame size in conjunction with blankings. Horizontal and vertical blankings are realized by extending the time interval during which no valid pixels are sent on the bus between visible lines and between consecutive frames, whose size is smaller than the analogue crop rectangle if any additional cropping or pixel subsampling is applied on the sensor processing pipeline. Correct the documentation to use the visible line length and frame height instead of the analogue crop dimensions. Signed-off-by: Jacopo Mondi --- Documentation/driver-api/media/camera-sensor.rst | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/Documentation/driver-api/media/camera-sensor.rst b/Documentation/driver-api/media/camera-sensor.rst index c7d4891bd24e..bb7d62db4cd1 100644 --- a/Documentation/driver-api/media/camera-sensor.rst +++ b/Documentation/driver-api/media/camera-sensor.rst @@ -87,12 +87,11 @@ less all modern raw camera sensors. The frame interval is calculated using the following equation:: - frame interval = (analogue crop width + horizontal blanking) * - (analogue crop height + vertical blanking) / pixel rate + frame interval = (visible width + horizontal blanking) * + (visibile height + vertical blanking) / pixel rate The formula is bus independent and is applicable for raw timing parameters on -large variety of devices beyond camera sensors. Devices that have no analogue -crop, use the full source image size, i.e. pixel array size. +large variety of devices beyond camera sensors. Horizontal and vertical blanking are specified by ``V4L2_CID_HBLANK`` and ``V4L2_CID_VBLANK``, respectively. The unit of the ``V4L2_CID_HBLANK`` control