From patchwork Thu May 12 12:37:23 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Oliver Neukum X-Patchwork-Id: 572430 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9911C4332F for ; Thu, 12 May 2022 12:37:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1353860AbiELMha (ORCPT ); Thu, 12 May 2022 08:37:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51110 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1353856AbiELMh2 (ORCPT ); Thu, 12 May 2022 08:37:28 -0400 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1CDFE62216 for ; Thu, 12 May 2022 05:37:27 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id D04601F893; Thu, 12 May 2022 12:37:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1652359045; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fwf89B8V5+V3KZCamsMNefpJQ19baCYyZNDhaBPr9+g=; b=sssfD7f4+XfpHC4Pd0k6fKRVS7fdDcWfzfMuL3+rTK2f4gyZNijAp9Ae2qq3yPkWBiN9xn kELVlr/nTu1e4S/hsOQxGQ4Q+UXRYoxebTQnPug7NZ3WqeWDxOmGlTyRfhehpbGnF0Vsxe 18pH7OWsbP9o6F1lUheDScxXU8GXnho= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 97AF313ABE; Thu, 12 May 2022 12:37:25 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id +MJiI4X/fGL/GgAAMHmgww (envelope-from ); Thu, 12 May 2022 12:37:25 +0000 From: Oliver Neukum To: linux-media@vger.kernel.org, mchehab@kernel.org, sean@mess.org Cc: Oliver Neukum Subject: [PATCHv2 4/4] igorplugusb: remove superfluous usb_unlink_urb() Date: Thu, 12 May 2022 14:37:23 +0200 Message-Id: <20220512123723.25815-4-oneukum@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20220512123723.25815-1-oneukum@suse.com> References: <20220512123723.25815-1-oneukum@suse.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Calling that on yourself while the completion handler is running is a NOP. Remove it. v2: Resinding series due to omitting first patch Signed-off-by: Oliver Neukum --- drivers/media/rc/igorplugusb.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/media/rc/igorplugusb.c b/drivers/media/rc/igorplugusb.c index b2245849f7aa..12ee5dd0a61a 100644 --- a/drivers/media/rc/igorplugusb.c +++ b/drivers/media/rc/igorplugusb.c @@ -110,7 +110,6 @@ static void igorplugusb_callback(struct urb *urb) case -ECONNRESET: case -ENOENT: case -ESHUTDOWN: - usb_unlink_urb(urb); return; default: dev_warn(ir->dev, "Error: urb status = %d\n", urb->status);