| Message ID | 20220210111044.152904-1-jacopo@jmondi.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | media: ov5640: Rework the clock tree programming for MIPI | expand |
Hi Jacopo, Thank you for the patch. On Thu, Feb 10, 2022 at 12:10:41PM +0100, Jacopo Mondi wrote: > The driver already supports the 2X8_[LE|BE] variants of RGB565 > formats. > > As for CSI-2 the 2X8 variants do not apply, add RGB565_1X16 variant > with little-endian ordering of components as required by the CSI-2 > specifications. > > Signed-off-by: Jacopo Mondi <jacopo@jmondi.org> > --- > drivers/media/i2c/ov5640.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/media/i2c/ov5640.c b/drivers/media/i2c/ov5640.c > index aecc8912099a..3a21f4648acf 100644 > --- a/drivers/media/i2c/ov5640.c > +++ b/drivers/media/i2c/ov5640.c > @@ -220,6 +220,10 @@ static const struct ov5640_pixfmt { > .code = MEDIA_BUS_FMT_RGB565_2X8_BE, > .colorspace = V4L2_COLORSPACE_SRGB, > .bpp = 16, > + }, { > + .code = MEDIA_BUS_FMT_RGB565_1X16, > + .colorspace = V4L2_COLORSPACE_SRGB, > + .bpp = 16, Should/could we limit this format to CSI-2 mode ? > }, { > .code = MEDIA_BUS_FMT_SBGGR8_1X8, > .colorspace = V4L2_COLORSPACE_SRGB, > @@ -2763,6 +2767,7 @@ static int ov5640_set_framefmt(struct ov5640_dev *sensor, > mux = OV5640_FMT_MUX_YUV422; > break; > case MEDIA_BUS_FMT_RGB565_2X8_LE: > + case MEDIA_BUS_FMT_RGB565_1X16: > /* RGB565 {g[2:0],b[4:0]},{r[4:0],g[5:3]} */ > fmt = 0x6F; > mux = OV5640_FMT_MUX_RGB;
diff --git a/drivers/media/i2c/ov5640.c b/drivers/media/i2c/ov5640.c index aecc8912099a..3a21f4648acf 100644 --- a/drivers/media/i2c/ov5640.c +++ b/drivers/media/i2c/ov5640.c @@ -220,6 +220,10 @@ static const struct ov5640_pixfmt { .code = MEDIA_BUS_FMT_RGB565_2X8_BE, .colorspace = V4L2_COLORSPACE_SRGB, .bpp = 16, + }, { + .code = MEDIA_BUS_FMT_RGB565_1X16, + .colorspace = V4L2_COLORSPACE_SRGB, + .bpp = 16, }, { .code = MEDIA_BUS_FMT_SBGGR8_1X8, .colorspace = V4L2_COLORSPACE_SRGB, @@ -2763,6 +2767,7 @@ static int ov5640_set_framefmt(struct ov5640_dev *sensor, mux = OV5640_FMT_MUX_YUV422; break; case MEDIA_BUS_FMT_RGB565_2X8_LE: + case MEDIA_BUS_FMT_RGB565_1X16: /* RGB565 {g[2:0],b[4:0]},{r[4:0],g[5:3]} */ fmt = 0x6F; mux = OV5640_FMT_MUX_RGB;
The driver already supports the 2X8_[LE|BE] variants of RGB565 formats. As for CSI-2 the 2X8 variants do not apply, add RGB565_1X16 variant with little-endian ordering of components as required by the CSI-2 specifications. Signed-off-by: Jacopo Mondi <jacopo@jmondi.org> --- drivers/media/i2c/ov5640.c | 5 +++++ 1 file changed, 5 insertions(+)