From patchwork Thu Jan 6 23:55:39 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bryan O'Donoghue X-Patchwork-Id: 530414 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 565B6C433EF for ; Thu, 6 Jan 2022 23:53:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343560AbiAFXxs (ORCPT ); Thu, 6 Jan 2022 18:53:48 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45012 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343597AbiAFXxl (ORCPT ); Thu, 6 Jan 2022 18:53:41 -0500 Received: from mail-wm1-x32b.google.com (mail-wm1-x32b.google.com [IPv6:2a00:1450:4864:20::32b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1832FC034006 for ; Thu, 6 Jan 2022 15:53:40 -0800 (PST) Received: by mail-wm1-x32b.google.com with SMTP id 2-20020a05600c02c200b003470f96e778so1810188wmn.5 for ; Thu, 06 Jan 2022 15:53:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=f0/jP+wtHGnEZCaZ9/FXXw65LhXfTFFCKBh0r3UhICg=; b=Dv/yut/JRt/ZVOjBgbZq7X4t3JU2hRhepXqMSK2lfvZyKE7pYV3PumP/JwIpJ4s4h7 a47lxKxlab97q0smmBcqmni1J00ZO9ibnRe4OuAi8dRI36MJmNeRUimQDRIG/x8vA/tr NuksPEMIR01ZKSV+i/t8wn5oQCGLtUUPFnHWZ/xgC03Bk7Ro9wH0bYVguDagtuz9mYBa hVuNpWL+SdrCi6wTxj1mjcgRUbAnnvmmZ9mkaosCsYen20yXbsWClJRNZGAOO8OzAeX1 UQ2HjN4FlUF1cTZk8lbjtGwtDYK4joFAgM+FNmYiPdS3PN69IUSjuNOKECg1/6Y+36pi 5fsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=f0/jP+wtHGnEZCaZ9/FXXw65LhXfTFFCKBh0r3UhICg=; b=5u80p/JRTzQ6kvrylSeB3WeJmyJ2+diOvq9NId/bp/9iGeiaJWk2buRSEWElLO40il 4YqCyDaXc5zNvJwnMqGdXDqbEQbbxb5867BSSQ345JZyH9MbQQRa2OGl+9Qz55+Rt8m2 y2PffZ4Q3YOUWXp+eInxmEjibFm6himKuWCk57EP9KcEe7zD0k4RTantLim/CmwpAP5d +C4L1HrAUBRHMabyOo5pmc0NJOnwj/bFDSeCk+BmirYJVlHyC/LPAQ2yaLesImDo3XJq bhUmUZnsgherYJ4CbcUMxffeU20w5tMLaGMXrUwzcrbl13V6VtpjtutAdAJ+2K6z/rFb 1e+g== X-Gm-Message-State: AOAM531F2Vp6u7HBPSSDfeVTqFkMlKME3M04YZz/ooG2qS+0K6t9Uj3T eykqMvoFQysMIXPQWwnCCagDqg== X-Google-Smtp-Source: ABdhPJxcFcMQuIk/0p73clG3HeTa7gIkYGcpdF+XxUcS0M11AJAff5lVTE72GMYHcCbKOlc2a6jhIQ== X-Received: by 2002:a05:600c:643:: with SMTP id p3mr8771786wmm.130.1641513218743; Thu, 06 Jan 2022 15:53:38 -0800 (PST) Received: from sagittarius-a.chello.ie (188-141-3-169.dynamic.upc.ie. [188.141.3.169]) by smtp.gmail.com with ESMTPSA id a71sm335893wme.39.2022.01.06.15.53.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Jan 2022 15:53:38 -0800 (PST) From: Bryan O'Donoghue To: linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org, mchehab@kernel.org, hverkuil@xs4all.nl, robert.foss@linaro.org Cc: jonathan@marek.ca, andrey.konovalov@linaro.org, todor.too@gmail.com, agross@kernel.org, bjorn.andersson@linaro.org, jgrahsl@snap.com, hfink@snap.com, vladimir.zapolskiy@linaro.org, dmitry.baryshkov@linaro.org, bryan.odonoghue@linaro.org Subject: [PATCH 6/7] media: camss: Point sdm845 at the correct vdda regulators Date: Thu, 6 Jan 2022 23:55:39 +0000 Message-Id: <20220106235540.1567839-7-bryan.odonoghue@linaro.org> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20220106235540.1567839-1-bryan.odonoghue@linaro.org> References: <20220106235540.1567839-1-bryan.odonoghue@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Reviewing the RB3 schematic its clear that we have missed out on defining one of the power-rails associated with the CSI PHY. Other PHYs such as the UFS, PCIe and USB connect to these rails and define each regulator individually. This means if we were to switch off the other various PHYs which enable these rails, the CAMSS would not appropriately power-on the CSI PHY. Signed-off-by: Bryan O'Donoghue --- drivers/media/platform/qcom/camss/camss.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/media/platform/qcom/camss/camss.c b/drivers/media/platform/qcom/camss/camss.c index 419c48c4f1d52..6de257502e88b 100644 --- a/drivers/media/platform/qcom/camss/camss.c +++ b/drivers/media/platform/qcom/camss/camss.c @@ -543,7 +543,7 @@ static const struct resources csiphy_res_845[] = { static const struct resources csid_res_845[] = { /* CSID0 */ { - .regulators = { NULL }, + .regulators = { "vdda-phy", "vdda-pll" }, .clock = { "cpas_ahb", "cphy_rx_src", "slow_ahb_src", "soc_ahb", "vfe0", "vfe0_src", "vfe0_cphy_rx", "csi0", @@ -563,7 +563,7 @@ static const struct resources csid_res_845[] = { /* CSID1 */ { - .regulators = { NULL }, + .regulators = { "vdda-phy", "vdda-pll" }, .clock = { "cpas_ahb", "cphy_rx_src", "slow_ahb_src", "soc_ahb", "vfe1", "vfe1_src", "vfe1_cphy_rx", "csi1", @@ -583,7 +583,7 @@ static const struct resources csid_res_845[] = { /* CSID2 */ { - .regulators = { NULL }, + .regulators = { "vdda-phy", "vdda-pll" }, .clock = { "cpas_ahb", "cphy_rx_src", "slow_ahb_src", "soc_ahb", "vfe_lite", "vfe_lite_src", "vfe_lite_cphy_rx", "csi2",