From patchwork Mon Sep 20 09:58:24 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 514305 Delivered-To: patch@linaro.org Received: by 2002:a02:c816:0:0:0:0:0 with SMTP id p22csp1891969jao; Mon, 20 Sep 2021 02:58:50 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyIjWSv1mILhnD4u1z1vd9eRAqZ9gC9nmCBZFd+Po4k+DdXSKvRq8cNib8gEUNBmzZ3UvHf X-Received: by 2002:a17:906:7a09:: with SMTP id d9mr27191414ejo.116.1632131929808; Mon, 20 Sep 2021 02:58:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1632131929; cv=none; d=google.com; s=arc-20160816; b=vkWUKEffrUDgThCxZuFte2CKurrE1g5Axw+xPuFm0fvGGn/XNWxRW3VdiPp0QTN5PE Od/4Wh8lyufyp0S8NvwM82xCniR+3kPkvnvxV0iVCfNFpN1V71w+S2GDJe70V9xbQjBl WI77NWPgJfpyGth5QTw+gkhoT3B7LTHNOZY90IqvX10piIb6yZxpeN0Hc2r4BlbaEjFr L9nsgSrK5QtYx6oK6ZTpZWi31HSIiJh+UVZ3wi6HUjuPGIA/us2ujhlDUzur8lhOjKIr KOTra6kva1p6o20AQmGmy+u0hxr6gquFdqbAEs0mMqSJ3eBYgt3T+Km5YE3EE40Te8ZW PBkg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=ZbpkFzpXEtzCJusKvf3NBq5kbl08rKvtwFY2V+1M0yE=; b=SU8fO0DNp1KcNwUjiSp1bislkluW7mV6prcL98e4iIfItfqP+H2JtvcrN/z7GFqfTu xF0ipabICdgEXVmQm9wC0HjUWgvMbDTkLWuJlVE+vnZNvGkHeaDW9bbrpqqmRTjqKvMy miNhzl5Vtc6A5rkuT/0xCKRvx6zZHI+lDOipVB/jzUIaYRBTzGqBQWFWko2i7hZU9QE9 4pwC04hD192K2CLbad0gEwasyw/rSux6JDUNiHguz2RZ1xa1voSKr1MBR9lyeUmBeUC3 dSirvmvIS+bpucYycBxffwf3AV80lbL99EocLplAHcQ//L9RYsZoxUwMFFzWyhxBzIRc ec9A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=kfnTcImb; spf=pass (google.com: domain of linux-media-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-media-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t22si15223243ejy.236.2021.09.20.02.58.49; Mon, 20 Sep 2021 02:58:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-media-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=kfnTcImb; spf=pass (google.com: domain of linux-media-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-media-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235770AbhITKAO (ORCPT + 4 others); Mon, 20 Sep 2021 06:00:14 -0400 Received: from mail.kernel.org ([198.145.29.99]:41592 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235146AbhITKAA (ORCPT ); Mon, 20 Sep 2021 06:00:00 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 8CCC160FC0; Mon, 20 Sep 2021 09:58:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1632131914; bh=xGTDUY6etx4mvWGTyYfaqkyCJe8IjP1eL1OrpZKEXZY=; h=From:To:Cc:Subject:Date:From; b=kfnTcImb8uyt9guvJHsThKvSkTnjlgwd8wBedX7rKyuvSAv1QAWMEm1tXgbVz8sGD 2wR5nNDegLZaDiorsUUJ4RiSU8YZ3cgTi8F/axZU6LcPQfxO/umq619tAkNexN7+U6 HkEotJL9JrVEjaX4/2c6VKAPwbTh7UkkYmL9pQyKK7HH9stgnSLgyLBp7lTNl5SB5J rsjywGKeeM/sRHV1MSx2sN080GbyjPd0O7cm2tFsdqQ/dbMgyVEQYL9jIikOgpHbJ1 Ykuny+u3kie+assaUPaBNOjEctKxSswORqwqpH/Vs4DyFDOsdfvXADvKsG6NB4YyyS hq/7cYK4EDLXQ== From: Arnd Bergmann To: Mauro Carvalho Chehab Cc: Arnd Bergmann , Sakari Ailus , Daniele Alessandrelli , Martina Krasteva , Jacopo Mondi , Paul Kocialkowski , Tianshu Qiu , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] media: i2c: select V4L2_ASYNC where needed Date: Mon, 20 Sep 2021 11:58:24 +0200 Message-Id: <20210920095830.1259051-1-arnd@kernel.org> X-Mailer: git-send-email 2.29.2 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org From: Arnd Bergmann I came across a link failure from randconfig builds: x86_64-linux-ld: drivers/media/i2c/ths8200.o: in function `ths8200_remove': ths8200.c:(.text+0x491): undefined reference to `v4l2_async_unregister_subdev' x86_64-linux-ld: drivers/media/i2c/ths8200.o: in function `ths8200_probe': ths8200.c:(.text+0xe49): undefined reference to `v4l2_async_register_subdev' x86_64-linux-ld: drivers/media/i2c/tw9910.o: in function `tw9910_remove': tw9910.c:(.text+0x467): undefined reference to `v4l2_async_unregister_subdev' x86_64-linux-ld: drivers/media/i2c/tw9910.o: in function `tw9910_probe': tw9910.c:(.text+0x1123): undefined reference to `v4l2_async_register_subdev' These clearly lack a 'select' statement, but I don't know why this started happening only now. I had a bit of a look around to find other configs that have the same problem, but could not come up with a reliable way and found nothing else through experimentation. It is likely that other symbols like these exist that need an extra select. Signed-off-by: Arnd Bergmann --- drivers/media/i2c/Kconfig | 2 ++ 1 file changed, 2 insertions(+) -- 2.29.2 Acked-by: Sakari Ailus diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig index 08feb3e8c1bf..d49eecc4fe33 100644 --- a/drivers/media/i2c/Kconfig +++ b/drivers/media/i2c/Kconfig @@ -450,6 +450,7 @@ config VIDEO_TW9906 config VIDEO_TW9910 tristate "Techwell TW9910 video decoder" depends on VIDEO_V4L2 && I2C + select V4L2_ASYNC help Support for Techwell TW9910 NTSC/PAL/SECAM video decoder. @@ -597,6 +598,7 @@ config VIDEO_AK881X config VIDEO_THS8200 tristate "Texas Instruments THS8200 video encoder" depends on VIDEO_V4L2 && I2C + select V4L2_ASYNC help Support for the Texas Instruments THS8200 video encoder.