| Message ID | 20210216174146.106639-9-jacopo+renesas@jmondi.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [01/16] media: i2c: rdacm20: Enable noise immunity | expand |
On 16/02/2021 17:41, Jacopo Mondi wrote: > The parameters to max9286_i2c_mux_configure() fits on the previous > line. Adjust it. > > Cosmetic change only. Cosmetic tag ;-) Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> > > Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org> > --- > drivers/media/i2c/max9286.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/media/i2c/max9286.c b/drivers/media/i2c/max9286.c > index 6fd4d59fcc72..1d9951215868 100644 > --- a/drivers/media/i2c/max9286.c > +++ b/drivers/media/i2c/max9286.c > @@ -287,9 +287,8 @@ static int max9286_i2c_mux_select(struct i2c_mux_core *muxc, u32 chan) > > priv->mux_channel = chan; > > - max9286_i2c_mux_configure(priv, > - MAX9286_FWDCCEN(chan) | > - MAX9286_REVCCEN(chan)); > + max9286_i2c_mux_configure(priv, MAX9286_FWDCCEN(chan) | > + MAX9286_REVCCEN(chan)); > > return 0; > } >
Hi Jacopo, Thank you for the patch. On Tue, Feb 16, 2021 at 06:41:38PM +0100, Jacopo Mondi wrote: > The parameters to max9286_i2c_mux_configure() fits on the previous > line. Adjust it. > > Cosmetic change only. > > Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org> > --- > drivers/media/i2c/max9286.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/media/i2c/max9286.c b/drivers/media/i2c/max9286.c > index 6fd4d59fcc72..1d9951215868 100644 > --- a/drivers/media/i2c/max9286.c > +++ b/drivers/media/i2c/max9286.c > @@ -287,9 +287,8 @@ static int max9286_i2c_mux_select(struct i2c_mux_core *muxc, u32 chan) > > priv->mux_channel = chan; > > - max9286_i2c_mux_configure(priv, > - MAX9286_FWDCCEN(chan) | > - MAX9286_REVCCEN(chan)); > + max9286_i2c_mux_configure(priv, MAX9286_FWDCCEN(chan) | > + MAX9286_REVCCEN(chan)); I feel obliged to say I would have written max9286_i2c_mux_configure(priv, MAX9286_FWDCCEN(chan) | MAX9286_REVCCEN(chan)); :-) Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > return 0; > } -- Regards, Laurent Pinchart
diff --git a/drivers/media/i2c/max9286.c b/drivers/media/i2c/max9286.c index 6fd4d59fcc72..1d9951215868 100644 --- a/drivers/media/i2c/max9286.c +++ b/drivers/media/i2c/max9286.c @@ -287,9 +287,8 @@ static int max9286_i2c_mux_select(struct i2c_mux_core *muxc, u32 chan) priv->mux_channel = chan; - max9286_i2c_mux_configure(priv, - MAX9286_FWDCCEN(chan) | - MAX9286_REVCCEN(chan)); + max9286_i2c_mux_configure(priv, MAX9286_FWDCCEN(chan) | + MAX9286_REVCCEN(chan)); return 0; }
The parameters to max9286_i2c_mux_configure() fits on the previous line. Adjust it. Cosmetic change only. Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org> --- drivers/media/i2c/max9286.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)