| Message ID | 20210128120945.5062-12-sakari.ailus@linux.intel.com |
|---|---|
| State | New |
| Headers | show |
| Series | V4L2 Async notifier API cleanup | expand |
On 1/28/21 9:09 AM, Sakari Ailus wrote: > From: Ezequiel Garcia <ezequiel@collabora.com> > > The v4l2_async_notifier_cleanup() documentation mentions > v4l2_fwnode_reference_parse_sensor_common, which was actually > introduced as v4l2_async_notifier_parse_fwnode_sensor_common(), > in commit 7a9ec808ad46 ("media: v4l: fwnode: Add convenience function for > parsing common external refs"). > > The function drivers do use is > v4l2_async_register_subdev_sensor_common(). > > Signed-off-by: Ezequiel Garcia <ezequiel@collabora.com> > Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com> > --- > include/media/v4l2-async.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/media/v4l2-async.h b/include/media/v4l2-async.h > index 8815e233677e..f2cac0931372 100644 > --- a/include/media/v4l2-async.h > +++ b/include/media/v4l2-async.h > @@ -250,7 +250,7 @@ void v4l2_async_notifier_unregister(struct v4l2_async_notifier *notifier); > * notifier after calling > * @v4l2_async_notifier_add_subdev, > * @v4l2_async_notifier_parse_fwnode_endpoints or > - * @v4l2_fwnode_reference_parse_sensor_common. > + * @v4l2_async_register_subdev_sensor_common. This line gets removed on patch 14/14, maybe just drop this patch? Thanks Helen > * > * There is no harm from calling v4l2_async_notifier_cleanup in other > * cases as long as its memory has been zeroed after it has been >
Hi Helen, Thanks for the review! On Mon, Feb 01, 2021 at 04:33:54PM -0300, Helen Koike wrote: > > > On 1/28/21 9:09 AM, Sakari Ailus wrote: > > From: Ezequiel Garcia <ezequiel@collabora.com> > > > > The v4l2_async_notifier_cleanup() documentation mentions > > v4l2_fwnode_reference_parse_sensor_common, which was actually > > introduced as v4l2_async_notifier_parse_fwnode_sensor_common(), > > in commit 7a9ec808ad46 ("media: v4l: fwnode: Add convenience function for > > parsing common external refs"). > > > > The function drivers do use is > > v4l2_async_register_subdev_sensor_common(). > > > > Signed-off-by: Ezequiel Garcia <ezequiel@collabora.com> > > Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com> > > --- > > include/media/v4l2-async.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/include/media/v4l2-async.h b/include/media/v4l2-async.h > > index 8815e233677e..f2cac0931372 100644 > > --- a/include/media/v4l2-async.h > > +++ b/include/media/v4l2-async.h > > @@ -250,7 +250,7 @@ void v4l2_async_notifier_unregister(struct v4l2_async_notifier *notifier); > > * notifier after calling > > * @v4l2_async_notifier_add_subdev, > > * @v4l2_async_notifier_parse_fwnode_endpoints or > > - * @v4l2_fwnode_reference_parse_sensor_common. > > + * @v4l2_async_register_subdev_sensor_common. > > This line gets removed on patch 14/14, maybe just drop this patch? I'll squash it with 14th. -- Sakari Ailus
diff --git a/include/media/v4l2-async.h b/include/media/v4l2-async.h index 8815e233677e..f2cac0931372 100644 --- a/include/media/v4l2-async.h +++ b/include/media/v4l2-async.h @@ -250,7 +250,7 @@ void v4l2_async_notifier_unregister(struct v4l2_async_notifier *notifier); * notifier after calling * @v4l2_async_notifier_add_subdev, * @v4l2_async_notifier_parse_fwnode_endpoints or - * @v4l2_fwnode_reference_parse_sensor_common. + * @v4l2_async_register_subdev_sensor_common. * * There is no harm from calling v4l2_async_notifier_cleanup in other * cases as long as its memory has been zeroed after it has been