From patchwork Sun Jan 17 22:21:38 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Tom Rix X-Patchwork-Id: 365327 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER, INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34C1EC433DB for ; Sun, 17 Jan 2021 22:24:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 01AE9224B0 for ; Sun, 17 Jan 2021 22:24:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730525AbhAQWXt (ORCPT ); Sun, 17 Jan 2021 17:23:49 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:24719 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730487AbhAQWXT (ORCPT ); Sun, 17 Jan 2021 17:23:19 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1610922112; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=1Q/nirjyd353laCSIcUJdblTkIhaVs8AOQO2AamTKH0=; b=YT2htPgRh3IjSkrigGvxEeBTkLV+rJ8Mmx+1YJXQw7kNz78OUrwTK44vUzqH92aqunqF2m i+1BoDAwmwb0OpgcOwrqzW9jM8fWojC1XQGToM9YeCotec/JVn3hp3sWdmhNaAcP4rWXOI JovaZnIVj7ki5I6XzZKBrNUJVBiJbpI= Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-319-kWFSImbxOM2DKXBix1Lk5A-1; Sun, 17 Jan 2021 17:21:50 -0500 X-MC-Unique: kWFSImbxOM2DKXBix1Lk5A-1 Received: by mail-qv1-f69.google.com with SMTP id m1so14566642qvp.0 for ; Sun, 17 Jan 2021 14:21:50 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=1Q/nirjyd353laCSIcUJdblTkIhaVs8AOQO2AamTKH0=; b=nvcj401/uxxOrwZG84C9UtY4dositJyBRePxz/AjMbasc4PFV20HKxcQM+xCVArhkq ZxO0+J0ECdrZmzRsK16IePL0G7U0ZSnIohb81D3JdnPY//4IlTm+e77SD+SKDYa8o7Pr 1WOgTtm+EFnuCJykCYIvIsmgp6ei817Nlkug6N4Bx+J6/eACzp9Ka6MdSW0v3HsiLXE8 FQ2oPFe9Ar5uCYEMJSVl310M/7Dv9oVZZWK94bK5Q5jkGXDIMpDTkbw8lhd6M1AubaLF iXfSHFJfj/tjZ0q4oKtdwcwEsqefAxY0nQBDcEwUOBe/Nf/dz5NgBW9xLe6KD97aXenr 1J2Q== X-Gm-Message-State: AOAM531xg/kLEQJPZfYTx0eCIEktvYGmQqXfFjswwF9PEQBs4l14rNZB D9GfML6H//qv8DCJKA/vqCKHhq6KyezRouHOvq/8Zbu5yDtIZVN7fYIe9ZgOW9+AN7e5MPfCt1M l4QBklZDQL74eWtNtpbb/GcQ= X-Received: by 2002:a0c:9e50:: with SMTP id z16mr21356533qve.13.1610922110404; Sun, 17 Jan 2021 14:21:50 -0800 (PST) X-Google-Smtp-Source: ABdhPJxLfAViRBC01RcVQ97+1PHfTVCqF3ZzkhqNaMPivdg097DavcqB1qB4Ni4JYwm+u1ckPY0Qnw== X-Received: by 2002:a0c:9e50:: with SMTP id z16mr21356516qve.13.1610922110196; Sun, 17 Jan 2021 14:21:50 -0800 (PST) Received: from trix.remote.csb (075-142-250-213.res.spectrum.com. [75.142.250.213]) by smtp.gmail.com with ESMTPSA id d25sm9674480qkl.97.2021.01.17.14.21.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 17 Jan 2021 14:21:49 -0800 (PST) From: trix@redhat.com To: tiffany.lin@mediatek.com, andrew-ct.chen@mediatek.com, mchehab@kernel.org, matthias.bgg@gmail.com, hverkuil-cisco@xs4all.nl, yunfei.dong@mediatek.com, acourbot@chromium.org Cc: linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, Tom Rix Subject: [PATCH] media: mtk-vcodec: fix argument used when DEBUG is defined Date: Sun, 17 Jan 2021 14:21:38 -0800 Message-Id: <20210117222138.551147-1-trix@redhat.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org From: Tom Rix When DEBUG is defined this error occurs drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_drv.c:306:41: error: ‘i’ undeclared (first use in this function) mtk_v4l2_debug(2, "reg[%d] base=0x%p", i, dev->reg_base[VENC_SYS]); Reviewing the old line mtk_v4l2_debug(2, "reg[%d] base=0x%p", i, dev->reg_base[i]); All the i's need to be changed to VENC_SYS. Fix a similar error for VENC_LT_SYS. Fixes: 0dc4b3286125 ("media: mtk-vcodec: venc: support SCP firmware") Signed-off-by: Tom Rix --- drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_drv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_drv.c b/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_drv.c index dfb42e19bf81..be3842e6ca47 100644 --- a/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_drv.c +++ b/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_drv.c @@ -303,7 +303,7 @@ static int mtk_vcodec_probe(struct platform_device *pdev) ret = PTR_ERR((__force void *)dev->reg_base[VENC_SYS]); goto err_res; } - mtk_v4l2_debug(2, "reg[%d] base=0x%p", i, dev->reg_base[VENC_SYS]); + mtk_v4l2_debug(2, "reg[%d] base=0x%p", VENC_SYS, dev->reg_base[VENC_SYS]); res = platform_get_resource(pdev, IORESOURCE_IRQ, 0); if (res == NULL) { @@ -332,7 +332,7 @@ static int mtk_vcodec_probe(struct platform_device *pdev) ret = PTR_ERR((__force void *)dev->reg_base[VENC_LT_SYS]); goto err_res; } - mtk_v4l2_debug(2, "reg[%d] base=0x%p", i, dev->reg_base[VENC_LT_SYS]); + mtk_v4l2_debug(2, "reg[%d] base=0x%p", VENC_LT_SYS, dev->reg_base[VENC_LT_SYS]); dev->enc_lt_irq = platform_get_irq(pdev, 1); irq_set_status_flags(dev->enc_lt_irq, IRQ_NOAUTOEN);