From patchwork Thu Oct 27 16:03:37 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 101584 Delivered-To: patch@linaro.org Received: by 10.140.97.247 with SMTP id m110csp704039qge; Thu, 27 Oct 2016 09:04:18 -0700 (PDT) X-Received: by 10.99.50.71 with SMTP id y68mr13118452pgy.111.1477584258255; Thu, 27 Oct 2016 09:04:18 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 19si8587975pgc.314.2016.10.27.09.04.18; Thu, 27 Oct 2016 09:04:18 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-media-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-media-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-media-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964877AbcJ0QEP (ORCPT + 4 others); Thu, 27 Oct 2016 12:04:15 -0400 Received: from mout.kundenserver.de ([212.227.126.133]:53979 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933709AbcJ0QEO (ORCPT ); Thu, 27 Oct 2016 12:04:14 -0400 Received: from wuerfel.lan. ([78.43.20.153]) by mrelayeu.kundenserver.de (mreue005) with ESMTPA (Nemesis) id 0M7o7Y-1cmPdc0mCe-00vMPk; Thu, 27 Oct 2016 18:03:56 +0200 From: Arnd Bergmann To: Mauro Carvalho Chehab Cc: Arnd Bergmann , Javier Martinez Canillas , Sean Young , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] [media] rc: print correct variable for z8f0811 Date: Thu, 27 Oct 2016 18:03:37 +0200 Message-Id: <20161027160349.557473-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:JaaXQ1bL6sSQEa6ckB8Cbodfs4sO0btmSaZHfC0eoGQfdyipLXD IWFP774ii2mj3gQesRZV9zPEZyBpNtZQIVpL6sAR0pE5waiuS8seMhfm7tBAhrW9zS1YHsc HnrUB7+SPEGWQkiZEnG9wLS/6opRGwrMk+Z5X+4dz8roCVDFW7+6qLhZnbgZTYQyL92kpwK lPWAjYd7c+N8RnXrMflqA== X-UI-Out-Filterresults: notjunk:1; V01:K0:crH+H5yimMU=:c5ZwvIyjsbEve3MUnBdzG5 CEdZVIRqr5AOQwAnfV+aubHnv72KFV0qDx0c/rp4bExGfRfeXUvWkLB3qMQFjcBWCQYjpuIuL UBwFWr4JsffbnRmUUOaWnaih2oOEdsF81Mg3N9+jMcZG16teyLCMi4dqfwxYR77uLv3I1w0h2 A9lv5u///gfLhvyPryapGxA7sg4bpQcDv4Ya0FN0cE8nRUVsCpVXhBQvtvpAcIgx/hTBYlNZ9 OXVqcgBMebpB17LgK4rdE0HGx9H7I2qrYINobQhiaGpiIVKK8myHcStLYQivUv3NfIa+LlmRp 5RvMQnPIu6X2XYG8WMC8PWHi1r6T6+LaDGUTokR3zu9dwp1DpNeL1yMwl111FAyZAMUtyWFAf Tubj8M+OFOkYtgqeOpTdi4teL8m0gF30i0y9t497XthIoNh+ea78dtP2ui8VpvAe0z+It4OKF gZaolng646GZKA2gdcFz0tRyFO3nyd1rINdryJ/SUL/orPlilgS3c//YKqQDKULWnDSjeFuha YBABo/CUX9ezyOfJUAny/1iauQellE2WC+71Il9vIOE7tFTjcavBdwY3+JfpqKnCwGRDQfXGb yGVtRvKVmvXKLBNu21jIjWj7QvvpvuhOw6/nSNlzdIeW+Hek5mnybGrg90GFlxLEjzr1uD0Af hyq5wVBYp7SLT4cSw3ZW5pSspISNx2XVSfgLvWmUUSuEoXsDavbC7M2IbhwzNsIGXtE4= Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org A recent rework accidentally left a debugging printk untouched while changing the meaning of the variables, leading to an uninitialized variable being printed: drivers/media/i2c/ir-kbd-i2c.c: In function 'get_key_haup_common': drivers/media/i2c/ir-kbd-i2c.c:62:2: error: 'toggle' may be used uninitialized in this function [-Werror=maybe-uninitialized] This prints the correct one instead, as we did before the patch. Fixes: 00bb820755ed ("[media] rc: Hauppauge z8f0811 can decode RC6") Signed-off-by: Arnd Bergmann --- drivers/media/i2c/ir-kbd-i2c.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) I'd like to see this patch make it into v4.9 so we can enable the warning again by default. Can you give me an Ack for it or apply it to the fixes tree? -- 2.9.0 -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/media/i2c/ir-kbd-i2c.c b/drivers/media/i2c/ir-kbd-i2c.c index f95a6bc..cede397 100644 --- a/drivers/media/i2c/ir-kbd-i2c.c +++ b/drivers/media/i2c/ir-kbd-i2c.c @@ -118,7 +118,7 @@ static int get_key_haup_common(struct IR_i2c *ir, enum rc_type *protocol, *protocol = RC_TYPE_RC6_MCE; dev &= 0x7f; dprintk(1, "ir hauppauge (rc6-mce): t%d vendor=%d dev=%d code=%d\n", - toggle, vendor, dev, code); + *ptoggle, vendor, dev, code); } else { *ptoggle = 0; *protocol = RC_TYPE_RC6_6A_32;