From patchwork Thu Mar 25 08:23:03 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jiapeng Chong X-Patchwork-Id: 409172 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, UNPARSEABLE_RELAY, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A28AEC433DB for ; Thu, 25 Mar 2021 08:24:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5908161A1A for ; Thu, 25 Mar 2021 08:24:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229695AbhCYIXp (ORCPT ); Thu, 25 Mar 2021 04:23:45 -0400 Received: from out30-43.freemail.mail.aliyun.com ([115.124.30.43]:33732 "EHLO out30-43.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229782AbhCYIXR (ORCPT ); Thu, 25 Mar 2021 04:23:17 -0400 X-Alimail-AntiSpam: AC=PASS; BC=-1|-1; BR=01201311R241e4; CH=green; DM=||false|; DS=||; FP=0|-1|-1|-1|0|-1|-1|-1; HT=e01e04395; MF=jiapeng.chong@linux.alibaba.com; NM=1; PH=DS; RN=4; SR=0; TI=SMTPD_---0UTFuKJG_1616660584; Received: from j63c13417.sqa.eu95.tbsite.net(mailfrom:jiapeng.chong@linux.alibaba.com fp:SMTPD_---0UTFuKJG_1616660584) by smtp.aliyun-inc.com(127.0.0.1); Thu, 25 Mar 2021 16:23:13 +0800 From: Jiapeng Chong To: mchehab@kernel.org Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Jiapeng Chong Subject: [PATCH] media: mxl692: remove impossible condition Date: Thu, 25 Mar 2021 16:23:03 +0800 Message-Id: <1616660583-122448-1-git-send-email-jiapeng.chong@linux.alibaba.com> X-Mailer: git-send-email 1.8.3.1 Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Fix the following coverity warning: This greater-than-or-equal-to-zero comparison of an unsigned value is always true. "opcode >= 0". Signed-off-by: Jiapeng Chong --- drivers/media/dvb-frontends/mxl692.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/dvb-frontends/mxl692.c b/drivers/media/dvb-frontends/mxl692.c index 86af831..8303064 100644 --- a/drivers/media/dvb-frontends/mxl692.c +++ b/drivers/media/dvb-frontends/mxl692.c @@ -377,7 +377,7 @@ static int mxl692_memread(struct mxl692_dev *dev, u32 addr, static const char *mxl692_opcode_string(u8 opcode) { - if (opcode >= 0 && opcode <= MXL_EAGLE_OPCODE_INTERNAL) + if (opcode <= MXL_EAGLE_OPCODE_INTERNAL) return MXL_EAGLE_OPCODE_STRING[opcode]; return "invalid opcode";