From patchwork Mon Jan 30 09:39:21 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hans Verkuil X-Patchwork-Id: 648841 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9CA34C54EAA for ; Mon, 30 Jan 2023 09:40:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235840AbjA3JkD (ORCPT ); Mon, 30 Jan 2023 04:40:03 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47256 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235807AbjA3JkC (ORCPT ); Mon, 30 Jan 2023 04:40:02 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A5D40EC51 for ; Mon, 30 Jan 2023 01:39:39 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 813B760EF4 for ; Mon, 30 Jan 2023 09:39:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 79D01C433EF; Mon, 30 Jan 2023 09:39:23 +0000 (UTC) Message-ID: <15030a07-3615-fca0-1891-a234dc054b00@xs4all.nl> Date: Mon, 30 Jan 2023 10:39:21 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Content-Language: en-US To: Linux Media Mailing List Cc: Marco Felsch From: Hans Verkuil Subject: [PATCH] media: tc358746: init m/p_best to 0 Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org This fixes compiler warnings: In file included from include/linux/printk.h:566, from include/linux/kernel.h:29, from include/linux/clk.h:13, from drivers/media/i2c/tc358746.c:12: drivers/media/i2c/tc358746.c: In function 'tc358746_find_pll_settings': include/linux/dynamic_debug.h:272:33: warning: 'p_best' may be used uninitialized in this function [-Wmaybe-uninitialized] 272 | _dynamic_func_call(fmt, __dynamic_dev_dbg, \ | ^~~~~~~~~~~~~~~~~ drivers/media/i2c/tc358746.c:817:13: note: 'p_best' was declared here 817 | u16 p_best, p; | ^~~~~~ In file included from include/linux/printk.h:566, from include/linux/kernel.h:29, from include/linux/clk.h:13, from drivers/media/i2c/tc358746.c:12: include/linux/dynamic_debug.h:272:33: warning: 'm_best' may be used uninitialized in this function [-Wmaybe-uninitialized] 272 | _dynamic_func_call(fmt, __dynamic_dev_dbg, \ | ^~~~~~~~~~~~~~~~~ drivers/media/i2c/tc358746.c:816:13: note: 'm_best' was declared here 816 | u16 m_best, mul; | ^~~~~~ Signed-off-by: Hans Verkuil Reviewed-by: Marco Felsch --- drivers/media/i2c/tc358746.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/i2c/tc358746.c b/drivers/media/i2c/tc358746.c index d1f552bd81d4..b86baa5c2d82 100644 --- a/drivers/media/i2c/tc358746.c +++ b/drivers/media/i2c/tc358746.c @@ -813,8 +813,8 @@ static unsigned long tc358746_find_pll_settings(struct tc358746 *tc358746, u32 min_delta = 0xffffffff; u16 prediv_max = 17; u16 prediv_min = 1; - u16 m_best, mul; - u16 p_best, p; + u16 m_best = 0, mul; + u16 p_best = 0, p; u8 postdiv; if (fout > 1000 * HZ_PER_MHZ) {