From patchwork Tue Apr 30 06:16:18 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sachin Kamat X-Patchwork-Id: 16514 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-qe0-f69.google.com (mail-qe0-f69.google.com [209.85.128.69]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 01A9323903 for ; Tue, 30 Apr 2013 06:29:16 +0000 (UTC) Received: by mail-qe0-f69.google.com with SMTP id a11sf314361qen.0 for ; Mon, 29 Apr 2013 23:29:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:mime-version:x-beenthere:x-received:received-spf :x-received:x-forwarded-to:x-forwarded-for:delivered-to:x-received :received-spf:x-received:from:to:cc:subject:date:message-id:x-mailer :x-gm-message-state:x-original-sender :x-original-authentication-results:precedence:mailing-list:list-id :x-google-group-id:list-post:list-help:list-archive:list-unsubscribe; bh=UiI9kd7M+U92xMyKNwKPljyzVl44aFjXIt5/KBCZpkI=; b=WX3K4hBHrPF4KxOHrWrcDbX6gkbYQwFM399F2rIvhVew+jfqIkQZRjfP6G8hwB5FhN 6fXx+sHH7CqY8vXI4WUGDrzAOYI9jeQcbosFz30DOv/f9STdNL0aho8Esg5CsJj/GLer gpZTFolW4BUUNBCsn1O5b3tViVzjDCcG8Y9tmWuxQvWs8xMc9rDXo8mFP72Z5nTixqMo tkH/sL53yOpj8uCBCZn4ZTSIMnaHQgsN4N4gkTYTQZDc/zgmbnHGWaLXoFjhwWpFGyAC 70xFhOu7KiCe2kYiMwTwQikte9GyYYANBg0hoeeOKjM0ZycxLprvbD8v4rMEwlc1Mdiu B8sg== X-Received: by 10.236.80.106 with SMTP id j70mr14375853yhe.11.1367303353618; Mon, 29 Apr 2013 23:29:13 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.49.0.78 with SMTP id 14ls106729qec.10.gmail; Mon, 29 Apr 2013 23:29:13 -0700 (PDT) X-Received: by 10.58.90.5 with SMTP id bs5mr8084645veb.60.1367303353435; Mon, 29 Apr 2013 23:29:13 -0700 (PDT) Received: from mail-vc0-f174.google.com (mail-vc0-f174.google.com [209.85.220.174]) by mx.google.com with ESMTPS id ec8si11460030vdb.124.2013.04.29.23.29.13 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 29 Apr 2013 23:29:13 -0700 (PDT) Received-SPF: neutral (google.com: 209.85.220.174 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=209.85.220.174; Received: by mail-vc0-f174.google.com with SMTP id hf12so128963vcb.19 for ; Mon, 29 Apr 2013 23:29:13 -0700 (PDT) X-Received: by 10.220.169.78 with SMTP id x14mr19522039vcy.41.1367303353057; Mon, 29 Apr 2013 23:29:13 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patches@linaro.org Received: by 10.58.127.98 with SMTP id nf2csp90193veb; Mon, 29 Apr 2013 23:29:12 -0700 (PDT) X-Received: by 10.67.4.167 with SMTP id cf7mr4602682pad.76.1367303352094; Mon, 29 Apr 2013 23:29:12 -0700 (PDT) Received: from mail-da0-x231.google.com (mail-da0-x231.google.com [2607:f8b0:400e:c00::231]) by mx.google.com with ESMTPS id wu3si19371904pbc.340.2013.04.29.23.29.11 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 29 Apr 2013 23:29:12 -0700 (PDT) Received-SPF: neutral (google.com: 2607:f8b0:400e:c00::231 is neither permitted nor denied by best guess record for domain of sachin.kamat@linaro.org) client-ip=2607:f8b0:400e:c00::231; Received: by mail-da0-f49.google.com with SMTP id t11so104101daj.36 for ; Mon, 29 Apr 2013 23:29:11 -0700 (PDT) X-Received: by 10.68.51.39 with SMTP id h7mr74738743pbo.155.1367303351293; Mon, 29 Apr 2013 23:29:11 -0700 (PDT) Received: from linaro.sisodomain.com ([115.113.119.130]) by mx.google.com with ESMTPSA id lq5sm1934904pab.19.2013.04.29.23.29.08 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 29 Apr 2013 23:29:10 -0700 (PDT) From: Sachin Kamat To: linux-media@vger.kernel.org Cc: s.nawrocki@samsung.com, sachin.kamat@linaro.org, patches@linaro.org Subject: [PATCH 1/4] [media] s3c-camif: Remove redundant NULL check Date: Tue, 30 Apr 2013 11:46:18 +0530 Message-Id: <1367302581-15478-1-git-send-email-sachin.kamat@linaro.org> X-Mailer: git-send-email 1.7.9.5 X-Gm-Message-State: ALoCoQns/JP4IJEFo81zYwRT3oRUdxqOYsKMvqH6rIsQyzqjepz2VTPEtpvEbLKXN0eQcQ7szBnN X-Original-Sender: sachin.kamat@linaro.org X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.220.174 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Precedence: list Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org List-ID: X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , clk_unprepare checks for NULL pointer. Hence convert IS_ERR_OR_NULL to IS_ERR only. Signed-off-by: Sachin Kamat --- drivers/media/platform/s3c-camif/camif-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/s3c-camif/camif-core.c b/drivers/media/platform/s3c-camif/camif-core.c index 0d0fab1..2449f13 100644 --- a/drivers/media/platform/s3c-camif/camif-core.c +++ b/drivers/media/platform/s3c-camif/camif-core.c @@ -341,7 +341,7 @@ static void camif_clk_put(struct camif_dev *camif) int i; for (i = 0; i < CLK_MAX_NUM; i++) { - if (IS_ERR_OR_NULL(camif->clock[i])) + if (IS_ERR(camif->clock[i])) continue; clk_unprepare(camif->clock[i]); clk_put(camif->clock[i]);