From patchwork Tue Apr 30 04:51:33 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sachin Kamat X-Patchwork-Id: 16512 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-qa0-f71.google.com (mail-qa0-f71.google.com [209.85.216.71]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id B115023903 for ; Tue, 30 Apr 2013 05:04:28 +0000 (UTC) Received: by mail-qa0-f71.google.com with SMTP id bs12sf296244qab.6 for ; Mon, 29 Apr 2013 22:04:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:mime-version:x-beenthere:x-received:received-spf :x-received:x-forwarded-to:x-forwarded-for:delivered-to:x-received :received-spf:x-received:from:to:cc:subject:date:message-id:x-mailer :x-gm-message-state:x-original-sender :x-original-authentication-results:precedence:mailing-list:list-id :x-google-group-id:list-post:list-help:list-archive:list-unsubscribe; bh=KT+QjdidIhxs9LtoMJw99nIKP1yjA3qfQ2X5jIAGGt0=; b=FbhQAizAIv0/K0lNCiUJpEjaTPEKnyXL3eok/CqjCxe+XcZM85IBtbxwsA56i4NzUM oe+87R8CPUmmSG3wKSbXajIh01sxGmduz3wyXw7pXuYcT8IqOVoPzaSQpI0HpR+KcEfj qtQbvjah1TkIB2gBCdUH0IJCLXVM9X1ERWXuSam6Xl4+UQION6epGx+FczeXsy7D/m0A 2YBWhvmK1F2bcvdNIG4jRReWsiV9Erw0oXhurx8XEW3lnQACTdjUXAmNSfbNG+opvkUo bvKzNAxe+2LhEcU2IcU88zbXwo2xQFk7lixcTwzrzKoGfB22tzTlgFq+nc0hs3i4cCcM Ltyw== X-Received: by 10.236.80.106 with SMTP id j70mr14207638yhe.11.1367298265222; Mon, 29 Apr 2013 22:04:25 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.49.71.202 with SMTP id x10ls91340qeu.56.gmail; Mon, 29 Apr 2013 22:04:25 -0700 (PDT) X-Received: by 10.52.37.109 with SMTP id x13mr29686806vdj.10.1367298264943; Mon, 29 Apr 2013 22:04:24 -0700 (PDT) Received: from mail-vb0-x231.google.com (mail-vb0-x231.google.com [2607:f8b0:400c:c02::231]) by mx.google.com with ESMTPS id gs2si811780vdc.154.2013.04.29.22.04.24 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 29 Apr 2013 22:04:24 -0700 (PDT) Received-SPF: neutral (google.com: 2607:f8b0:400c:c02::231 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=2607:f8b0:400c:c02::231; Received: by mail-vb0-f49.google.com with SMTP id 12so95489vbf.8 for ; Mon, 29 Apr 2013 22:04:24 -0700 (PDT) X-Received: by 10.220.242.73 with SMTP id lh9mr8643271vcb.49.1367298264788; Mon, 29 Apr 2013 22:04:24 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patches@linaro.org Received: by 10.58.127.98 with SMTP id nf2csp87541veb; Mon, 29 Apr 2013 22:04:24 -0700 (PDT) X-Received: by 10.66.228.233 with SMTP id sl9mr23546365pac.38.1367298263474; Mon, 29 Apr 2013 22:04:23 -0700 (PDT) Received: from mail-da0-x22d.google.com (mail-da0-x22d.google.com [2607:f8b0:400e:c00::22d]) by mx.google.com with ESMTPS id dj6si19527237pad.221.2013.04.29.22.04.23 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 29 Apr 2013 22:04:23 -0700 (PDT) Received-SPF: neutral (google.com: 2607:f8b0:400e:c00::22d is neither permitted nor denied by best guess record for domain of sachin.kamat@linaro.org) client-ip=2607:f8b0:400e:c00::22d; Received: by mail-da0-f45.google.com with SMTP id v40so75465dad.18 for ; Mon, 29 Apr 2013 22:04:23 -0700 (PDT) X-Received: by 10.68.251.233 with SMTP id zn9mr8177420pbc.206.1367298262960; Mon, 29 Apr 2013 22:04:22 -0700 (PDT) Received: from linaro.sisodomain.com ([115.113.119.130]) by mx.google.com with ESMTPSA id dr6sm28920440pac.11.2013.04.29.22.04.19 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 29 Apr 2013 22:04:21 -0700 (PDT) From: Sachin Kamat To: linux-media@vger.kernel.org Cc: s.nawrocki@samsung.com, sachin.kamat@linaro.org, patches@linaro.org Subject: [PATCH 1/1] [media] exynos4-is: Remove redundant NULL check in fimc-lite.c Date: Tue, 30 Apr 2013 10:21:33 +0530 Message-Id: <1367297493-31782-1-git-send-email-sachin.kamat@linaro.org> X-Mailer: git-send-email 1.7.9.5 X-Gm-Message-State: ALoCoQmRJhc07pn499qYk07bi81tKU3dk4iI+TLv+gGv8Kb3xI1B4lyIx2AEtEUEEnF8+SKwZxh8 X-Original-Sender: sachin.kamat@linaro.org X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 2607:f8b0:400c:c02::231 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Precedence: list Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org List-ID: X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , clk_unprepare checks for NULL pointer. Hence convert IS_ERR_OR_NULL to IS_ERR only. Signed-off-by: Sachin Kamat --- drivers/media/platform/exynos4-is/fimc-lite.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/exynos4-is/fimc-lite.c b/drivers/media/platform/exynos4-is/fimc-lite.c index 661d0d1..2a0ef82 100644 --- a/drivers/media/platform/exynos4-is/fimc-lite.c +++ b/drivers/media/platform/exynos4-is/fimc-lite.c @@ -1416,7 +1416,7 @@ static void fimc_lite_unregister_capture_subdev(struct fimc_lite *fimc) static void fimc_lite_clk_put(struct fimc_lite *fimc) { - if (IS_ERR_OR_NULL(fimc->clock)) + if (IS_ERR(fimc->clock)) return; clk_unprepare(fimc->clock);