From patchwork Mon Apr 29 09:24:59 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sachin Kamat X-Patchwork-Id: 16498 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-we0-f198.google.com (mail-we0-f198.google.com [74.125.82.198]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 3F16925E08 for ; Mon, 29 Apr 2013 09:46:06 +0000 (UTC) Received: by mail-we0-f198.google.com with SMTP id i48sf1853230wef.9 for ; Mon, 29 Apr 2013 02:46:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:mime-version:x-beenthere:x-received:received-spf :x-received:x-forwarded-to:x-forwarded-for:delivered-to:x-received :received-spf:x-received:from:to:cc:subject:date:message-id:x-mailer :in-reply-to:references:x-gm-message-state:x-original-sender :x-original-authentication-results:precedence:mailing-list:list-id :x-google-group-id:list-post:list-help:list-archive:list-unsubscribe; bh=gTUMvatMIyuDhtQI9kOBlUF7q6cou88drkZxsdu/UgU=; b=SHgkqASErMDiTS96Rl4idrhUkMuEccKS7x+hDA25e+hrxRprEfkZr9QHzMZp7QcjwM LMnVG76SgGZmCijBeLmEMghIAeBqp3ScewJh1DMyG8689ErhxmSEdiwGl/5w/g3hIsJT I6Hqzn2IcgqEz8DIFm4BpJA3fF0sSAYiHS1MhA9RUTyGNnWEIy7TLjpAUoMSYPo5Qrpd xDWAAZWvF0YsBYHcgt/LI0Ehc6JTicdjtisKKzeY5J8q1PFBUkeK+robaPVRY9349/gf TXWEYZ61TN0C8/oKBnM9BqeCZIHkC+jDXd7ACvmG/sFOaYp6Jq64SYOrn1lLjgoeKcAs 0DyA== X-Received: by 10.180.182.116 with SMTP id ed20mr6480659wic.6.1367228275127; Mon, 29 Apr 2013 02:37:55 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.180.72.211 with SMTP id f19ls237842wiv.6.canary; Mon, 29 Apr 2013 02:37:55 -0700 (PDT) X-Received: by 10.194.119.33 with SMTP id kr1mr14214879wjb.36.1367228275067; Mon, 29 Apr 2013 02:37:55 -0700 (PDT) Received: from mail-ve0-x22a.google.com (mail-ve0-x22a.google.com [2607:f8b0:400c:c01::22a]) by mx.google.com with ESMTPS id m9si7005968wjx.253.2013.04.29.02.37.54 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 29 Apr 2013 02:37:54 -0700 (PDT) Received-SPF: neutral (google.com: 2607:f8b0:400c:c01::22a is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=2607:f8b0:400c:c01::22a; Received: by mail-ve0-f170.google.com with SMTP id 15so2913529vea.15 for ; Mon, 29 Apr 2013 02:37:53 -0700 (PDT) X-Received: by 10.220.242.73 with SMTP id lh9mr7129383vcb.49.1367228273703; Mon, 29 Apr 2013 02:37:53 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patches@linaro.org Received: by 10.58.127.98 with SMTP id nf2csp48713veb; Mon, 29 Apr 2013 02:37:53 -0700 (PDT) X-Received: by 10.66.51.102 with SMTP id j6mr33556990pao.210.1367228272897; Mon, 29 Apr 2013 02:37:52 -0700 (PDT) Received: from mail-pa0-f41.google.com (mail-pa0-f41.google.com [209.85.220.41]) by mx.google.com with ESMTPS id n6si16912101pan.217.2013.04.29.02.37.52 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 29 Apr 2013 02:37:52 -0700 (PDT) Received-SPF: neutral (google.com: 209.85.220.41 is neither permitted nor denied by best guess record for domain of sachin.kamat@linaro.org) client-ip=209.85.220.41; Received: by mail-pa0-f41.google.com with SMTP id kq12so2837166pab.28 for ; Mon, 29 Apr 2013 02:37:52 -0700 (PDT) X-Received: by 10.68.137.168 with SMTP id qj8mr42685771pbb.17.1367228272531; Mon, 29 Apr 2013 02:37:52 -0700 (PDT) Received: from linaro.sisodomain.com ([115.113.119.130]) by mx.google.com with ESMTPSA id br2sm23328203pbc.46.2013.04.29.02.37.49 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 29 Apr 2013 02:37:52 -0700 (PDT) From: Sachin Kamat To: linux-media@vger.kernel.org Cc: t.stanislaws@samsung.com, s.nawrocki@samsung.com, sachin.kamat@linaro.org, patches@linaro.org Subject: [PATCH 3/3] [media] s5p-tv: Fix incorrect usage of IS_ERR_OR_NULL in mixer_video.c Date: Mon, 29 Apr 2013 14:54:59 +0530 Message-Id: <1367227499-543-3-git-send-email-sachin.kamat@linaro.org> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1367227499-543-1-git-send-email-sachin.kamat@linaro.org> References: <1367227499-543-1-git-send-email-sachin.kamat@linaro.org> X-Gm-Message-State: ALoCoQkmNkbxwhCTRdoLK52lzTRhvZvI7F/DtGM9Ae4G0HoOFH+1Oe9mNsXwCPy5w91oYCl0QakS X-Original-Sender: sachin.kamat@linaro.org X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 2607:f8b0:400c:c01::22a is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Precedence: list Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org List-ID: X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , vb2_dma_contig_init_ctx does not return NULL. Use IS_ERR() instead. Signed-off-by: Sachin Kamat --- drivers/media/platform/s5p-tv/mixer_video.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/s5p-tv/mixer_video.c b/drivers/media/platform/s5p-tv/mixer_video.c index ef0efdf..25319de 100644 --- a/drivers/media/platform/s5p-tv/mixer_video.c +++ b/drivers/media/platform/s5p-tv/mixer_video.c @@ -81,7 +81,7 @@ int mxr_acquire_video(struct mxr_device *mdev, } mdev->alloc_ctx = vb2_dma_contig_init_ctx(mdev->dev); - if (IS_ERR_OR_NULL(mdev->alloc_ctx)) { + if (IS_ERR(mdev->alloc_ctx)) { mxr_err(mdev, "could not acquire vb2 allocator\n"); goto fail_v4l2_dev; }