From patchwork Mon Apr 29 09:24:58 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sachin Kamat X-Patchwork-Id: 16497 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-ye0-f197.google.com (mail-ye0-f197.google.com [209.85.213.197]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 43EE825E08 for ; Mon, 29 Apr 2013 09:45:44 +0000 (UTC) Received: by mail-ye0-f197.google.com with SMTP id q9sf9337081yen.8 for ; Mon, 29 Apr 2013 02:45:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:mime-version:x-beenthere:x-received:received-spf :x-received:x-forwarded-to:x-forwarded-for:delivered-to:x-received :received-spf:x-received:from:to:cc:subject:date:message-id:x-mailer :in-reply-to:references:x-gm-message-state:x-original-sender :x-original-authentication-results:precedence:mailing-list:list-id :x-google-group-id:list-post:list-help:list-archive:list-unsubscribe; bh=+hq0xdjdxfPBHjcBLs/LAmjdo8og/8DiXut2p8oyZHk=; b=IjSpdgmcb/shpWXKmdkFhf7CSCz36clAEjcb2kyikJJvOlQp46cQJDP+UjZurftMFE uUEqdq7Hw8S0/nXAmE9ItCMiLzbXz+YfFuj+m5yJwltHrJbsq1ZK3nFWBng92PC4Jh6r Piy2kwKnxlG+IWSwbK2BSjld9vfrLmLqxABXBlt2k3leiipyZeZiwXpiM2lV/3IPF2tF 6+fKw5YK+c+vtZXRF5Q4xYEKBDJU5FbLcTduoVbe1TcXyEiv+YgkB8Kty9TVuSfwE4xW +ENHefO83IRxmwOoxQ00fdYnmonH9qHR72IgZwvxdiEWfpRWCySuT7fAdZocqRVUgGS6 cITA== X-Received: by 10.224.217.195 with SMTP id hn3mr40301601qab.5.1367228271211; Mon, 29 Apr 2013 02:37:51 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.49.119.129 with SMTP id ku1ls1028743qeb.49.gmail; Mon, 29 Apr 2013 02:37:51 -0700 (PDT) X-Received: by 10.59.0.226 with SMTP id bb2mr10499959ved.1.1367228271017; Mon, 29 Apr 2013 02:37:51 -0700 (PDT) Received: from mail-vb0-x22b.google.com (mail-vb0-x22b.google.com [2607:f8b0:400c:c02::22b]) by mx.google.com with ESMTPS id x12si9535220vcv.26.2013.04.29.02.37.50 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 29 Apr 2013 02:37:51 -0700 (PDT) Received-SPF: neutral (google.com: 2607:f8b0:400c:c02::22b is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=2607:f8b0:400c:c02::22b; Received: by mail-vb0-f43.google.com with SMTP id q13so4096014vbe.30 for ; Mon, 29 Apr 2013 02:37:50 -0700 (PDT) X-Received: by 10.52.66.101 with SMTP id e5mr932092vdt.57.1367228270839; Mon, 29 Apr 2013 02:37:50 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patches@linaro.org Received: by 10.58.127.98 with SMTP id nf2csp48710veb; Mon, 29 Apr 2013 02:37:50 -0700 (PDT) X-Received: by 10.68.91.131 with SMTP id ce3mr69514714pbb.46.1367228269802; Mon, 29 Apr 2013 02:37:49 -0700 (PDT) Received: from mail-pd0-f181.google.com (mail-pd0-f181.google.com [209.85.192.181]) by mx.google.com with ESMTPS id iv6si16891946pac.299.2013.04.29.02.37.49 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 29 Apr 2013 02:37:49 -0700 (PDT) Received-SPF: neutral (google.com: 209.85.192.181 is neither permitted nor denied by best guess record for domain of sachin.kamat@linaro.org) client-ip=209.85.192.181; Received: by mail-pd0-f181.google.com with SMTP id q10so1163549pdj.40 for ; Mon, 29 Apr 2013 02:37:49 -0700 (PDT) X-Received: by 10.66.174.143 with SMTP id bs15mr41814869pac.17.1367228269421; Mon, 29 Apr 2013 02:37:49 -0700 (PDT) Received: from linaro.sisodomain.com ([115.113.119.130]) by mx.google.com with ESMTPSA id br2sm23328203pbc.46.2013.04.29.02.37.46 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 29 Apr 2013 02:37:48 -0700 (PDT) From: Sachin Kamat To: linux-media@vger.kernel.org Cc: t.stanislaws@samsung.com, s.nawrocki@samsung.com, sachin.kamat@linaro.org, patches@linaro.org Subject: [PATCH 2/3] [media] s5p-tv: Fix incorrect usage of IS_ERR_OR_NULL in mixer_drv.c Date: Mon, 29 Apr 2013 14:54:58 +0530 Message-Id: <1367227499-543-2-git-send-email-sachin.kamat@linaro.org> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1367227499-543-1-git-send-email-sachin.kamat@linaro.org> References: <1367227499-543-1-git-send-email-sachin.kamat@linaro.org> X-Gm-Message-State: ALoCoQljn5wNlXF7/XXEIEwXFSHGhIqWAm8BWqnifqrbO1Pd6Q/2js+znVc+P9PeY2PzrNvuKc/L X-Original-Sender: sachin.kamat@linaro.org X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 2607:f8b0:400c:c02::22b is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Precedence: list Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org List-ID: X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , NULL check on clocks obtained using common clock APIs should not be done. Use IS_ERR only. Signed-off-by: Sachin Kamat --- drivers/media/platform/s5p-tv/mixer_drv.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/media/platform/s5p-tv/mixer_drv.c b/drivers/media/platform/s5p-tv/mixer_drv.c index 5733033..8dd8b88 100644 --- a/drivers/media/platform/s5p-tv/mixer_drv.c +++ b/drivers/media/platform/s5p-tv/mixer_drv.c @@ -222,15 +222,15 @@ static void mxr_release_clocks(struct mxr_device *mdev) { struct mxr_resources *res = &mdev->res; - if (!IS_ERR_OR_NULL(res->sclk_dac)) + if (!IS_ERR(res->sclk_dac)) clk_put(res->sclk_dac); - if (!IS_ERR_OR_NULL(res->sclk_hdmi)) + if (!IS_ERR(res->sclk_hdmi)) clk_put(res->sclk_hdmi); - if (!IS_ERR_OR_NULL(res->sclk_mixer)) + if (!IS_ERR(res->sclk_mixer)) clk_put(res->sclk_mixer); - if (!IS_ERR_OR_NULL(res->vp)) + if (!IS_ERR(res->vp)) clk_put(res->vp); - if (!IS_ERR_OR_NULL(res->mixer)) + if (!IS_ERR(res->mixer)) clk_put(res->mixer); }