From patchwork Mon Apr 29 09:24:57 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sachin Kamat X-Patchwork-Id: 16496 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-qa0-f72.google.com (mail-qa0-f72.google.com [209.85.216.72]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 49B3525E08 for ; Mon, 29 Apr 2013 09:43:54 +0000 (UTC) Received: by mail-qa0-f72.google.com with SMTP id bn16sf3071561qab.3 for ; Mon, 29 Apr 2013 02:43:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:mime-version:x-beenthere:x-received:received-spf :x-received:x-forwarded-to:x-forwarded-for:delivered-to:x-received :received-spf:x-received:from:to:cc:subject:date:message-id:x-mailer :x-gm-message-state:x-original-sender :x-original-authentication-results:precedence:mailing-list:list-id :x-google-group-id:list-post:list-help:list-archive:list-unsubscribe; bh=qNWXD4nUm03OTbJACMGBj4gBekVBemnyGgsa67f1JcU=; b=ZIS5AGsBKBAfm9WMqPXIwx6s3QriwHjAUt6zFpr7dXckhbPDdiG4KhzVhNZsq/wWNp Vh8vBBJ1cQOBXS1/xHWyRq0ypZK5ZiA9najsFYf1C8H6kq3CoWNWTycVBlXVT1gXDvdq nzWe3rfpaP2soJDJB5zUOAKcaRht/WngBq5HnxVS9BKv3B5Eciz9PoK+fsmcwOW0xscb VHV0UbbehbUzi9byIUvwFFF7ZjB9yoX+jM7hsGHqO0RxEMCm/wsmwsGuqsTSqDCuI9JV Q7SFPhxgpUc5UKj+EJ6Bi8Q+v3stx1AEuaHz7WiB9SlC18bL8qsFUQEYoB2tY/aS7Z3B kg6Q== X-Received: by 10.224.58.77 with SMTP id f13mr40266863qah.7.1367228268776; Mon, 29 Apr 2013 02:37:48 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.49.94.78 with SMTP id da14ls2447763qeb.74.gmail; Mon, 29 Apr 2013 02:37:48 -0700 (PDT) X-Received: by 10.52.76.41 with SMTP id h9mr3543154vdw.12.1367228268596; Mon, 29 Apr 2013 02:37:48 -0700 (PDT) Received: from mail-vb0-x22d.google.com (mail-vb0-x22d.google.com [2607:f8b0:400c:c02::22d]) by mx.google.com with ESMTPS id o6si9515900vcx.62.2013.04.29.02.37.48 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 29 Apr 2013 02:37:48 -0700 (PDT) Received-SPF: neutral (google.com: 2607:f8b0:400c:c02::22d is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=2607:f8b0:400c:c02::22d; Received: by mail-vb0-f45.google.com with SMTP id p14so5083452vbm.32 for ; Mon, 29 Apr 2013 02:37:48 -0700 (PDT) X-Received: by 10.220.39.69 with SMTP id f5mr33319912vce.45.1367228268351; Mon, 29 Apr 2013 02:37:48 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patches@linaro.org Received: by 10.58.127.98 with SMTP id nf2csp48709veb; Mon, 29 Apr 2013 02:37:47 -0700 (PDT) X-Received: by 10.66.4.10 with SMTP id g10mr17511475pag.217.1367228266868; Mon, 29 Apr 2013 02:37:46 -0700 (PDT) Received: from mail-pa0-f48.google.com (mail-pa0-f48.google.com [209.85.220.48]) by mx.google.com with ESMTPS id te10si16547044pbc.205.2013.04.29.02.37.46 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 29 Apr 2013 02:37:46 -0700 (PDT) Received-SPF: neutral (google.com: 209.85.220.48 is neither permitted nor denied by best guess record for domain of sachin.kamat@linaro.org) client-ip=209.85.220.48; Received: by mail-pa0-f48.google.com with SMTP id lb1so1652089pab.21 for ; Mon, 29 Apr 2013 02:37:46 -0700 (PDT) X-Received: by 10.66.178.5 with SMTP id cu5mr42365477pac.16.1367228266343; Mon, 29 Apr 2013 02:37:46 -0700 (PDT) Received: from linaro.sisodomain.com ([115.113.119.130]) by mx.google.com with ESMTPSA id br2sm23328203pbc.46.2013.04.29.02.37.43 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 29 Apr 2013 02:37:45 -0700 (PDT) From: Sachin Kamat To: linux-media@vger.kernel.org Cc: t.stanislaws@samsung.com, s.nawrocki@samsung.com, sachin.kamat@linaro.org, patches@linaro.org Subject: [PATCH 1/3] [media] s5p-tv: Fix incorrect usage of IS_ERR_OR_NULL in hdmi_drv.c Date: Mon, 29 Apr 2013 14:54:57 +0530 Message-Id: <1367227499-543-1-git-send-email-sachin.kamat@linaro.org> X-Mailer: git-send-email 1.7.9.5 X-Gm-Message-State: ALoCoQmYNoadWLs75xRcQtRRxQTTK76bQQ4k5lWvPSvj0vUJSdg6nBFlvfj7zG2RRbEig7Sex6Ys X-Original-Sender: sachin.kamat@linaro.org X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 2607:f8b0:400c:c02::22d is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Precedence: list Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org List-ID: X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , NULL check on clocks obtained using common clock APIs should not be done. Use IS_ERR only. Signed-off-by: Sachin Kamat --- drivers/media/platform/s5p-tv/hdmi_drv.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/media/platform/s5p-tv/hdmi_drv.c b/drivers/media/platform/s5p-tv/hdmi_drv.c index 4e86626..b3344cb 100644 --- a/drivers/media/platform/s5p-tv/hdmi_drv.c +++ b/drivers/media/platform/s5p-tv/hdmi_drv.c @@ -765,15 +765,15 @@ static void hdmi_resources_cleanup(struct hdmi_device *hdev) regulator_bulk_free(res->regul_count, res->regul_bulk); /* kfree is NULL-safe */ kfree(res->regul_bulk); - if (!IS_ERR_OR_NULL(res->hdmiphy)) + if (!IS_ERR(res->hdmiphy)) clk_put(res->hdmiphy); - if (!IS_ERR_OR_NULL(res->sclk_hdmiphy)) + if (!IS_ERR(res->sclk_hdmiphy)) clk_put(res->sclk_hdmiphy); - if (!IS_ERR_OR_NULL(res->sclk_pixel)) + if (!IS_ERR(res->sclk_pixel)) clk_put(res->sclk_pixel); - if (!IS_ERR_OR_NULL(res->sclk_hdmi)) + if (!IS_ERR(res->sclk_hdmi)) clk_put(res->sclk_hdmi); - if (!IS_ERR_OR_NULL(res->hdmi)) + if (!IS_ERR(res->hdmi)) clk_put(res->hdmi); memset(res, 0, sizeof(*res)); }